From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
ezequiel@collabora.com, Wei Xu <xuwei5@hisilicon.com>,
Michal Simek <michal.simek@xilinx.com>,
pavel@ucw.cz, Andy Gross <andy.gross@linaro.org>,
linux-leds@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
lakml <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rockchip@lists.infradead.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
koen.kooi@linaro.org, nicolas.dechesne@linaro.org
Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels
Date: Mon, 29 Oct 2018 15:02:10 +0530 [thread overview]
Message-ID: <20181029093210.GA6110@Mani-XPS-13-9360> (raw)
In-Reply-To: <CAHLCerM91ukzAJZHaxXxwoHU-6mVUV+X9_y_Rs0zmybNnRJCfA@mail.gmail.com>
On Mon, Oct 29, 2018 at 02:47:11PM +0530, Amit Kucheria wrote:
> On Mon, Oct 29, 2018 at 2:31 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> >
> > For all 96Boards, the following standard is used for onboard LEDs.
> >
> > green:user1 default-trigger: heartbeat
> > green:user2 default-trigger: mmc0/disk-activity(onboard-storage)
> > green:user3 default-trigger: mmc1 (SD-card)
> > green:user4 default-trigger: none, panic-indicator
> > yellow:wlan default-trigger: phy0tx
> > blue:bt default-trigger: hci0-power
> >
> > So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> > one of the 96Boards CE platform.
>
> You are missing a signed-off here :-)
>
ahh, my bad. Will fix it in next revision.
Thanks,
Mani
> Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> > ---
> > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > index 46feedf7c989..35f95154316b 100644
> > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > @@ -300,28 +300,28 @@
> > compatible = "gpio-leds";
> >
> > led@1 {
> > - label = "apq8016-sbc:green:user1";
> > + label = "green:user1";
> > gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "heartbeat";
> > default-state = "off";
> > };
> >
> > led@2 {
> > - label = "apq8016-sbc:green:user2";
> > + label = "green:user2";
> > gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "mmc0";
> > default-state = "off";
> > };
> >
> > led@3 {
> > - label = "apq8016-sbc:green:user3";
> > + label = "green:user3";
> > gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "mmc1";
> > default-state = "off";
> > };
> >
> > led@4 {
> > - label = "apq8016-sbc:green:user4";
> > + label = "green:user4";
> > gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "none";
> > panic-indicator;
> > @@ -329,14 +329,14 @@
> > };
> >
> > led@5 {
> > - label = "apq8016-sbc:yellow:wlan";
> > + label = "yellow:wlan";
> > gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "phy0tx";
> > default-state = "off";
> > };
> >
> > led@6 {
> > - label = "apq8016-sbc:blue:bt";
> > + label = "blue:bt";
> > gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "bluetooth-power";
> > default-state = "off";
> > --
> > 2.17.1
> >
WARNING: multiple messages have this Message-ID (diff)
From: manivannan.sadhasivam@linaro.org (Manivannan Sadhasivam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels
Date: Mon, 29 Oct 2018 15:02:10 +0530 [thread overview]
Message-ID: <20181029093210.GA6110@Mani-XPS-13-9360> (raw)
In-Reply-To: <CAHLCerM91ukzAJZHaxXxwoHU-6mVUV+X9_y_Rs0zmybNnRJCfA@mail.gmail.com>
On Mon, Oct 29, 2018 at 02:47:11PM +0530, Amit Kucheria wrote:
> On Mon, Oct 29, 2018 at 2:31 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> >
> > For all 96Boards, the following standard is used for onboard LEDs.
> >
> > green:user1 default-trigger: heartbeat
> > green:user2 default-trigger: mmc0/disk-activity(onboard-storage)
> > green:user3 default-trigger: mmc1 (SD-card)
> > green:user4 default-trigger: none, panic-indicator
> > yellow:wlan default-trigger: phy0tx
> > blue:bt default-trigger: hci0-power
> >
> > So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> > one of the 96Boards CE platform.
>
> You are missing a signed-off here :-)
>
ahh, my bad. Will fix it in next revision.
Thanks,
Mani
> Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> > ---
> > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > index 46feedf7c989..35f95154316b 100644
> > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > @@ -300,28 +300,28 @@
> > compatible = "gpio-leds";
> >
> > led at 1 {
> > - label = "apq8016-sbc:green:user1";
> > + label = "green:user1";
> > gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "heartbeat";
> > default-state = "off";
> > };
> >
> > led at 2 {
> > - label = "apq8016-sbc:green:user2";
> > + label = "green:user2";
> > gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "mmc0";
> > default-state = "off";
> > };
> >
> > led at 3 {
> > - label = "apq8016-sbc:green:user3";
> > + label = "green:user3";
> > gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "mmc1";
> > default-state = "off";
> > };
> >
> > led at 4 {
> > - label = "apq8016-sbc:green:user4";
> > + label = "green:user4";
> > gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "none";
> > panic-indicator;
> > @@ -329,14 +329,14 @@
> > };
> >
> > led at 5 {
> > - label = "apq8016-sbc:yellow:wlan";
> > + label = "yellow:wlan";
> > gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "phy0tx";
> > default-state = "off";
> > };
> >
> > led at 6 {
> > - label = "apq8016-sbc:blue:bt";
> > + label = "blue:bt";
> > gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
> > linux,default-trigger = "bluetooth-power";
> > default-state = "off";
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2018-10-29 9:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 8:59 [PATCH v2 0/7] Standardize onboard LED support for 96Boards Manivannan Sadhasivam
2018-10-29 8:59 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 1/7] arm64: dts: rockchip: ficus: Add on-board LED support Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 2/7] arm64: dts: rockchip: rock960: " Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 3/7] arm64: dts: hisilicon: hikey: Standardize LED labels and triggers Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 4/7] arm64: dts: hisilicon: hikey960: " Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 5/7] arm64: dts: hisilicon: poplar: " Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 6/7] arm64: dts: xilinx: ultra96: " Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:00 ` [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels Manivannan Sadhasivam
2018-10-29 9:00 ` Manivannan Sadhasivam
2018-10-29 9:17 ` Amit Kucheria
2018-10-29 9:17 ` Amit Kucheria
2018-10-29 9:17 ` Amit Kucheria
2018-10-29 9:32 ` Manivannan Sadhasivam [this message]
2018-10-29 9:32 ` Manivannan Sadhasivam
2018-10-29 9:32 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029093210.GA6110@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=koen.kooi@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-soc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nicolas.dechesne@linaro.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.