[PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Niklas Söderlund]

From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Successfully tested on H3 ES2.0 and M3-N ES1.0.
Transfer rates where >160MB/s for H3 and >200MB/s for M3-N.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 +
 arch/arm64/boot/dts/renesas/ulcb.dtsi            | 1 +
 2 files changed, 2 insertions(+)
---

Hi Simon,

This patch have quiet a few dependencies I'm afraid, let me know if you 
wish to be notified once they all upstream. I don't think it's a good 
idea to pick this up before all dependencies are resolved.

- [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock
- [PATCH v3 0/3] mmc: tmio: fix reset operation
- [PATCH v2 0/3] mmc: renesas_sdhi: extend quirk selection to handle ES revisions
- [PATCH 0/2] renesas: rcar-gen3: add HS400 quirk for SD clock


diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index d28ae95405f1152b..6bc041cc63bdc81b 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -762,6 +762,7 @@
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
 	non-removable;
 	fixed-emmc-driver-type = <1>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 7e6078508ba0ba19..88d03177ae2b327c 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -430,6 +430,7 @@
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
 	non-removable;
 	status = "okay";
 };
-- 
2.19.1

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]


> This patch have quiet a few dependencies I'm afraid, let me know if you 
> wish to be notified once they all upstream. I don't think it's a good 
> idea to pick this up before all dependencies are resolved.

Yes, we should do that. Ping Simon once all dependencies are in next. It
is still fine to have this patch here in case people want to test. BTW
did you mention your branch somewhere where you collected all these
patches to make HS400 working/enabled?

For this patch already:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]


And this concludes my first patch review session while being on a ship
:) Thanks for this SDHI hackathon guys, and looking forward to seeing
you again!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Simon Horman]

On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> 
> > This patch have quiet a few dependencies I'm afraid, let me know if you 
> > wish to be notified once they all upstream. I don't think it's a good 
> > idea to pick this up before all dependencies are resolved.
> 
> Yes, we should do that. Ping Simon once all dependencies are in next. It
> is still fine to have this patch here in case people want to test. BTW
> did you mention your branch somewhere where you collected all these
> patches to make HS400 working/enabled?
> 
> For this patch already:
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks, I am marking this as deferred.

Please repost or ping me once the dependencies are present in
an rc release.

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > 
> > > This patch have quiet a few dependencies I'm afraid, let me know if you 
> > > wish to be notified once they all upstream. I don't think it's a good 
> > > idea to pick this up before all dependencies are resolved.
> > 
> > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > is still fine to have this patch here in case people want to test. BTW
> > did you mention your branch somewhere where you collected all these
> > patches to make HS400 working/enabled?
> > 
> > For this patch already:
> > 
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Thanks, I am marking this as deferred.
> 
> Please repost or ping me once the dependencies are present in
> an rc release.

Niklas, are we done now, so we can ask Simon to pick up the DTS change?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Niklas Söderlund]

Hi Wolfram,

On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > 
> > > > This patch have quiet a few dependencies I'm afraid, let me know if you 
> > > > wish to be notified once they all upstream. I don't think it's a good 
> > > > idea to pick this up before all dependencies are resolved.
> > > 
> > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > is still fine to have this patch here in case people want to test. BTW
> > > did you mention your branch somewhere where you collected all these
> > > patches to make HS400 working/enabled?
> > > 
> > > For this patch already:
> > > 
> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > Thanks, I am marking this as deferred.
> > 
> > Please repost or ping me once the dependencies are present in
> > an rc release.
> 
> Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> 

Almost :-)

I'm  waiting for Geert to take the SD quirk patches before pinging Simon 
to take this one. Spoke to him today about that so I hope it will not be 
to long.

-- 
Regards,
Niklas S�derlund

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Niklas Söderlund]

Hi Simon, Wolfram,

On 2018-12-05 22:36:13 +0100, Niklas S�derlund wrote:
> Hi Wolfram,
> 
> On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > 
> > > > > This patch have quiet a few dependencies I'm afraid, let me know if you 
> > > > > wish to be notified once they all upstream. I don't think it's a good 
> > > > > idea to pick this up before all dependencies are resolved.
> > > > 
> > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > is still fine to have this patch here in case people want to test. BTW
> > > > did you mention your branch somewhere where you collected all these
> > > > patches to make HS400 working/enabled?
> > > > 
> > > > For this patch already:
> > > > 
> > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > Thanks, I am marking this as deferred.
> > > 
> > > Please repost or ping me once the dependencies are present in
> > > an rc release.
> > 
> > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > 
> 
> Almost :-)
> 
> I'm  waiting for Geert to take the SD quirk patches before pinging Simon 
> to take this one. Spoke to him today about that so I hope it will not be 
> to long.
> 

I just confirmation that the clock patches have been pulled into 
clk-next so this patch is ready to be consumed by you Simon.

Would it be possible to get this in this cycle or is it to late? I know 
you wished to close your tree for v4.21 at the end of this week which it 
technically is now ;-)

-- 
Regards,
Niklas S�derlund

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Simon Horman]

On Fri, Dec 07, 2018 at 09:52:04PM +0100, Niklas Söderlund wrote:
> Hi Simon, Wolfram,
> 
> On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote:
> > Hi Wolfram,
> > 
> > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > > 
> > > > > > This patch have quiet a few dependencies I'm afraid, let me know if you 
> > > > > > wish to be notified once they all upstream. I don't think it's a good 
> > > > > > idea to pick this up before all dependencies are resolved.
> > > > > 
> > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > > is still fine to have this patch here in case people want to test. BTW
> > > > > did you mention your branch somewhere where you collected all these
> > > > > patches to make HS400 working/enabled?
> > > > > 
> > > > > For this patch already:
> > > > > 
> > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > 
> > > > Thanks, I am marking this as deferred.
> > > > 
> > > > Please repost or ping me once the dependencies are present in
> > > > an rc release.
> > > 
> > > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > > 
> > 
> > Almost :-)
> > 
> > I'm  waiting for Geert to take the SD quirk patches before pinging Simon 
> > to take this one. Spoke to him today about that so I hope it will not be 
> > to long.
> > 
> 
> I just confirmation that the clock patches have been pulled into 
> clk-next so this patch is ready to be consumed by you Simon.
> 
> Would it be possible to get this in this cycle or is it to late? I know 
> you wished to close your tree for v4.21 at the end of this week which it 
> technically is now ;-)

Hi Niklas,

I'm sorry but it was too late. I have queued this up for v4.22.

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Geert Uytterhoeven]

Hi Niklas, Simon,

On Fri, Dec 7, 2018 at 9:52 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote:
> > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > >
> > > > > > This patch have quiet a few dependencies I'm afraid, let me know if you
> > > > > > wish to be notified once they all upstream. I don't think it's a good
> > > > > > idea to pick this up before all dependencies are resolved.
> > > > >
> > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > > is still fine to have this patch here in case people want to test. BTW
> > > > > did you mention your branch somewhere where you collected all these
> > > > > patches to make HS400 working/enabled?
> > > > >
> > > > > For this patch already:
> > > > >
> > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > >
> > > > Thanks, I am marking this as deferred.
> > > >
> > > > Please repost or ping me once the dependencies are present in
> > > > an rc release.
> > >
> > > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > >
> >
> > Almost :-)
> >
> > I'm  waiting for Geert to take the SD quirk patches before pinging Simon
> > to take this one. Spoke to him today about that so I hope it will not be
> > to long.
> >
>
> I just confirmation that the clock patches have been pulled into
> clk-next so this patch is ready to be consumed by you Simon.
>
> Would it be possible to get this in this cycle or is it to late? I know
> you wished to close your tree for v4.21 at the end of this week which it
> technically is now ;-)

This patch seems to depend on both the clock patches, and mmc/next.
Else the kernel hangs with an rcu check :-(

Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Simon Horman]

On Tue, Dec 18, 2018 at 10:07:13AM +0100, Geert Uytterhoeven wrote:
> Hi Niklas, Simon,
> 
> On Fri, Dec 7, 2018 at 9:52 PM Niklas Söderlund
> <niklas.soderlund@ragnatech.se> wrote:
> > On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote:
> > > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > > >
> > > > > > > This patch have quiet a few dependencies I'm afraid, let me know if you
> > > > > > > wish to be notified once they all upstream. I don't think it's a good
> > > > > > > idea to pick this up before all dependencies are resolved.
> > > > > >
> > > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > > > is still fine to have this patch here in case people want to test. BTW
> > > > > > did you mention your branch somewhere where you collected all these
> > > > > > patches to make HS400 working/enabled?
> > > > > >
> > > > > > For this patch already:
> > > > > >
> > > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > >
> > > > > Thanks, I am marking this as deferred.
> > > > >
> > > > > Please repost or ping me once the dependencies are present in
> > > > > an rc release.
> > > >
> > > > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > > >
> > >
> > > Almost :-)
> > >
> > > I'm  waiting for Geert to take the SD quirk patches before pinging Simon
> > > to take this one. Spoke to him today about that so I hope it will not be
> > > to long.
> > >
> >
> > I just confirmation that the clock patches have been pulled into
> > clk-next so this patch is ready to be consumed by you Simon.
> >
> > Would it be possible to get this in this cycle or is it to late? I know
> > you wished to close your tree for v4.21 at the end of this week which it
> > technically is now ;-)
> 
> This patch seems to depend on both the clock patches, and mmc/next.
> Else the kernel hangs with an rcu check :-(
> 
> Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.

Thanks, dropped and marked as deferred.

Niklas, please repost or ping me once the dependencies are present in an RC
release.

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Niklas Söderlund]

Hi Simon,

On 2018-12-18 11:24:13 +0100, Simon Horman wrote:
> On Tue, Dec 18, 2018 at 10:07:13AM +0100, Geert Uytterhoeven wrote:
> > Hi Niklas, Simon,
> > 
> > On Fri, Dec 7, 2018 at 9:52 PM Niklas Söderlund
> > <niklas.soderlund@ragnatech.se> wrote:
> > > On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote:
> > > > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > > > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > > > >
> > > > > > > > This patch have quiet a few dependencies I'm afraid, let me know if you
> > > > > > > > wish to be notified once they all upstream. I don't think it's a good
> > > > > > > > idea to pick this up before all dependencies are resolved.
> > > > > > >
> > > > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > > > > is still fine to have this patch here in case people want to test. BTW
> > > > > > > did you mention your branch somewhere where you collected all these
> > > > > > > patches to make HS400 working/enabled?
> > > > > > >
> > > > > > > For this patch already:
> > > > > > >
> > > > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > >
> > > > > > Thanks, I am marking this as deferred.
> > > > > >
> > > > > > Please repost or ping me once the dependencies are present in
> > > > > > an rc release.
> > > > >
> > > > > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > > > >
> > > >
> > > > Almost :-)
> > > >
> > > > I'm  waiting for Geert to take the SD quirk patches before pinging Simon
> > > > to take this one. Spoke to him today about that so I hope it will not be
> > > > to long.
> > > >
> > >
> > > I just confirmation that the clock patches have been pulled into
> > > clk-next so this patch is ready to be consumed by you Simon.
> > >
> > > Would it be possible to get this in this cycle or is it to late? I know
> > > you wished to close your tree for v4.21 at the end of this week which it
> > > technically is now ;-)
> > 
> > This patch seems to depend on both the clock patches, and mmc/next.
> > Else the kernel hangs with an rcu check :-(
> > 
> > Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
> 
> Thanks, dropped and marked as deferred.
> 
> Niklas, please repost or ping me once the dependencies are present in an RC
> release.

Ping.

-- 
Regards,
Niklas Söderlund

Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3

[Simon Horman]

On Thu, Jan 24, 2019 at 11:24:22AM +0100, Niklas Söderlund wrote:
> Hi Simon,
> 
> On 2018-12-18 11:24:13 +0100, Simon Horman wrote:
> > On Tue, Dec 18, 2018 at 10:07:13AM +0100, Geert Uytterhoeven wrote:
> > > Hi Niklas, Simon,
> > > 
> > > On Fri, Dec 7, 2018 at 9:52 PM Niklas Söderlund
> > > <niklas.soderlund@ragnatech.se> wrote:
> > > > On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote:
> > > > > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote:
> > > > > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote:
> > > > > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote:
> > > > > > > >
> > > > > > > > > This patch have quiet a few dependencies I'm afraid, let me know if you
> > > > > > > > > wish to be notified once they all upstream. I don't think it's a good
> > > > > > > > > idea to pick this up before all dependencies are resolved.
> > > > > > > >
> > > > > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It
> > > > > > > > is still fine to have this patch here in case people want to test. BTW
> > > > > > > > did you mention your branch somewhere where you collected all these
> > > > > > > > patches to make HS400 working/enabled?
> > > > > > > >
> > > > > > > > For this patch already:
> > > > > > > >
> > > > > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > > > > Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > > > > >
> > > > > > > Thanks, I am marking this as deferred.
> > > > > > >
> > > > > > > Please repost or ping me once the dependencies are present in
> > > > > > > an rc release.
> > > > > >
> > > > > > Niklas, are we done now, so we can ask Simon to pick up the DTS change?
> > > > > >
> > > > >
> > > > > Almost :-)
> > > > >
> > > > > I'm  waiting for Geert to take the SD quirk patches before pinging Simon
> > > > > to take this one. Spoke to him today about that so I hope it will not be
> > > > > to long.
> > > > >
> > > >
> > > > I just confirmation that the clock patches have been pulled into
> > > > clk-next so this patch is ready to be consumed by you Simon.
> > > >
> > > > Would it be possible to get this in this cycle or is it to late? I know
> > > > you wished to close your tree for v4.21 at the end of this week which it
> > > > technically is now ;-)
> > > 
> > > This patch seems to depend on both the clock patches, and mmc/next.
> > > Else the kernel hangs with an rcu check :-(
> > > 
> > > Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
> > 
> > Thanks, dropped and marked as deferred.
> > 
> > Niklas, please repost or ping me once the dependencies are present in an RC
> > release.
> 
> Ping.

Hi Niklas,

with this applied on top of renesas-devel-20190124-v5.0-rc3
I see eMMC initialised in

* HS200 mode on Salvator-X/M3-W  ES1.0
* HS400 mode on Salvator-XS/H3   ES2.0
* HS400 mode on Salvator-XS/M3-N ES1.0

I believe that is expected and have gone ahead and applied this patch.