* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes
@ 2018-11-05 21:41 ` Marek Vasut
0 siblings, 0 replies; 33+ messages in thread
From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw)
To: devicetree
Cc: Takeshi Kihara, Geert Uytterhoeven, Wolfram Sang,
Yoshihiro Shimoda, linux-renesas-soc, Simon Horman,
linux-arm-kernel, Marek Vasut
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 36 +++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 9509dc05665f..fb0818d07cdb 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -826,6 +826,42 @@
status = "disabled";
};
+ sdhi0: sd@ee100000 {
+ compatible = "renesas,sdhi-r8a77990",
+ "renesas,rcar-gen3-sdhi";
+ reg = <0 0xee100000 0 0x2000>;
+ interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 314>;
+ max-frequency = <200000000>;
+ power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+ resets = <&cpg 314>;
+ status = "disabled";
+ };
+
+ sdhi1: sd@ee120000 {
+ compatible = "renesas,sdhi-r8a77990",
+ "renesas,rcar-gen3-sdhi";
+ reg = <0 0xee120000 0 0x2000>;
+ interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 313>;
+ max-frequency = <200000000>;
+ power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+ resets = <&cpg 313>;
+ status = "disabled";
+ };
+
+ sdhi3: sd@ee160000 {
+ compatible = "renesas,sdhi-r8a77990",
+ "renesas,rcar-gen3-sdhi";
+ reg = <0 0xee160000 0 0x2000>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 311>;
+ max-frequency = <200000000>;
+ power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
+ resets = <&cpg 311>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@f1010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
--
2.18.0
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-05 21:41 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw) To: linux-arm-kernel From: Takeshi Kihara <takeshi.kihara.df@renesas.com> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-renesas-soc at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 36 +++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 9509dc05665f..fb0818d07cdb 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -826,6 +826,42 @@ status = "disabled"; }; + sdhi0: sd at ee100000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee100000 0 0x2000>; + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 314>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 314>; + status = "disabled"; + }; + + sdhi1: sd at ee120000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee120000 0 0x2000>; + interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 313>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 313>; + status = "disabled"; + }; + + sdhi3: sd at ee160000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee160000 0 0x2000>; + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 311>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 311>; + status = "disabled"; + }; + gic: interrupt-controller at f1010000 { compatible = "arm,gic-400"; #interrupt-cells = <3>; -- 2.18.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-05 21:41 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw) To: devicetree Cc: Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, Yoshihiro Shimoda, linux-renesas-soc, linux-arm-kernel From: Takeshi Kihara <takeshi.kihara.df@renesas.com> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 36 +++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 9509dc05665f..fb0818d07cdb 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -826,6 +826,42 @@ status = "disabled"; }; + sdhi0: sd@ee100000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee100000 0 0x2000>; + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 314>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 314>; + status = "disabled"; + }; + + sdhi1: sd@ee120000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee120000 0 0x2000>; + interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 313>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 313>; + status = "disabled"; + }; + + sdhi3: sd@ee160000 { + compatible = "renesas,sdhi-r8a77990", + "renesas,rcar-gen3-sdhi"; + reg = <0 0xee160000 0 0x2000>; + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 311>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 311>; + status = "disabled"; + }; + gic: interrupt-controller@f1010000 { compatible = "arm,gic-400"; #interrupt-cells = <3>; -- 2.18.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces 2018-11-05 21:41 ` Marek Vasut (?) @ 2018-11-05 21:41 ` Marek Vasut -1 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw) To: devicetree Cc: Takeshi Kihara, Geert Uytterhoeven, Wolfram Sang, Yoshihiro Shimoda, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut From: Takeshi Kihara <takeshi.kihara.df@renesas.com> This patch enables SD card slot connected to SDHI0, micro SD card slot connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using the R8A77990 SoC. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ 1 file changed, 136 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 611f0265fcc5..bda1765dcdbd 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -119,6 +119,15 @@ }; }; + reg_1p8v: regulator0 { + compatible = "regulator-fixed"; + regulator-name = "fixed-1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + reg_3p3v: regulator1 { compatible = "regulator-fixed"; regulator-name = "fixed-3.3V"; @@ -133,6 +142,54 @@ #clock-cells = <0>; clock-frequency = <74250000>; }; + + vcc_sdhi0: regulator-vcc-sdhi0 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI0 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi0: regulator-vccq-sdhi0 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI0 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; + + vcc_sdhi1: regulator-vcc-sdhi1 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI1 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio0 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi1: regulator-vccq-sdhi1 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI1 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; }; &avb { @@ -326,6 +383,42 @@ function = "scif2"; }; + sdhi0_pins: sd0 { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <3300>; + }; + + sdhi0_pins_uhs: sd0_uhs { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <1800>; + }; + + sdhi1_pins: sd1 { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <3300>; + }; + + sdhi1_pins_uhs: sd1_uhs { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <1800>; + }; + + sdhi3_pins: sd3 { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + + sdhi3_pins_uhs: sd3_uhs { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + usb0_pins: usb { groups = "usb0_b"; function = "usb0"; @@ -380,3 +473,46 @@ status = "okay"; }; + +&sdhi0 { + pinctrl-0 = <&sdhi0_pins>; + pinctrl-1 = <&sdhi0_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi0>; + vqmmc-supply = <&vccq_sdhi0>; + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi1 { + pinctrl-0 = <&sdhi1_pins>; + pinctrl-1 = <&sdhi1_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi1>; + vqmmc-supply = <&vccq_sdhi1>; + cd-gpios = <&gpio3 14 GPIO_ACTIVE_LOW>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi3 { + /* used for on-board 8bit eMMC */ + pinctrl-0 = <&sdhi3_pins>; + pinctrl-1 = <&sdhi3_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <®_3p3v>; + vqmmc-supply = <®_1p8v>; + mmc-hs200-1_8v; + bus-width = <8>; + non-removable; + status = "okay"; +}; -- 2.18.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-05 21:41 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw) To: linux-arm-kernel From: Takeshi Kihara <takeshi.kihara.df@renesas.com> This patch enables SD card slot connected to SDHI0, micro SD card slot connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using the R8A77990 SoC. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-renesas-soc at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org --- .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ 1 file changed, 136 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 611f0265fcc5..bda1765dcdbd 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -119,6 +119,15 @@ }; }; + reg_1p8v: regulator0 { + compatible = "regulator-fixed"; + regulator-name = "fixed-1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + reg_3p3v: regulator1 { compatible = "regulator-fixed"; regulator-name = "fixed-3.3V"; @@ -133,6 +142,54 @@ #clock-cells = <0>; clock-frequency = <74250000>; }; + + vcc_sdhi0: regulator-vcc-sdhi0 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI0 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi0: regulator-vccq-sdhi0 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI0 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; + + vcc_sdhi1: regulator-vcc-sdhi1 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI1 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio0 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi1: regulator-vccq-sdhi1 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI1 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; }; &avb { @@ -326,6 +383,42 @@ function = "scif2"; }; + sdhi0_pins: sd0 { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <3300>; + }; + + sdhi0_pins_uhs: sd0_uhs { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <1800>; + }; + + sdhi1_pins: sd1 { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <3300>; + }; + + sdhi1_pins_uhs: sd1_uhs { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <1800>; + }; + + sdhi3_pins: sd3 { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + + sdhi3_pins_uhs: sd3_uhs { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + usb0_pins: usb { groups = "usb0_b"; function = "usb0"; @@ -380,3 +473,46 @@ status = "okay"; }; + +&sdhi0 { + pinctrl-0 = <&sdhi0_pins>; + pinctrl-1 = <&sdhi0_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi0>; + vqmmc-supply = <&vccq_sdhi0>; + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi1 { + pinctrl-0 = <&sdhi1_pins>; + pinctrl-1 = <&sdhi1_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi1>; + vqmmc-supply = <&vccq_sdhi1>; + cd-gpios = <&gpio3 14 GPIO_ACTIVE_LOW>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi3 { + /* used for on-board 8bit eMMC */ + pinctrl-0 = <&sdhi3_pins>; + pinctrl-1 = <&sdhi3_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <®_3p3v>; + vqmmc-supply = <®_1p8v>; + mmc-hs200-1_8v; + bus-width = <8>; + non-removable; + status = "okay"; +}; -- 2.18.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-05 21:41 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-05 21:41 UTC (permalink / raw) To: devicetree Cc: Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, Yoshihiro Shimoda, linux-renesas-soc, linux-arm-kernel From: Takeshi Kihara <takeshi.kihara.df@renesas.com> This patch enables SD card slot connected to SDHI0, micro SD card slot connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using the R8A77990 SoC. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ 1 file changed, 136 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 611f0265fcc5..bda1765dcdbd 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -119,6 +119,15 @@ }; }; + reg_1p8v: regulator0 { + compatible = "regulator-fixed"; + regulator-name = "fixed-1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + reg_3p3v: regulator1 { compatible = "regulator-fixed"; regulator-name = "fixed-3.3V"; @@ -133,6 +142,54 @@ #clock-cells = <0>; clock-frequency = <74250000>; }; + + vcc_sdhi0: regulator-vcc-sdhi0 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI0 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi0: regulator-vccq-sdhi0 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI0 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; + + vcc_sdhi1: regulator-vcc-sdhi1 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI1 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio0 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi1: regulator-vccq-sdhi1 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI1 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; }; &avb { @@ -326,6 +383,42 @@ function = "scif2"; }; + sdhi0_pins: sd0 { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <3300>; + }; + + sdhi0_pins_uhs: sd0_uhs { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <1800>; + }; + + sdhi1_pins: sd1 { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <3300>; + }; + + sdhi1_pins_uhs: sd1_uhs { + groups = "sdhi1_data4", "sdhi1_ctrl"; + function = "sdhi1"; + power-source = <1800>; + }; + + sdhi3_pins: sd3 { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + + sdhi3_pins_uhs: sd3_uhs { + groups = "sdhi3_data8", "sdhi3_ctrl"; + function = "sdhi3"; + power-source = <1800>; + }; + usb0_pins: usb { groups = "usb0_b"; function = "usb0"; @@ -380,3 +473,46 @@ status = "okay"; }; + +&sdhi0 { + pinctrl-0 = <&sdhi0_pins>; + pinctrl-1 = <&sdhi0_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi0>; + vqmmc-supply = <&vccq_sdhi0>; + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi1 { + pinctrl-0 = <&sdhi1_pins>; + pinctrl-1 = <&sdhi1_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi1>; + vqmmc-supply = <&vccq_sdhi1>; + cd-gpios = <&gpio3 14 GPIO_ACTIVE_LOW>; + bus-width = <4>; + sd-uhs-sdr50; + sd-uhs-sdr104; + status = "okay"; +}; + +&sdhi3 { + /* used for on-board 8bit eMMC */ + pinctrl-0 = <&sdhi3_pins>; + pinctrl-1 = <&sdhi3_pins_uhs>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <®_3p3v>; + vqmmc-supply = <®_1p8v>; + mmc-hs200-1_8v; + bus-width = <8>; + non-removable; + status = "okay"; +}; -- 2.18.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* RE: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces 2018-11-05 21:41 ` Marek Vasut (?) @ 2018-11-06 5:29 ` Yoshihiro Shimoda -1 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:29 UTC (permalink / raw) To: Marek Vasut, devicetree Cc: TAKESHI KIHARA, Geert Uytterhoeven, Wolfram Sang, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch enables SD card slot connected to SDHI0, micro SD card slot > connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using > the R8A77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I have a few nit comments below. > .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 611f0265fcc5..bda1765dcdbd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts <snip> > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 5:29 ` Yoshihiro Shimoda 0 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:29 UTC (permalink / raw) To: linux-arm-kernel Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch enables SD card slot connected to SDHI0, micro SD card slot > connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using > the R8A77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I have a few nit comments below. > .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 611f0265fcc5..bda1765dcdbd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts <snip> > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 5:29 ` Yoshihiro Shimoda 0 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:29 UTC (permalink / raw) To: Marek Vasut, devicetree Cc: TAKESHI KIHARA, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, linux-renesas-soc, linux-arm-kernel Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch enables SD card slot connected to SDHI0, micro SD card slot > connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using > the R8A77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I have a few nit comments below. > .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 611f0265fcc5..bda1765dcdbd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts <snip> > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces 2018-11-06 5:29 ` Yoshihiro Shimoda (?) @ 2018-11-06 9:17 ` Marek Vasut -1 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:17 UTC (permalink / raw) To: Yoshihiro Shimoda, devicetree Cc: TAKESHI KIHARA, Geert Uytterhoeven, Wolfram Sang, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > <snip> >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 9:17 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:17 UTC (permalink / raw) To: linux-arm-kernel On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > <snip> >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 9:17 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:17 UTC (permalink / raw) To: Yoshihiro Shimoda, devicetree Cc: TAKESHI KIHARA, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, linux-renesas-soc, linux-arm-kernel On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > <snip> >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces 2018-11-05 21:41 ` Marek Vasut (?) @ 2018-11-06 8:34 ` Wolfram Sang -1 siblings, 0 replies; 33+ messages in thread From: Wolfram Sang @ 2018-11-06 8:34 UTC (permalink / raw) To: Marek Vasut Cc: devicetree, Takeshi Kihara, Geert Uytterhoeven, Yoshihiro Shimoda, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut [-- Attachment #1.1: Type: text/plain, Size: 360 bytes --] > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; Shouldn't we have only one pinctrl config here, like you did recently for the other Gen3 SoCs? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 8:34 ` Wolfram Sang 0 siblings, 0 replies; 33+ messages in thread From: Wolfram Sang @ 2018-11-06 8:34 UTC (permalink / raw) To: linux-arm-kernel > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; Shouldn't we have only one pinctrl config here, like you did recently for the other Gen3 SoCs? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181106/af029d94/attachment.sig> ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 8:34 ` Wolfram Sang 0 siblings, 0 replies; 33+ messages in thread From: Wolfram Sang @ 2018-11-06 8:34 UTC (permalink / raw) To: Marek Vasut Cc: devicetree, Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Yoshihiro Shimoda, linux-renesas-soc, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 360 bytes --] > + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; Shouldn't we have only one pinctrl config here, like you did recently for the other Gen3 SoCs? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces 2018-11-06 8:34 ` Wolfram Sang (?) @ 2018-11-06 9:18 ` Marek Vasut -1 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:18 UTC (permalink / raw) To: Wolfram Sang Cc: devicetree, Takeshi Kihara, Geert Uytterhoeven, Yoshihiro Shimoda, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut On 11/06/2018 09:34 AM, Wolfram Sang wrote: > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > Shouldn't we have only one pinctrl config here, like you did recently > for the other Gen3 SoCs? We should, thanks for pointing it out, fixed in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 9:18 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:18 UTC (permalink / raw) To: linux-arm-kernel On 11/06/2018 09:34 AM, Wolfram Sang wrote: > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > Shouldn't we have only one pinctrl config here, like you did recently > for the other Gen3 SoCs? We should, thanks for pointing it out, fixed in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces @ 2018-11-06 9:18 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:18 UTC (permalink / raw) To: Wolfram Sang Cc: devicetree, Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Yoshihiro Shimoda, linux-renesas-soc, linux-arm-kernel On 11/06/2018 09:34 AM, Wolfram Sang wrote: > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > Shouldn't we have only one pinctrl config here, like you did recently > for the other Gen3 SoCs? We should, thanks for pointing it out, fixed in V2. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes 2018-11-05 21:41 ` Marek Vasut (?) @ 2018-11-06 5:26 ` Yoshihiro Shimoda -1 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:26 UTC (permalink / raw) To: Marek Vasut, devicetree Cc: TAKESHI KIHARA, Geert Uytterhoeven, Wolfram Sang, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 5:26 ` Yoshihiro Shimoda 0 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:26 UTC (permalink / raw) To: linux-arm-kernel Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* RE: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 5:26 ` Yoshihiro Shimoda 0 siblings, 0 replies; 33+ messages in thread From: Yoshihiro Shimoda @ 2018-11-06 5:26 UTC (permalink / raw) To: Marek Vasut, devicetree Cc: TAKESHI KIHARA, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, linux-renesas-soc, linux-arm-kernel Hello Marek-san, > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes 2018-11-06 5:26 ` Yoshihiro Shimoda (?) @ 2018-11-06 9:42 ` Marek Vasut -1 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:42 UTC (permalink / raw) To: Yoshihiro Shimoda, devicetree Cc: TAKESHI KIHARA, Geert Uytterhoeven, Wolfram Sang, linux-renesas-soc, Simon Horman, linux-arm-kernel, Marek Vasut On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is enabling SDHI on a particular board, which I think should be separate. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 9:42 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:42 UTC (permalink / raw) To: linux-arm-kernel On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is enabling SDHI on a particular board, which I think should be separate. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 9:42 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 9:42 UTC (permalink / raw) To: Yoshihiro Shimoda, devicetree Cc: TAKESHI KIHARA, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, linux-renesas-soc, linux-arm-kernel On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Simon Horman <horms+renesas@verge.net.au> >> Cc: Wolfram Sang <wsa@the-dreams.de> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is enabling SDHI on a particular board, which I think should be separate. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes 2018-11-06 9:42 ` Marek Vasut (?) @ 2018-11-06 10:35 ` Geert Uytterhoeven -1 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2018-11-06 10:35 UTC (permalink / raw) To: Marek Vasut Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Geert Uytterhoeven, Wolfram Sang, Yoshihiro Shimoda, Linux-Renesas, Simon Horman, Linux ARM, Marek Vasut Hi Marek, On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > >> > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > >> > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > >> Cc: Simon Horman <horms+renesas@verge.net.au> > >> Cc: Wolfram Sang <wsa@the-dreams.de> > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > >> Cc: linux-renesas-soc@vger.kernel.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> --- > > > > Thank you for the patch! > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > enabling SDHI on a particular board, which I think should be separate. The arm-soc maintainers tend to disagree, that's why Shimoda-san asked to combine them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 10:35 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2018-11-06 10:35 UTC (permalink / raw) To: linux-arm-kernel Hi Marek, On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > >> > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > >> > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > >> Cc: Simon Horman <horms+renesas@verge.net.au> > >> Cc: Wolfram Sang <wsa@the-dreams.de> > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > >> Cc: linux-renesas-soc at vger.kernel.org > >> Cc: linux-arm-kernel at lists.infradead.org > >> --- > > > > Thank you for the patch! > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > enabling SDHI on a particular board, which I think should be separate. The arm-soc maintainers tend to disagree, that's why Shimoda-san asked to combine them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 10:35 ` Geert Uytterhoeven 0 siblings, 0 replies; 33+ messages in thread From: Geert Uytterhoeven @ 2018-11-06 10:35 UTC (permalink / raw) To: Marek Vasut Cc: Yoshihiro Shimoda, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, Linux-Renesas, Linux ARM Hi Marek, On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > >> > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > >> > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > >> Cc: Simon Horman <horms+renesas@verge.net.au> > >> Cc: Wolfram Sang <wsa@the-dreams.de> > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > >> Cc: linux-renesas-soc@vger.kernel.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> --- > > > > Thank you for the patch! > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > enabling SDHI on a particular board, which I think should be separate. The arm-soc maintainers tend to disagree, that's why Shimoda-san asked to combine them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes 2018-11-06 10:35 ` Geert Uytterhoeven (?) @ 2018-11-06 12:17 ` Simon Horman -1 siblings, 0 replies; 33+ messages in thread From: Simon Horman @ 2018-11-06 12:17 UTC (permalink / raw) To: Geert Uytterhoeven Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Geert Uytterhoeven, Wolfram Sang, Yoshihiro Shimoda, Linux-Renesas, Marek Vasut, Linux ARM, Marek Vasut On Tue, Nov 06, 2018 at 11:35:13AM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > >> > > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> > > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > >> > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > >> Cc: Simon Horman <horms+renesas@verge.net.au> > > >> Cc: Wolfram Sang <wsa@the-dreams.de> > > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > >> Cc: linux-renesas-soc@vger.kernel.org > > >> Cc: linux-arm-kernel@lists.infradead.org > > >> --- > > > > > > Thank you for the patch! > > > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > > enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. That is also my understanding. Please consider combining these patches. ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 12:17 ` Simon Horman 0 siblings, 0 replies; 33+ messages in thread From: Simon Horman @ 2018-11-06 12:17 UTC (permalink / raw) To: linux-arm-kernel On Tue, Nov 06, 2018 at 11:35:13AM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > >> > > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> > > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > >> > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > >> Cc: Simon Horman <horms+renesas@verge.net.au> > > >> Cc: Wolfram Sang <wsa@the-dreams.de> > > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > >> Cc: linux-renesas-soc at vger.kernel.org > > >> Cc: linux-arm-kernel at lists.infradead.org > > >> --- > > > > > > Thank you for the patch! > > > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > > enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. That is also my understanding. Please consider combining these patches. ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 12:17 ` Simon Horman 0 siblings, 0 replies; 33+ messages in thread From: Simon Horman @ 2018-11-06 12:17 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Marek Vasut, Yoshihiro Shimoda, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Wolfram Sang, Linux-Renesas, Linux ARM On Tue, Nov 06, 2018 at 11:35:13AM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: > > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > >> > > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> > > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > >> > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > >> Cc: Simon Horman <horms+renesas@verge.net.au> > > >> Cc: Wolfram Sang <wsa@the-dreams.de> > > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > >> Cc: linux-renesas-soc@vger.kernel.org > > >> Cc: linux-arm-kernel@lists.infradead.org > > >> --- > > > > > > Thank you for the patch! > > > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > > enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. That is also my understanding. Please consider combining these patches. ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes 2018-11-06 10:35 ` Geert Uytterhoeven (?) @ 2018-11-06 20:47 ` Marek Vasut -1 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 20:47 UTC (permalink / raw) To: Geert Uytterhoeven Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Geert Uytterhoeven, Wolfram Sang, Yoshihiro Shimoda, Linux-Renesas, Simon Horman, Linux ARM, Marek Vasut On 11/06/2018 11:35 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: >>>> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >>>> >>>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> >>>> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >>>> >>>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >>>> Cc: Simon Horman <horms+renesas@verge.net.au> >>>> Cc: Wolfram Sang <wsa@the-dreams.de> >>>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>>> Cc: linux-renesas-soc@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> --- >>> >>> Thank you for the patch! >>> >>> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>> >>> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. >> >> I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is >> enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. Combined patch is out. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 20:47 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 20:47 UTC (permalink / raw) To: linux-arm-kernel On 11/06/2018 11:35 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: >>>> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >>>> >>>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> >>>> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >>>> >>>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >>>> Cc: Simon Horman <horms+renesas@verge.net.au> >>>> Cc: Wolfram Sang <wsa@the-dreams.de> >>>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>>> Cc: linux-renesas-soc at vger.kernel.org >>>> Cc: linux-arm-kernel at lists.infradead.org >>>> --- >>> >>> Thank you for the patch! >>> >>> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>> >>> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. >> >> I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is >> enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. Combined patch is out. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes @ 2018-11-06 20:47 ` Marek Vasut 0 siblings, 0 replies; 33+ messages in thread From: Marek Vasut @ 2018-11-06 20:47 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Yoshihiro Shimoda, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Takeshi Kihara, Marek Vasut, Geert Uytterhoeven, Simon Horman, Wolfram Sang, Linux-Renesas, Linux ARM On 11/06/2018 11:35 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: >>>> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >>>> >>>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> >>>> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >>>> >>>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >>>> Cc: Simon Horman <horms+renesas@verge.net.au> >>>> Cc: Wolfram Sang <wsa@the-dreams.de> >>>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>>> Cc: linux-renesas-soc@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> --- >>> >>> Thank you for the patch! >>> >>> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>> >>> I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. >> >> I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is >> enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. Combined patch is out. -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2018-11-07 8:20 UTC | newest] Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-11-05 21:41 [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes Marek Vasut 2018-11-05 21:41 ` Marek Vasut 2018-11-05 21:41 ` Marek Vasut 2018-11-05 21:41 ` [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces Marek Vasut 2018-11-05 21:41 ` Marek Vasut 2018-11-05 21:41 ` Marek Vasut 2018-11-06 5:29 ` Yoshihiro Shimoda 2018-11-06 5:29 ` Yoshihiro Shimoda 2018-11-06 5:29 ` Yoshihiro Shimoda 2018-11-06 9:17 ` Marek Vasut 2018-11-06 9:17 ` Marek Vasut 2018-11-06 9:17 ` Marek Vasut 2018-11-06 8:34 ` Wolfram Sang 2018-11-06 8:34 ` Wolfram Sang 2018-11-06 8:34 ` Wolfram Sang 2018-11-06 9:18 ` Marek Vasut 2018-11-06 9:18 ` Marek Vasut 2018-11-06 9:18 ` Marek Vasut 2018-11-06 5:26 ` [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes Yoshihiro Shimoda 2018-11-06 5:26 ` Yoshihiro Shimoda 2018-11-06 5:26 ` Yoshihiro Shimoda 2018-11-06 9:42 ` Marek Vasut 2018-11-06 9:42 ` Marek Vasut 2018-11-06 9:42 ` Marek Vasut 2018-11-06 10:35 ` Geert Uytterhoeven 2018-11-06 10:35 ` Geert Uytterhoeven 2018-11-06 10:35 ` Geert Uytterhoeven 2018-11-06 12:17 ` Simon Horman 2018-11-06 12:17 ` Simon Horman 2018-11-06 12:17 ` Simon Horman 2018-11-06 20:47 ` Marek Vasut 2018-11-06 20:47 ` Marek Vasut 2018-11-06 20:47 ` Marek Vasut
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.