All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] iommu/amd: remove set but not used variable 'tag'
Date: Thu, 8 Nov 2018 10:32:37 +0100	[thread overview]
Message-ID: <20181108093237.GE19831@8bytes.org> (raw)
In-Reply-To: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com>

On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote:
> -		tag = event[1] & 0x03FF;
>  		dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n",
>  			PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
>  			pasid, address, flags);

This looks like tag was just missed in the error message. It is better
to add it there instead of removing it.

Regards,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] iommu/amd: remove set but not used variable 'tag'
Date: Thu, 08 Nov 2018 09:32:37 +0000	[thread overview]
Message-ID: <20181108093237.GE19831@8bytes.org> (raw)
In-Reply-To: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com>

On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote:
> -		tag = event[1] & 0x03FF;
>  		dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n",
>  			PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
>  			pasid, address, flags);

This looks like tag was just missed in the error message. It is better
to add it there instead of removing it.

Regards,

	Joerg

  reply	other threads:[~2018-11-08  9:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  6:12 [PATCH -next] iommu/amd: remove set but not used variable 'tag' YueHaibing
2018-11-08  6:12 ` YueHaibing
2018-11-08  6:12 ` YueHaibing
2018-11-08  9:32 ` Joerg Roedel [this message]
2018-11-08  9:32   ` Joerg Roedel
2018-11-08 11:12   ` YueHaibing
2018-11-08 11:12     ` YueHaibing
2018-11-08 11:12     ` YueHaibing
2018-11-08 11:57 ` [PATCH -next] iommu/amd: Add missed 'tag' to error msg in iommu_print_event YueHaibing
2018-11-08 11:57   ` YueHaibing
2018-11-08 11:57   ` YueHaibing
2018-11-08 14:04   ` Joerg Roedel
2018-11-08 14:04     ` Joerg Roedel
2020-05-08 13:40 [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' YueHaibing
2020-05-08 13:40 ` YueHaibing
2020-05-08 13:40 ` YueHaibing
2020-05-13  8:57 ` Joerg Roedel
2020-05-13  8:57   ` Joerg Roedel
2020-05-13  8:57   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108093237.GE19831@8bytes.org \
    --to=joro@8bytes.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.