[Buildroot] [PATCH 1/2] go: specify GOARM when compiling target binaries

[Buildroot] [PATCH 1/2] go: specify GOARM when compiling target binaries

[Christian Stewart]

Currently, GOARM is not specified correctly when compiling target binaries. This
results in incompatibility / illegal instruction issues on some ARM devices.

Signed-off-by: Christian Stewart <christian@paral.in>
---
 package/go/go.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/go/go.mk b/package/go/go.mk
index ec74ba397c..8423dc7eea 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -43,6 +43,7 @@ HOST_GO_ROOT = $(HOST_DIR)/lib/go
 HOST_GO_TOOLDIR = $(HOST_GO_ROOT)/pkg/tool/linux_$(GO_GOARCH)
 HOST_GO_TARGET_ENV = \
 	GOARCH=$(GO_GOARCH) \
+	$(if $(GO_GOARM),GOARM=$(GO_GOARM)) \
 	GOROOT="$(HOST_GO_ROOT)" \
 	CC="$(TARGET_CC)" \
 	CXX="$(TARGET_CXX)" \
-- 
2.18.1

[Buildroot] [PATCH 2/2] DEVELOPERS: add Christian Stewart for go

[Christian Stewart]

I am now maintaining / submitting regular patches for the Go toolchain as well.

Signed-off-by: Christian Stewart <christian@paral.in>
---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index 8d5ed199ce..b95f6c583c 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -468,6 +468,7 @@ F:	package/batman-adv/
 F:	package/docker-containerd/
 F:	package/docker-engine/
 F:	package/docker-proxy/
+F:	package/go/
 F:	package/mosh/
 F:	package/rtl8821au/
 F:	package/runc/
-- 
2.18.1

[Buildroot] [PATCH 1/2] go: specify GOARM when compiling target binaries

[Christian Stewart]

All,

On Wed, Nov 7, 2018 at 12:13 PM Christian Stewart <christian@paral.in> wrote:
> Currently, GOARM is not specified correctly when compiling target binaries. This
> results in incompatibility / illegal instruction issues on some ARM devices.

Withdrawing this patch, while investigating a SIGILL with Cgo,
possibly related to using thumb2 instructions on arm (when Go only
supports standard arm instructions).

See https://github.com/golang/go/issues/28642

Thanks,
Christian Stewart

[Buildroot] [PATCH 2/2] DEVELOPERS: add Christian Stewart for go

[Anisse Astier]

Hi Christian,

On Wed, Nov 07, 2018 at 12:12:59PM -0800, Christian Stewart wrote:
> I am now maintaining / submitting regular patches for the Go toolchain as well.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  DEVELOPERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 8d5ed199ce..b95f6c583c 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -468,6 +468,7 @@ F:	package/batman-adv/
>  F:	package/docker-containerd/
>  F:	package/docker-engine/
>  F:	package/docker-proxy/
> +F:	package/go/
>  F:	package/mosh/
>  F:	package/rtl8821au/
>  F:	package/runc/
> -- 
> 2.18.1
> 

While the previous patch has been withdrawn, you still want this patch
applied, correct ?

Regards,

Anisse

[Buildroot] [PATCH 2/2] DEVELOPERS: add Christian Stewart for go

[Thomas Petazzoni]

Hello,

On Wed,  7 Nov 2018 12:12:59 -0800, Christian Stewart wrote:
> I am now maintaining / submitting regular patches for the Go toolchain as well.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  DEVELOPERS | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com