All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 14:38 Nicola Lunghi
  0 siblings, 0 replies; 7+ messages in thread
From: Nicola Lunghi @ 2018-11-23 14:38 UTC (permalink / raw)
  To: openembedded-devel

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 classes/java-library.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
 FILES_${JPN} = "${datadir_java}"
 
 # File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
 
 # Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
 
 # Java "source" distributions often contain precompiled things
 # we want to delete first.
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [meta-java][PATCH] java-library: make easy to override jar package name
  2018-11-23 15:09 nick83ola
@ 2018-12-17 14:53 ` Richard Leitner
  0 siblings, 0 replies; 7+ messages in thread
From: Richard Leitner @ 2018-12-17 14:53 UTC (permalink / raw)
  To: openembedded-devel

Hi,
thanks for the patch.

Two things:

First can you please use your real name in the From: (or prepend the From: line to the email body).

Second: would you please describe the reasons for changing = to ?= in more detail?
What's the purpose/benefit you get from it?

thanks & regards;Richard.L

On 23.11.18 16:09, nick83ola wrote:
> define JARFILENAME and ALTJARFILENAMES with ?= to make simple
> to override them
> 
> Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
> ---
> classes/java-library.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
> index ce1cd28..c69cf6b 100644
> --- a/classes/java-library.bbclass
> +++ b/classes/java-library.bbclass
> @@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
> FILES_${JPN} = "${datadir_java}"
> # File name of the libraries' main Jar file
> -JARFILENAME = "${BP}.jar"
> +JARFILENAME ?= "${BP}.jar"
> # Space-separated list of alternative file names.
> -ALTJARFILENAMES = "${BPN}.jar"
> +ALTJARFILENAMES ?= "${BPN}.jar"
> # Java "source" distributions often contain precompiled things
> # we want to delete first.
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 15:09 nick83ola
  2018-12-17 14:53 ` Richard Leitner
  0 siblings, 1 reply; 7+ messages in thread
From: nick83ola @ 2018-11-23 15:09 UTC (permalink / raw)
  To: openembeded-devel

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
classes/java-library.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
FILES_${JPN} = "${datadir_java}"
# File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
# Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
# Java "source" distributions often contain precompiled things
# we want to delete first.
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 14:57 Nicola Lunghi
  0 siblings, 0 replies; 7+ messages in thread
From: Nicola Lunghi @ 2018-11-23 14:57 UTC (permalink / raw)
  To: openembedded-devel

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 classes/java-library.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
 FILES_${JPN} = "${datadir_java}"
 
 # File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
 
 # Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
 
 # Java "source" distributions often contain precompiled things
 # we want to delete first.
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 14:53 Nicola Lunghi
  0 siblings, 0 replies; 7+ messages in thread
From: Nicola Lunghi @ 2018-11-23 14:53 UTC (permalink / raw)
  To: openembedded-devel

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 classes/java-library.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
 FILES_${JPN} = "${datadir_java}"
 
 # File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
 
 # Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
 
 # Java "source" distributions often contain precompiled things
 # we want to delete first.
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 14:37 Nicola Lunghi
  0 siblings, 0 replies; 7+ messages in thread
From: Nicola Lunghi @ 2018-11-23 14:37 UTC (permalink / raw)
  To: openembedded-core

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 classes/java-library.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
 FILES_${JPN} = "${datadir_java}"
 
 # File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
 
 # Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
 
 # Java "source" distributions often contain precompiled things
 # we want to delete first.
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [meta-java][PATCH] java-library: make easy to override jar package name
@ 2018-11-23 14:31 Nicola Lunghi
  0 siblings, 0 replies; 7+ messages in thread
From: Nicola Lunghi @ 2018-11-23 14:31 UTC (permalink / raw)
  To: openembedded-core

define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 classes/java-library.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
 FILES_${JPN} = "${datadir_java}"
 
 # File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
 
 # Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
 
 # Java "source" distributions often contain precompiled things
 # we want to delete first.
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-17 14:53 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23 14:38 [meta-java][PATCH] java-library: make easy to override jar package name Nicola Lunghi
  -- strict thread matches above, loose matches on Subject: below --
2018-11-23 15:09 nick83ola
2018-12-17 14:53 ` Richard Leitner
2018-11-23 14:57 Nicola Lunghi
2018-11-23 14:53 Nicola Lunghi
2018-11-23 14:37 Nicola Lunghi
2018-11-23 14:31 Nicola Lunghi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.