From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mark Rutland <mark.rutland@arm.com>, Jens Axboe <axboe@kernel.dk>,
Hans de Goede <hdegoede@redhat.com>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-pm@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
linux-ide@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 1/7] ata: libahci_platform: comply to PHY framework
Date: Fri, 23 Nov 2018 15:27:30 +0000 [thread overview]
Message-ID: <20181123152730.GU30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181123151806.GC30913@lunn.ch>
On Fri, Nov 23, 2018 at 04:18:06PM +0100, Andrew Lunn wrote:
> Russell King wrote a comphy driver for the Armada 3XX family. It only
> supports network PHYs. Did you check it does the right thing when
> passed PHY_MODE_SATA? This is slightly different to Hans's comment, in
> that i expect phy_set_mode() is implemented for the comphy driver, but
> it might not understand PHY_MODE_SATA and return an error?
It makes no difference until the comphy is wired up to the SATA
device in the appropriate DT files. Until then, there's no way
that the comphy will ever see PHY_MODE_SATA.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ata: libahci_platform: comply to PHY framework
Date: Fri, 23 Nov 2018 15:27:30 +0000 [thread overview]
Message-ID: <20181123152730.GU30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181123151806.GC30913@lunn.ch>
On Fri, Nov 23, 2018 at 04:18:06PM +0100, Andrew Lunn wrote:
> Russell King wrote a comphy driver for the Armada 3XX family. It only
> supports network PHYs. Did you check it does the right thing when
> passed PHY_MODE_SATA? This is slightly different to Hans's comment, in
> that i expect phy_set_mode() is implemented for the comphy driver, but
> it might not understand PHY_MODE_SATA and return an error?
It makes no difference until the comphy is wired up to the SATA
device in the appropriate DT files. Until then, there's no way
that the comphy will ever see PHY_MODE_SATA.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2018-11-23 15:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 10:15 [PATCH 0/7] Bring suspend to RAM support to MVEBU SATA Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 1/7] ata: libahci_platform: comply to PHY framework Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:33 ` Hans de Goede
2018-11-23 10:33 ` Hans de Goede
2018-11-30 15:40 ` Miquel Raynal
2018-11-23 15:18 ` Andrew Lunn
2018-11-23 15:18 ` Andrew Lunn
2018-11-23 15:27 ` Russell King - ARM Linux [this message]
2018-11-23 15:27 ` Russell King - ARM Linux
2018-11-23 15:36 ` Andrew Lunn
2018-11-23 15:36 ` Andrew Lunn
2018-11-23 10:15 ` [PATCH 2/7] ata: ahci: mvebu: remove stale comment Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 3/7] ata: ahci: mvebu: do Armada 38x configuration only on relevant SoCs Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 4/7] ata: ahci: mvebu: add Armada 3700 initialization needed for S2RAM Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 5/7] ata: ahci: mvebu: add clock support Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-29 14:02 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 6/7] ARM64: dts: marvell: armada-37xx: declare SATA clock Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
2018-11-23 10:15 ` [PATCH 7/7] ARM64: dts: marvell: armada-3720-espressobin: declare SATA PHY property Miquel Raynal
2018-11-23 10:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123152730.GU30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.