From: Daniel Thompson <daniel.thompson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathan@marek.ca, ctatlor97@gmail.com
Subject: Re: [PATCH 2/2] backlight: lm3630a: add backlight driver match_table
Date: Tue, 27 Nov 2018 10:57:33 +0000 [thread overview]
Message-ID: <20181127105733.5t275fixa3utnkaz@holly.lan> (raw)
In-Reply-To: <20181124141703.29232-2-masneyb@onstation.org>
On Sat, Nov 24, 2018 at 09:17:03AM -0500, Brian Masney wrote:
> From: Jonathan Marek <jonathan@marek.ca>
>
> Add device tree support to the lm3630a driver.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> [masneyb@onstation.org: checkpatch fixes; add 'a' to compatible string]
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> This is part of upstreaming various components of the LG Nexus 5
> (hammerhead) phone.
>
> drivers/video/backlight/lm3630a_bl.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index 2030a6b77a09..159d4013d9c2 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -470,11 +470,18 @@ static const struct i2c_device_id lm3630a_id[] = {
> {}
> };
Similar to my reply to the DT bindings: I would have expected there
to be code to handle DT properties here.
Daniel.
>
> +static const struct of_device_id lm3630a_match_table[] = {
> + { .compatible = "ti,lm3630a", },
> + { },
> +};
> +
> +
> MODULE_DEVICE_TABLE(i2c, lm3630a_id);
>
> static struct i2c_driver lm3630a_i2c_driver = {
> .driver = {
> .name = LM3630A_NAME,
> + .of_match_table = lm3630a_match_table,
> },
> .probe = lm3630a_probe,
> .remove = lm3630a_remove,
> --
> 2.17.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, ctatlor97@gmail.com,
jonathan@marek.ca, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH 2/2] backlight: lm3630a: add backlight driver match_table
Date: Tue, 27 Nov 2018 10:57:33 +0000 [thread overview]
Message-ID: <20181127105733.5t275fixa3utnkaz@holly.lan> (raw)
In-Reply-To: <20181124141703.29232-2-masneyb@onstation.org>
On Sat, Nov 24, 2018 at 09:17:03AM -0500, Brian Masney wrote:
> From: Jonathan Marek <jonathan@marek.ca>
>
> Add device tree support to the lm3630a driver.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> [masneyb@onstation.org: checkpatch fixes; add 'a' to compatible string]
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> This is part of upstreaming various components of the LG Nexus 5
> (hammerhead) phone.
>
> drivers/video/backlight/lm3630a_bl.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index 2030a6b77a09..159d4013d9c2 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -470,11 +470,18 @@ static const struct i2c_device_id lm3630a_id[] = {
> {}
> };
Similar to my reply to the DT bindings: I would have expected there
to be code to handle DT properties here.
Daniel.
>
> +static const struct of_device_id lm3630a_match_table[] = {
> + { .compatible = "ti,lm3630a", },
> + { },
> +};
> +
> +
> MODULE_DEVICE_TABLE(i2c, lm3630a_id);
>
> static struct i2c_driver lm3630a_i2c_driver = {
> .driver = {
> .name = LM3630A_NAME,
> + .of_match_table = lm3630a_match_table,
> },
> .probe = lm3630a_probe,
> .remove = lm3630a_remove,
> --
> 2.17.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, ctatlor97@gmail.com,
jonathan@marek.ca, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH 2/2] backlight: lm3630a: add backlight driver match_table
Date: Tue, 27 Nov 2018 10:57:33 +0000 [thread overview]
Message-ID: <20181127105733.5t275fixa3utnkaz@holly.lan> (raw)
In-Reply-To: <20181124141703.29232-2-masneyb@onstation.org>
On Sat, Nov 24, 2018 at 09:17:03AM -0500, Brian Masney wrote:
> From: Jonathan Marek <jonathan@marek.ca>
>
> Add device tree support to the lm3630a driver.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> [masneyb@onstation.org: checkpatch fixes; add 'a' to compatible string]
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> This is part of upstreaming various components of the LG Nexus 5
> (hammerhead) phone.
>
> drivers/video/backlight/lm3630a_bl.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index 2030a6b77a09..159d4013d9c2 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -470,11 +470,18 @@ static const struct i2c_device_id lm3630a_id[] = {
> {}
> };
Similar to my reply to the DT bindings: I would have expected there
to be code to handle DT properties here.
Daniel.
>
> +static const struct of_device_id lm3630a_match_table[] = {
> + { .compatible = "ti,lm3630a", },
> + { },
> +};
> +
> +
> MODULE_DEVICE_TABLE(i2c, lm3630a_id);
>
> static struct i2c_driver lm3630a_i2c_driver = {
> .driver = {
> .name = LM3630A_NAME,
> + .of_match_table = lm3630a_match_table,
> },
> .probe = lm3630a_probe,
> .remove = lm3630a_remove,
> --
> 2.17.2
>
next prev parent reply other threads:[~2018-11-27 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 14:17 [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding Brian Masney
2018-11-24 14:17 ` Brian Masney
2018-11-24 14:17 ` [PATCH 2/2] backlight: lm3630a: add backlight driver match_table Brian Masney
2018-11-24 14:17 ` Brian Masney
2018-11-27 10:57 ` Daniel Thompson [this message]
2018-11-27 10:57 ` Daniel Thompson
2018-11-27 10:57 ` Daniel Thompson
2018-11-27 10:56 ` [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding Daniel Thompson
2018-11-30 13:59 ` Brian Masney
2018-11-30 13:59 ` Brian Masney
2018-11-30 14:13 ` Rob Herring
2018-11-30 14:13 ` Rob Herring
2018-11-30 14:13 ` Rob Herring
2018-11-30 14:25 ` Brian Masney
2018-11-30 14:25 ` Brian Masney
2018-11-30 15:37 ` Dan Murphy
2018-11-30 15:37 ` Dan Murphy
2018-11-30 15:37 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127105733.5t275fixa3utnkaz@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=jonathan@marek.ca \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.