All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <masneyb@onstation.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com, robh+dt@kernel.org,
	mark.rutland@arm.com, b.zolnierkie@samsung.com,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	jonathan@marek.ca, ctatlor97@gmail.com
Subject: Re: [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding
Date: Fri, 30 Nov 2018 08:59:27 -0500	[thread overview]
Message-ID: <20181130135927.GA27500@basecamp> (raw)
In-Reply-To: <20181127105642.uu56phxjfl7bjl2p@holly.lan>

On Tue, Nov 27, 2018 at 10:56:42AM +0000, Daniel Thompson wrote:
> On Sat, Nov 24, 2018 at 09:17:02AM -0500, Brian Masney wrote:
> > Add a trivial binding for the Texas Instruments LM3630A Backlight Chip.
> 
> It's quite unusual for a backlight device to have a trivial binding.
> 
> The driver supports fairly extensive parametrization via struct
> lm3530a_platform_data. It is really the case that none of these
> properties should ever be set via DT?

Hi Daniel,

I initially assumed that we would let user space configure these values
once the system has booted, but you are right that these should be
available in device tree.
 
The driver has two different LED banks that can be configured
independently. How do you feel about having a single property in
device tree populate the initial values for both banks? I propose that
we could use the property default-brightness-level for leda_init_brt
and ledb_init_brt in struct lm3630a_platform_data. The max-brightness
property can populate leda_max_brt and ledb_max_brt.

I need to look at other bindings this weekend to see if there are any
standard properties that I can use for leda_ctrl/ledb_ctrl, pwm_ctrl,
and pwm_period.

Brian


> 
> > 
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
> > index 6ab001fa1ed4..86486368dc35 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/trivial-devices.txt
> > @@ -182,6 +182,7 @@ taos,tsl2550		Ambient Light Sensor with SMBUS/Two Wire Serial Interface
> >  ti,ads7828		8-Channels, 12-bit ADC
> >  ti,ads7830		8-Channels, 8-bit ADC
> >  ti,amc6821		Temperature Monitoring and Fan Control
> > +ti,lm3630a		Texas Instruments LM3630A Backlight Chip
> >  ti,tsc2003		I2C Touch-Screen Controller
> >  ti,tmp102		Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> >  ti,tmp103		Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> > -- 
> > 2.17.2
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Brian Masney <masneyb@onstation.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com, robh+dt@kernel.org,
	mark.rutland@arm.com, b.zolnierkie@samsung.com,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	jonathan@marek.ca, ctatlor97@gmail.com
Subject: Re: [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding
Date: Fri, 30 Nov 2018 13:59:27 +0000	[thread overview]
Message-ID: <20181130135927.GA27500@basecamp> (raw)
In-Reply-To: <20181127105642.uu56phxjfl7bjl2p@holly.lan>

On Tue, Nov 27, 2018 at 10:56:42AM +0000, Daniel Thompson wrote:
> On Sat, Nov 24, 2018 at 09:17:02AM -0500, Brian Masney wrote:
> > Add a trivial binding for the Texas Instruments LM3630A Backlight Chip.
> 
> It's quite unusual for a backlight device to have a trivial binding.
> 
> The driver supports fairly extensive parametrization via struct
> lm3530a_platform_data. It is really the case that none of these
> properties should ever be set via DT?

Hi Daniel,

I initially assumed that we would let user space configure these values
once the system has booted, but you are right that these should be
available in device tree.
 
The driver has two different LED banks that can be configured
independently. How do you feel about having a single property in
device tree populate the initial values for both banks? I propose that
we could use the property default-brightness-level for leda_init_brt
and ledb_init_brt in struct lm3630a_platform_data. The max-brightness
property can populate leda_max_brt and ledb_max_brt.

I need to look at other bindings this weekend to see if there are any
standard properties that I can use for leda_ctrl/ledb_ctrl, pwm_ctrl,
and pwm_period.

Brian


> 
> > 
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
> > index 6ab001fa1ed4..86486368dc35 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/trivial-devices.txt
> > @@ -182,6 +182,7 @@ taos,tsl2550		Ambient Light Sensor with SMBUS/Two Wire Serial Interface
> >  ti,ads7828		8-Channels, 12-bit ADC
> >  ti,ads7830		8-Channels, 8-bit ADC
> >  ti,amc6821		Temperature Monitoring and Fan Control
> > +ti,lm3630a		Texas Instruments LM3630A Backlight Chip
> >  ti,tsc2003		I2C Touch-Screen Controller
> >  ti,tmp102		Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> >  ti,tmp103		Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> > -- 
> > 2.17.2
> > 

  reply	other threads:[~2018-11-30 13:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 14:17 [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding Brian Masney
2018-11-24 14:17 ` Brian Masney
2018-11-24 14:17 ` [PATCH 2/2] backlight: lm3630a: add backlight driver match_table Brian Masney
2018-11-24 14:17   ` Brian Masney
2018-11-27 10:57   ` Daniel Thompson
2018-11-27 10:57     ` Daniel Thompson
2018-11-27 10:57     ` Daniel Thompson
2018-11-27 10:56 ` [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding Daniel Thompson
2018-11-30 13:59   ` Brian Masney [this message]
2018-11-30 13:59     ` Brian Masney
2018-11-30 14:13     ` Rob Herring
2018-11-30 14:13       ` Rob Herring
2018-11-30 14:13       ` Rob Herring
2018-11-30 14:25       ` Brian Masney
2018-11-30 14:25         ` Brian Masney
2018-11-30 15:37       ` Dan Murphy
2018-11-30 15:37         ` Dan Murphy
2018-11-30 15:37         ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130135927.GA27500@basecamp \
    --to=masneyb@onstation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=ctatlor97@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=jonathan@marek.ca \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.