From: Tony Lindgren <tony@atomide.com> To: Peter Ujfalusi <peter.ujfalusi@ti.com> Cc: devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>, Keerthy <j-keerthy@ti.com>, "Tero Kristo" <t-kristo@ti.com>, "Benoît Cousson" <bcousson@baylibre.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc Date: Tue, 27 Nov 2018 08:16:25 -0800 [thread overview] Message-ID: <20181127161625.GR53235@atomide.com> (raw) In-Reply-To: <612b09a4-5007-39bf-becb-66fdca9d6d41@ti.com> * Peter Ujfalusi <peter.ujfalusi@ti.com> [181127 13:01]: > Reverting this patch in linux-next makes audio working again on am335x > (bb white + audio cape) :o > > Without revert the McASP FIFO would constantly underflow. Thanks for testing. Hmm the dts change looks right. And am3_l3s_clkctrl_regs[] has CLKF_SW_SUP for the mcasp fcks. And there are no opt clocks to enable according to the TRM. > Memcpy test via dmatest works with EDMA OK. Can you please test if the following partial revert also works or is there maybe a dependency to some other device? Regards, Tony 8< ------------------ >From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren <tony@atomide.com> Date: Tue, 27 Nov 2018 08:11:48 -0800 Subject: [PATCH] ARM: dts: Revert am335x mcasp ti-sysc changes Without this McASP FIFO would constantly underflow. EDMA test via dmatest works though. Let's revert the change for now until we know the root cause. Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/am33xx-l4.dtsi | 28 ++-------------------------- arch/arm/boot/dts/am33xx.dtsi | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 26 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi --- a/arch/arm/boot/dts/am33xx-l4.dtsi +++ b/arch/arm/boot/dts/am33xx-l4.dtsi @@ -1056,19 +1056,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x38000 0x2000>; - - mcasp0: mcasp@0 { - compatible = "ti,am33xx-mcasp-audio"; - reg = <0x0 0x2000>, - <0x46000000 0x400000>; - reg-names = "mpu", "dat"; - interrupts = <80>, <81>; - interrupt-names = "tx", "rx"; - status = "disabled"; - dmas = <&edma 8 2>, - <&edma 9 2>; - dma-names = "tx", "rx"; - }; + status = "disabled"; }; target-module@3c000 { /* 0x4803c000, ap 20 32.0 */ @@ -1086,19 +1074,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x3c000 0x2000>; - - mcasp1: mcasp@0 { - compatible = "ti,am33xx-mcasp-audio"; - reg = <0x0 0x2000>, - <0x46400000 0x400000>; - reg-names = "mpu", "dat"; - interrupts = <82>, <83>; - interrupt-names = "tx", "rx"; - status = "disabled"; - dmas = <&edma 10 2>, - <&edma 11 2>; - dma-names = "tx", "rx"; - }; + status = "disabled"; }; target-module@40000 { /* 0x48040000, ap 22 1e.0 */ diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -440,7 +440,36 @@ <&edma 5 0>; dma-names = "tx", "rx"; }; + + mcasp0: mcasp@48038000 { + compatible = "ti,am33xx-mcasp-audio"; + ti,hwmods = "mcasp0"; + reg = <0x48038000 0x2000>, + <0x46000000 0x400000>; + reg-names = "mpu", "dat"; + interrupts = <80>, <81>; + interrupt-names = "tx", "rx"; + status = "disabled"; + dmas = <&edma 8 2>, + <&edma 9 2>; + dma-names = "tx", "rx"; + }; + + mcasp1: mcasp@4803c000 { + compatible = "ti,am33xx-mcasp-audio"; + ti,hwmods = "mcasp1"; + reg = <0x4803C000 0x2000>, + <0x46400000 0x400000>; + reg-names = "mpu", "dat"; + interrupts = <82>, <83>; + interrupt-names = "tx", "rx"; + status = "disabled"; + dmas = <&edma 10 2>, + <&edma 11 2>; + dma-names = "tx", "rx"; + }; }; + }; #include "am33xx-l4.dtsi" -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc Date: Tue, 27 Nov 2018 08:16:25 -0800 [thread overview] Message-ID: <20181127161625.GR53235@atomide.com> (raw) In-Reply-To: <612b09a4-5007-39bf-becb-66fdca9d6d41@ti.com> * Peter Ujfalusi <peter.ujfalusi@ti.com> [181127 13:01]: > Reverting this patch in linux-next makes audio working again on am335x > (bb white + audio cape) :o > > Without revert the McASP FIFO would constantly underflow. Thanks for testing. Hmm the dts change looks right. And am3_l3s_clkctrl_regs[] has CLKF_SW_SUP for the mcasp fcks. And there are no opt clocks to enable according to the TRM. > Memcpy test via dmatest works with EDMA OK. Can you please test if the following partial revert also works or is there maybe a dependency to some other device? Regards, Tony 8< ------------------ >From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren <tony@atomide.com> Date: Tue, 27 Nov 2018 08:11:48 -0800 Subject: [PATCH] ARM: dts: Revert am335x mcasp ti-sysc changes Without this McASP FIFO would constantly underflow. EDMA test via dmatest works though. Let's revert the change for now until we know the root cause. Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/am33xx-l4.dtsi | 28 ++-------------------------- arch/arm/boot/dts/am33xx.dtsi | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 26 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi --- a/arch/arm/boot/dts/am33xx-l4.dtsi +++ b/arch/arm/boot/dts/am33xx-l4.dtsi @@ -1056,19 +1056,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x38000 0x2000>; - - mcasp0: mcasp at 0 { - compatible = "ti,am33xx-mcasp-audio"; - reg = <0x0 0x2000>, - <0x46000000 0x400000>; - reg-names = "mpu", "dat"; - interrupts = <80>, <81>; - interrupt-names = "tx", "rx"; - status = "disabled"; - dmas = <&edma 8 2>, - <&edma 9 2>; - dma-names = "tx", "rx"; - }; + status = "disabled"; }; target-module at 3c000 { /* 0x4803c000, ap 20 32.0 */ @@ -1086,19 +1074,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x3c000 0x2000>; - - mcasp1: mcasp at 0 { - compatible = "ti,am33xx-mcasp-audio"; - reg = <0x0 0x2000>, - <0x46400000 0x400000>; - reg-names = "mpu", "dat"; - interrupts = <82>, <83>; - interrupt-names = "tx", "rx"; - status = "disabled"; - dmas = <&edma 10 2>, - <&edma 11 2>; - dma-names = "tx", "rx"; - }; + status = "disabled"; }; target-module at 40000 { /* 0x48040000, ap 22 1e.0 */ diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -440,7 +440,36 @@ <&edma 5 0>; dma-names = "tx", "rx"; }; + + mcasp0: mcasp at 48038000 { + compatible = "ti,am33xx-mcasp-audio"; + ti,hwmods = "mcasp0"; + reg = <0x48038000 0x2000>, + <0x46000000 0x400000>; + reg-names = "mpu", "dat"; + interrupts = <80>, <81>; + interrupt-names = "tx", "rx"; + status = "disabled"; + dmas = <&edma 8 2>, + <&edma 9 2>; + dma-names = "tx", "rx"; + }; + + mcasp1: mcasp at 4803c000 { + compatible = "ti,am33xx-mcasp-audio"; + ti,hwmods = "mcasp1"; + reg = <0x4803C000 0x2000>, + <0x46400000 0x400000>; + reg-names = "mpu", "dat"; + interrupts = <82>, <83>; + interrupt-names = "tx", "rx"; + status = "disabled"; + dmas = <&edma 10 2>, + <&edma 11 2>; + dma-names = "tx", "rx"; + }; }; + }; #include "am33xx-l4.dtsi" -- 2.19.1
next prev parent reply other threads:[~2018-11-27 16:16 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-25 0:05 [PATCH 0/4] Update am437x and am335x dts to probe with ti-sysc Tony Lindgren 2018-09-25 0:05 ` Tony Lindgren 2018-09-25 0:05 ` [PATCH 1/4] ARM: dts: am437x: Add l4 interconnect hierarchy and ti-sysc data Tony Lindgren 2018-09-25 0:05 ` Tony Lindgren 2018-09-25 0:05 ` [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc Tony Lindgren 2018-09-25 0:05 ` Tony Lindgren 2018-12-04 12:23 ` Peter Ujfalusi 2018-12-04 12:23 ` Peter Ujfalusi 2018-12-04 18:11 ` Tony Lindgren 2018-12-04 18:11 ` Tony Lindgren 2018-12-04 23:18 ` Tony Lindgren 2018-12-04 23:18 ` Tony Lindgren 2018-12-05 6:14 ` Peter Ujfalusi 2018-12-05 19:00 ` Tony Lindgren 2018-12-05 19:00 ` Tony Lindgren 2018-12-05 23:02 ` Tony Lindgren 2018-12-05 23:02 ` Tony Lindgren 2018-12-07 12:46 ` Peter Ujfalusi 2018-09-25 0:05 ` [PATCH 3/4] ARM: dts: am335x: Add l4 interconnect hierarchy and ti-sysc data Tony Lindgren 2018-09-25 0:05 ` Tony Lindgren 2018-09-27 14:56 ` Tony Lindgren 2018-09-27 14:56 ` Tony Lindgren 2018-09-25 0:05 ` [PATCH 4/4] ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc Tony Lindgren 2018-09-25 0:05 ` Tony Lindgren 2018-11-27 13:03 ` Peter Ujfalusi 2018-11-27 13:03 ` Peter Ujfalusi 2018-11-27 16:16 ` Tony Lindgren [this message] 2018-11-27 16:16 ` Tony Lindgren 2018-11-28 12:52 ` Peter Ujfalusi 2018-11-28 12:52 ` Peter Ujfalusi 2018-11-29 19:07 ` Tony Lindgren 2018-11-29 19:07 ` Tony Lindgren 2018-09-25 5:14 ` [PATCH 0/4] Update am437x and am335x dts to probe " Keerthy 2018-09-25 5:14 ` Keerthy 2018-09-25 14:40 ` Tony Lindgren 2018-09-25 14:40 ` Tony Lindgren 2018-09-25 17:55 ` Tony Lindgren 2018-09-25 17:55 ` Tony Lindgren 2018-09-25 21:16 ` Grygorii Strashko 2018-09-25 21:16 ` Grygorii Strashko 2018-09-26 4:08 ` Keerthy 2018-09-26 4:08 ` Keerthy 2018-09-26 15:59 ` Tony Lindgren 2018-09-26 15:59 ` Tony Lindgren 2018-09-26 16:23 ` Tony Lindgren 2018-09-26 16:23 ` Tony Lindgren 2018-09-26 21:36 ` Grygorii Strashko 2018-09-26 21:36 ` Grygorii Strashko 2018-09-26 23:31 ` Tony Lindgren 2018-09-26 23:31 ` Tony Lindgren 2018-09-27 4:55 ` Keerthy 2018-09-27 4:55 ` Keerthy 2018-09-27 14:53 ` Tony Lindgren 2018-09-27 14:53 ` Tony Lindgren 2018-09-27 21:43 ` Tony Lindgren 2018-09-27 21:43 ` Tony Lindgren 2018-10-01 16:32 ` Tony Lindgren 2018-10-01 16:32 ` Tony Lindgren 2018-10-04 4:29 ` Keerthy 2018-10-04 4:29 ` Keerthy 2018-10-04 14:23 ` Tony Lindgren 2018-10-04 14:23 ` Tony Lindgren 2018-09-27 19:11 ` Grygorii Strashko 2018-09-27 19:11 ` Grygorii Strashko 2018-09-27 19:38 ` Tony Lindgren 2018-09-27 19:38 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181127161625.GR53235@atomide.com \ --to=tony@atomide.com \ --cc=bcousson@baylibre.com \ --cc=d-gerlach@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=j-keerthy@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=peter.ujfalusi@ti.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.