All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-next: Signed-off-by missing for commit in the sound-asoc tree
@ 2018-12-06 21:01 Stephen Rothwell
  2018-12-06 22:24 ` [PATCH v2] ASoC: max9867: Remove useless assignment Ladislav Michl
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2018-12-06 21:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ladislav Michl

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  972fd1f58267 ("ASoC: max9867: Remove useless assignment")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2] ASoC: max9867: Remove useless assignment
  2018-12-06 21:01 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
@ 2018-12-06 22:24 ` Ladislav Michl
  0 siblings, 0 replies; 2+ messages in thread
From: Ladislav Michl @ 2018-12-06 22:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Kuninori Morimoto, anish kumar,
	alsa-devel

ret is assigned later, no need to initialize it.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 CHANGES:
 -v2: add missing Signed-off-by
 (I'm sorry for that...)

 sound/soc/codecs/max9867.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 1cda54b59854..1b155f40b106 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -476,7 +476,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 		const struct i2c_device_id *id)
 {
 	struct max9867_priv *max9867;
-	int ret = 0, reg;
+	int ret, reg;
 
 	max9867 = devm_kzalloc(&i2c->dev, sizeof(*max9867), GFP_KERNEL);
 	if (!max9867)
@@ -497,10 +497,8 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 	dev_info(&i2c->dev, "device revision: %x\n", reg);
 	ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
 			max9867_dai, ARRAY_SIZE(max9867_dai));
-	if (ret < 0) {
+	if (ret < 0)
 		dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
-		return ret;
-	}
 	return ret;
 }
 
-- 
2.20.0.rc2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-06 22:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 21:01 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
2018-12-06 22:24 ` [PATCH v2] ASoC: max9867: Remove useless assignment Ladislav Michl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.