* linux-next: Signed-off-by missing for commit in the sound-asoc tree
@ 2018-12-06 21:01 Stephen Rothwell
2018-12-06 22:24 ` [PATCH v2] ASoC: max9867: Remove useless assignment Ladislav Michl
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2018-12-06 21:01 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ladislav Michl
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
Hi all,
Commit
972fd1f58267 ("ASoC: max9867: Remove useless assignment")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ASoC: max9867: Remove useless assignment
2018-12-06 21:01 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
@ 2018-12-06 22:24 ` Ladislav Michl
0 siblings, 0 replies; 7+ messages in thread
From: Ladislav Michl @ 2018-12-06 22:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
Linux Kernel Mailing List, Kuninori Morimoto, anish kumar,
alsa-devel
ret is assigned later, no need to initialize it.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
CHANGES:
-v2: add missing Signed-off-by
(I'm sorry for that...)
sound/soc/codecs/max9867.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 1cda54b59854..1b155f40b106 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -476,7 +476,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
struct max9867_priv *max9867;
- int ret = 0, reg;
+ int ret, reg;
max9867 = devm_kzalloc(&i2c->dev, sizeof(*max9867), GFP_KERNEL);
if (!max9867)
@@ -497,10 +497,8 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
dev_info(&i2c->dev, "device revision: %x\n", reg);
ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
max9867_dai, ARRAY_SIZE(max9867_dai));
- if (ret < 0) {
+ if (ret < 0)
dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
- return ret;
- }
return ret;
}
--
2.20.0.rc2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree
2019-08-08 21:43 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
2019-08-08 22:12 ` Mark Brown
@ 2019-08-08 22:23 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2019-08-08 22:23 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Liam Girdwood, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Fri, Aug 09, 2019 at 07:43:25AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")
>
> is missing a Signed-off-by from its author and committer.
>
> Despite what the commit message says, this is not a merge commit.
Rebuilt the merges now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree
2019-08-08 21:43 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
@ 2019-08-08 22:12 ` Mark Brown
2019-08-08 22:23 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2019-08-08 22:12 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Liam Girdwood, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Fri, Aug 09, 2019 at 07:43:25AM +1000, Stephen Rothwell wrote:
> Commit
> c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")
> is missing a Signed-off-by from its author and committer.
> Despite what the commit message says, this is not a merge commit.
Ugh, that's a git bug - there was a conflict resolution and rather when
I resolved it it seems to have completely thrown away the fact that
there was a merge.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Signed-off-by missing for commit in the sound-asoc tree
@ 2019-08-08 21:43 Stephen Rothwell
2019-08-08 22:12 ` Mark Brown
2019-08-08 22:23 ` Mark Brown
0 siblings, 2 replies; 7+ messages in thread
From: Stephen Rothwell @ 2019-08-08 21:43 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
Hi all,
Commit
c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")
is missing a Signed-off-by from its author and committer.
Despite what the commit message says, this is not a merge commit.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree
2018-03-19 8:12 Stephen Rothwell
@ 2018-03-19 8:20 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2018-03-19 8:20 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Liam Girdwood, Linux-Next Mailing List,
Linux Kernel Mailing List, James Kelly
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
On Mon, Mar 19, 2018 at 07:12:44PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> b9f6c09ae07c ("ASoC: ssm2602: Replace reg_default_raw with reg_default")
Dropped.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Signed-off-by missing for commit in the sound-asoc tree
@ 2018-03-19 8:12 Stephen Rothwell
2018-03-19 8:20 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2018-03-19 8:12 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, James Kelly
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
Hi all,
Commit
b9f6c09ae07c ("ASoC: ssm2602: Replace reg_default_raw with reg_default")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-08 22:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 21:01 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
2018-12-06 22:24 ` [PATCH v2] ASoC: max9867: Remove useless assignment Ladislav Michl
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 21:43 linux-next: Signed-off-by missing for commit in the sound-asoc tree Stephen Rothwell
2019-08-08 22:12 ` Mark Brown
2019-08-08 22:23 ` Mark Brown
2018-03-19 8:12 Stephen Rothwell
2018-03-19 8:20 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.