All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [07/20] dmaengine: at_hdmac: drop useless LIST_HEAD
Date: Mon, 24 Dec 2018 10:36:00 +0100	[thread overview]
Message-ID: <20181224093600.elloyxqa6lx7rw33@M43218.corp.atmel.com> (raw)

On Sun, Dec 23, 2018 at 09:57:02AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> tmp_list has been declared since the introduction of the driver
> and has never been used.  The two declarations of list were
> introduced with the containing functions but were also not used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
> Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> 

Thanks
> 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  drivers/dma/at_hdmac.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 01d936c9fe89..a0a9cd76c1d4 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -134,7 +134,6 @@ static struct at_desc *atc_desc_get(struct at_dma_chan *atchan)
>  	struct at_desc *ret = NULL;
>  	unsigned long flags;
>  	unsigned int i = 0;
> -	LIST_HEAD(tmp_list);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
>  	list_for_each_entry_safe(desc, _desc, &atchan->free_list, desc_node) {
> @@ -1387,8 +1386,6 @@ static int atc_pause(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
> @@ -1408,8 +1405,6 @@ static int atc_resume(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	if (!atc_chan_is_paused(atchan))
>

WARNING: multiple messages have this Message-ID (diff)
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: <kernel-janitors@vger.kernel.org>, Vinod Koul <vkoul@kernel.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD
Date: Mon, 24 Dec 2018 10:36:00 +0100	[thread overview]
Message-ID: <20181224093600.elloyxqa6lx7rw33@M43218.corp.atmel.com> (raw)
In-Reply-To: <1545555435-24576-8-git-send-email-Julia.Lawall@lip6.fr>

On Sun, Dec 23, 2018 at 09:57:02AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> tmp_list has been declared since the introduction of the driver
> and has never been used.  The two declarations of list were
> introduced with the containing functions but were also not used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
> Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> 

Thanks
> 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  drivers/dma/at_hdmac.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 01d936c9fe89..a0a9cd76c1d4 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -134,7 +134,6 @@ static struct at_desc *atc_desc_get(struct at_dma_chan *atchan)
>  	struct at_desc *ret = NULL;
>  	unsigned long flags;
>  	unsigned int i = 0;
> -	LIST_HEAD(tmp_list);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
>  	list_for_each_entry_safe(desc, _desc, &atchan->free_list, desc_node) {
> @@ -1387,8 +1386,6 @@ static int atc_pause(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
> @@ -1408,8 +1405,6 @@ static int atc_resume(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	if (!atc_chan_is_paused(atchan))
> 

WARNING: multiple messages have this Message-ID (diff)
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD
Date: Mon, 24 Dec 2018 09:36:00 +0000	[thread overview]
Message-ID: <20181224093600.elloyxqa6lx7rw33@M43218.corp.atmel.com> (raw)
In-Reply-To: <1545555435-24576-8-git-send-email-Julia.Lawall@lip6.fr>

On Sun, Dec 23, 2018 at 09:57:02AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> tmp_list has been declared since the introduction of the driver
> and has never been used.  The two declarations of list were
> introduced with the containing functions but were also not used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
> Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> 

Thanks
> 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  drivers/dma/at_hdmac.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 01d936c9fe89..a0a9cd76c1d4 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -134,7 +134,6 @@ static struct at_desc *atc_desc_get(struct at_dma_chan *atchan)
>  	struct at_desc *ret = NULL;
>  	unsigned long flags;
>  	unsigned int i = 0;
> -	LIST_HEAD(tmp_list);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
>  	list_for_each_entry_safe(desc, _desc, &atchan->free_list, desc_node) {
> @@ -1387,8 +1386,6 @@ static int atc_pause(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
> @@ -1408,8 +1405,6 @@ static int atc_resume(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	if (!atc_chan_is_paused(atchan))
> 

WARNING: multiple messages have this Message-ID (diff)
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD
Date: Mon, 24 Dec 2018 10:36:00 +0100	[thread overview]
Message-ID: <20181224093600.elloyxqa6lx7rw33@M43218.corp.atmel.com> (raw)
In-Reply-To: <1545555435-24576-8-git-send-email-Julia.Lawall@lip6.fr>

On Sun, Dec 23, 2018 at 09:57:02AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> tmp_list has been declared since the introduction of the driver
> and has never been used.  The two declarations of list were
> introduced with the containing functions but were also not used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
> Fixes: 4facfe7f09f2b ("dmaengine: hdmac: Split device_control")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> 

Thanks
> 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  drivers/dma/at_hdmac.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 01d936c9fe89..a0a9cd76c1d4 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -134,7 +134,6 @@ static struct at_desc *atc_desc_get(struct at_dma_chan *atchan)
>  	struct at_desc *ret = NULL;
>  	unsigned long flags;
>  	unsigned int i = 0;
> -	LIST_HEAD(tmp_list);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
>  	list_for_each_entry_safe(desc, _desc, &atchan->free_list, desc_node) {
> @@ -1387,8 +1386,6 @@ static int atc_pause(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	spin_lock_irqsave(&atchan->lock, flags);
> @@ -1408,8 +1405,6 @@ static int atc_resume(struct dma_chan *chan)
>  	int			chan_id = atchan->chan_common.chan_id;
>  	unsigned long		flags;
>  
> -	LIST_HEAD(list);
> -
>  	dev_vdbg(chan2dev(chan), "%s\n", __func__);
>  
>  	if (!atc_chan_is_paused(atchan))
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2018-12-24  9:36 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24  9:36 Ludovic Desroches [this message]
2018-12-24  9:36 ` [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD Ludovic Desroches
2018-12-24  9:36 ` Ludovic Desroches
2018-12-24  9:36 ` Ludovic Desroches
  -- strict thread matches above, loose matches on Subject: below --
2019-01-02  6:04 [07/20] " Vinod Koul
2019-01-02  6:16 ` [PATCH 07/20] " Vinod Koul
2019-01-02  6:04 ` Vinod Koul
2019-01-02  6:04 [18/20] dmaengine: sa11x0: " Vinod Koul
2019-01-02  6:16 ` [PATCH 18/20] " Vinod Koul
2019-01-02  6:04 ` Vinod Koul
2019-01-02  6:04 [17/20] dmaengine: pl330: " Vinod Koul
2019-01-02  6:16 ` [PATCH 17/20] " Vinod Koul
2019-01-02  6:04 ` Vinod Koul
2019-01-02  6:03 [14/20] dmaengine: st_fdma: " Vinod Koul
2019-01-02  6:15 ` [PATCH 14/20] " Vinod Koul
2019-01-02  6:03 ` Vinod Koul
2019-01-02  6:03 [12/20] dmaengine: dw: " Vinod Koul
2019-01-02  6:15 ` [PATCH 12/20] " Vinod Koul
2019-01-02  6:03 ` Vinod Koul
2018-12-23  8:57 [18/20] dmaengine: sa11x0: " Julia Lawall
2018-12-23  8:57 ` [PATCH 18/20] " Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 [17/20] dmaengine: pl330: " Julia Lawall
2018-12-23  8:57 ` [PATCH 17/20] " Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 [14/20] dmaengine: st_fdma: " Julia Lawall
2018-12-23  8:57 ` [PATCH 14/20] " Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 [12/20] dmaengine: dw: " Julia Lawall
2018-12-23  8:57 ` [PATCH 12/20] " Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 [07/20] dmaengine: at_hdmac: " Julia Lawall
2018-12-23  8:57 ` [PATCH 07/20] " Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:57 ` Julia Lawall
2018-12-23  8:56 [PATCH 00/20] " Julia Lawall
2018-12-23  8:56 ` Julia Lawall
2018-12-23  8:56 ` Julia Lawall
2018-12-23  8:56 ` Julia Lawall
2018-12-23  8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23  8:56   ` Julia Lawall
2018-12-23 21:26   ` J. Bruce Fields
2018-12-23 21:26     ` J. Bruce Fields
2018-12-23  8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
2018-12-23  8:56   ` Julia Lawall
2018-12-23  9:40   ` Leon Romanovsky
2018-12-23  9:40     ` Leon Romanovsky
2018-12-23  8:56 ` [PATCH 03/20] scsi: lpfc: lpfc_nvme: " Julia Lawall
2018-12-23  8:56   ` Julia Lawall
2018-12-23  8:56 ` [PATCH 04/20] scsi: lpfc: lpfc_scsi: " Julia Lawall
2018-12-23  8:56   ` Julia Lawall
2018-12-23  8:57 ` [PATCH 05/20] scsi: lpfc: lpfc_sli: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  9:41   ` Leon Romanovsky
2018-12-23  9:41     ` Leon Romanovsky
2019-01-02 22:48   ` Jason Gunthorpe
2019-01-02 22:48     ` Jason Gunthorpe
2018-12-23  8:57 ` [PATCH 08/20] xfs: xfs_buf: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23 22:51   ` Darrick J. Wong
2018-12-23 22:51     ` Darrick J. Wong
2018-12-24  6:32     ` Julia Lawall
2018-12-24  6:32       ` Julia Lawall
2018-12-23  8:57 ` [PATCH 09/20] xfs: xfs_fsops: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23 22:51   ` Darrick J. Wong
2018-12-23 22:51     ` Darrick J. Wong
2018-12-23  8:57 ` [PATCH 10/20] scsi: qla2xxx: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2019-01-02 16:40   ` David Sterba
2019-01-02 16:40     ` David Sterba
2018-12-23  8:57 ` [PATCH 13/20] xenbus: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2019-01-08  6:58   ` Juergen Gross
2019-01-08  6:58     ` Juergen Gross
2019-01-08  6:58   ` Juergen Gross
2018-12-23  8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2019-02-21 22:40   ` Trond Myklebust
2019-02-21 22:40     ` Trond Myklebust
2018-12-23  8:57 ` [PATCH 16/20] mlxsw: spectrum: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2018-12-23  8:57 ` [PATCH 20/20] cw1200: " Julia Lawall
2018-12-23  8:57   ` Julia Lawall
2019-01-08 16:30   ` Kalle Valo
2019-01-08 16:30     ` Kalle Valo
2019-01-08 16:44     ` Julia Lawall
2019-01-08 16:44       ` Julia Lawall
2019-01-10 11:36   ` Kalle Valo
2019-01-10 11:36     ` Kalle Valo
2018-12-23 12:13 ` [PATCH 00/20] " SF Markus Elfring
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 21:49   ` Tom Psyborg
2018-12-23 21:49   ` Tom Psyborg
2018-12-23 22:06   ` Julia Lawall
2018-12-23 22:06   ` Julia Lawall
2018-12-23 22:06     ` Julia Lawall
2018-12-23 22:06     ` Julia Lawall
2018-12-25 22:12     ` Tom Psyborg
2018-12-25 22:12     ` Tom Psyborg
2018-12-25 22:12       ` Tom Psyborg
2018-12-25 22:12       ` Tom Psyborg
2018-12-25 22:12       ` Tom Psyborg
2018-12-27 13:40       ` Dan Carpenter
2018-12-27 13:40         ` Dan Carpenter
2018-12-27 13:40         ` Dan Carpenter
2018-12-27 13:40         ` Dan Carpenter
2018-12-29  5:25         ` Darrick J. Wong
2018-12-29  5:25           ` Darrick J. Wong
2018-12-29  5:25           ` Darrick J. Wong
2018-12-29  5:25           ` Darrick J. Wong
2018-12-29  6:19           ` Julia Lawall
2018-12-29  6:19           ` Julia Lawall
2018-12-29  6:19             ` Julia Lawall
2018-12-29  6:19             ` Julia Lawall
2018-12-29  5:25         ` Darrick J. Wong
2018-12-27 13:40       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181224093600.elloyxqa6lx7rw33@M43218.corp.atmel.com \
    --to=ludovic.desroches@microchip.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.