From: David Sterba <dsterba@suse.cz>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Chris Mason <clm@fb.com>,
kernel-janitors@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/20] Btrfs: drop useless LIST_HEAD
Date: Wed, 2 Jan 2019 17:40:48 +0100 [thread overview]
Message-ID: <20190102164048.GZ23615@twin.jikos.cz> (raw)
In-Reply-To: <1545555435-24576-12-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Dec 23, 2018 at 09:57:06AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC
> handling for balance"), but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Added to patch queue, thanks. I've dropepd the Fixes: line as it's not
really a fix that would need to go to stable. The original commit is
mentioned in the changelog which is IMHO sufficient.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Chris Mason <clm@fb.com>,
kernel-janitors@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/20] Btrfs: drop useless LIST_HEAD
Date: Wed, 02 Jan 2019 16:40:48 +0000 [thread overview]
Message-ID: <20190102164048.GZ23615@twin.jikos.cz> (raw)
In-Reply-To: <1545555435-24576-12-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Dec 23, 2018 at 09:57:06AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC
> handling for balance"), but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Added to patch queue, thanks. I've dropepd the Fixes: line as it's not
really a fix that would need to go to stable. The original commit is
mentioned in the changelog which is IMHO sufficient.
next prev parent reply other threads:[~2019-01-02 16:41 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 21:26 ` J. Bruce Fields
2018-12-23 21:26 ` J. Bruce Fields
2018-12-23 8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 9:40 ` Leon Romanovsky
2018-12-23 9:40 ` Leon Romanovsky
2018-12-23 8:56 ` [PATCH 03/20] scsi: lpfc: lpfc_nvme: " Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 8:56 ` [PATCH 04/20] scsi: lpfc: lpfc_scsi: " Julia Lawall
2018-12-23 8:56 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 05/20] scsi: lpfc: lpfc_sli: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 9:41 ` Leon Romanovsky
2018-12-23 9:41 ` Leon Romanovsky
2019-01-02 22:48 ` Jason Gunthorpe
2019-01-02 22:48 ` Jason Gunthorpe
2018-12-23 8:57 ` [PATCH 08/20] xfs: xfs_buf: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong
2018-12-23 22:51 ` Darrick J. Wong
2018-12-24 6:32 ` Julia Lawall
2018-12-24 6:32 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 09/20] xfs: xfs_fsops: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 22:51 ` Darrick J. Wong
2018-12-23 22:51 ` Darrick J. Wong
2018-12-23 8:57 ` [PATCH 10/20] scsi: qla2xxx: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2019-01-02 16:40 ` David Sterba [this message]
2019-01-02 16:40 ` David Sterba
2018-12-23 8:57 ` [PATCH 13/20] xenbus: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2019-01-08 6:58 ` Juergen Gross
2019-01-08 6:58 ` Juergen Gross
2019-01-08 6:58 ` Juergen Gross
2018-12-23 8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2019-02-21 22:40 ` Trond Myklebust
2019-02-21 22:40 ` Trond Myklebust
2018-12-23 8:57 ` [PATCH 16/20] mlxsw: spectrum: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` [PATCH 20/20] cw1200: " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2019-01-08 16:30 ` Kalle Valo
2019-01-08 16:30 ` Kalle Valo
2019-01-08 16:44 ` Julia Lawall
2019-01-08 16:44 ` Julia Lawall
2019-01-10 11:36 ` Kalle Valo
2019-01-10 11:36 ` Kalle Valo
2018-12-23 12:13 ` [PATCH 00/20] " SF Markus Elfring
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 21:49 ` Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
2018-12-23 22:06 ` Julia Lawall
2018-12-23 22:06 ` Julia Lawall
2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
2018-12-25 22:12 ` Tom Psyborg
2018-12-25 22:12 ` Tom Psyborg
2018-12-25 22:12 ` Tom Psyborg
2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
2018-12-27 13:40 ` Dan Carpenter
2018-12-27 13:40 ` Dan Carpenter
2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
2018-12-29 6:19 ` Julia Lawall
2018-12-29 6:19 ` Julia Lawall
2018-12-29 6:19 ` Julia Lawall
2018-12-29 5:25 ` Darrick J. Wong
2018-12-27 13:40 ` Dan Carpenter
2018-12-23 8:57 [07/20] dmaengine: at_hdmac: " Julia Lawall
2018-12-23 8:57 ` [PATCH 07/20] " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 [12/20] dmaengine: dw: " Julia Lawall
2018-12-23 8:57 ` [PATCH 12/20] " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 [14/20] dmaengine: st_fdma: " Julia Lawall
2018-12-23 8:57 ` [PATCH 14/20] " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 [17/20] dmaengine: pl330: " Julia Lawall
2018-12-23 8:57 ` [PATCH 17/20] " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-23 8:57 [18/20] dmaengine: sa11x0: " Julia Lawall
2018-12-23 8:57 ` [PATCH 18/20] " Julia Lawall
2018-12-23 8:57 ` Julia Lawall
2018-12-24 9:36 [07/20] dmaengine: at_hdmac: " Ludovic Desroches
2018-12-24 9:36 ` [PATCH 07/20] " Ludovic Desroches
2018-12-24 9:36 ` Ludovic Desroches
2018-12-24 9:36 ` Ludovic Desroches
2019-01-02 6:03 [12/20] dmaengine: dw: " Vinod Koul
2019-01-02 6:15 ` [PATCH 12/20] " Vinod Koul
2019-01-02 6:03 ` Vinod Koul
2019-01-02 6:03 [14/20] dmaengine: st_fdma: " Vinod Koul
2019-01-02 6:15 ` [PATCH 14/20] " Vinod Koul
2019-01-02 6:03 ` Vinod Koul
2019-01-02 6:04 [17/20] dmaengine: pl330: " Vinod Koul
2019-01-02 6:16 ` [PATCH 17/20] " Vinod Koul
2019-01-02 6:04 ` Vinod Koul
2019-01-02 6:04 [18/20] dmaengine: sa11x0: " Vinod Koul
2019-01-02 6:16 ` [PATCH 18/20] " Vinod Koul
2019-01-02 6:04 ` Vinod Koul
2019-01-02 6:04 [07/20] dmaengine: at_hdmac: " Vinod Koul
2019-01-02 6:16 ` [PATCH 07/20] " Vinod Koul
2019-01-02 6:04 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102164048.GZ23615@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Julia.Lawall@lip6.fr \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.