From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Matthias Reichl <hias@horus.com>,
Marcel Ziswiler <marcel@ziswiler.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
Date: Wed, 9 Jan 2019 12:53:40 +0000 [thread overview]
Message-ID: <20190109125340.GD10405@sirena.org.uk> (raw)
In-Reply-To: <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1902 bytes --]
On Wed, Jan 09, 2019 at 11:03:44AM +0000, Jon Hunter wrote:
> On 09/01/2019 01:51, Kuninori Morimoto wrote:
> > "multi platform" is no plan (?).
> I would like someone to explain what multi-platform means? Even if a
> soundcard supports multiple platforms, there is only one platform you
> are using at any time so ...
Platform in this case means DMA driver (for historical reasons I've
never entirely understood the DMA drivers got called the platform
drivers). It is possible that a system might have multiple DMA
implementations in a single sound card but fortunately we don't seem to
run into that.
> > I want to which to modern style immediately and remove legacy style.
> > But as you know, we have too many ALSA SoC drivers now.
> > So, if I posted "switch legacy style to modern style" patch
> > for each (= for codec, for platform, for cpu), it will be patch-bomb,
> > and Lars-Petter/Mark don't like it.
> > Thus, I'm waiting "multi CPU" support patch.
> Sorry, I still don't understand the dependency on the multi CPU and why
> we need to wait.
I believe Morimoto-san's concern is to minimize the number of
refactorings of the drivers as that gets disruptive. That's definitely
a valid concern but we can't postpone fixing bugs over releases, we need
things to work for people.
> > If CPU/Codec/Platform can be snd_soc_init_platform style,
> > then, we can switch to modern style for all drivers.
> > Then, all driver will have *static* platform.
> > # So, I guess if your driver can switch to use
> > # snd_soc_init_platform style directly, your problem can gone ?
> Yes that is an alternative and I can convert all the Tegra machine
> drivers to use this now. However, that will not solve the problem for
> non-Tegra devices and everyone will have to do this.
We're going to have to go through another round of conversions that
touch everything at some point no matter what :/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-tegra@vger.kernel.org, Matthias Reichl <hias@horus.com>,
alsa-devel@alsa-project.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Marcel Ziswiler <marcel@ziswiler.com>
Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
Date: Wed, 9 Jan 2019 12:53:40 +0000 [thread overview]
Message-ID: <20190109125340.GD10405@sirena.org.uk> (raw)
In-Reply-To: <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
On Wed, Jan 09, 2019 at 11:03:44AM +0000, Jon Hunter wrote:
> On 09/01/2019 01:51, Kuninori Morimoto wrote:
> > "multi platform" is no plan (?).
> I would like someone to explain what multi-platform means? Even if a
> soundcard supports multiple platforms, there is only one platform you
> are using at any time so ...
Platform in this case means DMA driver (for historical reasons I've
never entirely understood the DMA drivers got called the platform
drivers). It is possible that a system might have multiple DMA
implementations in a single sound card but fortunately we don't seem to
run into that.
> > I want to which to modern style immediately and remove legacy style.
> > But as you know, we have too many ALSA SoC drivers now.
> > So, if I posted "switch legacy style to modern style" patch
> > for each (= for codec, for platform, for cpu), it will be patch-bomb,
> > and Lars-Petter/Mark don't like it.
> > Thus, I'm waiting "multi CPU" support patch.
> Sorry, I still don't understand the dependency on the multi CPU and why
> we need to wait.
I believe Morimoto-san's concern is to minimize the number of
refactorings of the drivers as that gets disruptive. That's definitely
a valid concern but we can't postpone fixing bugs over releases, we need
things to work for people.
> > If CPU/Codec/Platform can be snd_soc_init_platform style,
> > then, we can switch to modern style for all drivers.
> > Then, all driver will have *static* platform.
> > # So, I guess if your driver can switch to use
> > # snd_soc_init_platform style directly, your problem can gone ?
> Yes that is an alternative and I can convert all the Tegra machine
> drivers to use this now. However, that will not solve the problem for
> non-Tegra devices and everyone will have to do this.
We're going to have to go through another round of conversions that
touch everything at some point no matter what :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-09 12:53 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 11:18 [PATCH v1 0/3] ASoC: last minute fixes Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 1/3] ASoC: tegra_sgtl5000: fix device_node refcounting Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 2/3] ASoC: soc-core: fix trivial checkpatch issues Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-19 12:26 ` Applied "ASoC: soc-core: fix trivial checkpatch issues" to the asoc tree Mark Brown
2018-10-19 12:26 ` Mark Brown
2018-10-19 12:26 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-18 11:18 ` [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-19 10:22 ` Jon Hunter
2018-10-19 10:22 ` Jon Hunter
2018-10-21 11:23 ` Mark Brown
2018-10-21 11:23 ` Mark Brown
2018-12-18 17:40 ` Matthias Reichl
2018-12-18 17:40 ` [alsa-devel] " Matthias Reichl
2019-01-03 16:42 ` Jon Hunter
2019-01-03 16:42 ` Jon Hunter
2019-01-08 2:25 ` Kuninori Morimoto
2019-01-08 2:25 ` Kuninori Morimoto
2019-01-08 10:50 ` Jon Hunter
2019-01-08 10:50 ` [alsa-devel] " Jon Hunter
2019-01-08 12:03 ` Jon Hunter
2019-01-08 12:03 ` Jon Hunter
2019-01-08 15:48 ` Jon Hunter
2019-01-08 15:48 ` Jon Hunter
2019-01-08 16:09 ` Mark Brown
2019-01-08 16:09 ` [alsa-devel] " Mark Brown
2019-01-09 1:51 ` Kuninori Morimoto
2019-01-09 1:51 ` Kuninori Morimoto
2019-01-09 11:03 ` Jon Hunter
2019-01-09 11:03 ` Jon Hunter
2019-01-09 12:53 ` Mark Brown [this message]
2019-01-09 12:53 ` Mark Brown
2019-01-09 14:11 ` Jon Hunter
2019-01-09 14:11 ` Jon Hunter
2019-01-09 14:14 ` Mark Brown
2019-01-09 14:14 ` [alsa-devel] " Mark Brown
2019-01-10 1:16 ` Kuninori Morimoto
2019-01-10 3:46 ` Kuninori Morimoto
2019-01-10 10:56 ` Jon Hunter
2019-01-10 10:56 ` Jon Hunter
2019-01-11 0:52 ` Kuninori Morimoto
2019-01-11 0:52 ` [alsa-devel] " Kuninori Morimoto
2019-01-11 8:41 ` Jon Hunter
2019-01-11 8:41 ` Jon Hunter
2019-01-11 8:51 ` Kuninori Morimoto
2019-01-11 8:51 ` Kuninori Morimoto
2019-01-11 9:15 ` Jon Hunter
2019-01-11 9:15 ` Jon Hunter
2019-01-14 23:02 ` Mark Brown
2019-01-14 23:02 ` [alsa-devel] " Mark Brown
2019-01-15 15:26 ` Jon Hunter
2019-01-15 15:26 ` Jon Hunter
2019-01-15 18:07 ` Matthias Reichl
2019-01-08 15:33 ` Mark Brown
2019-01-08 15:33 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109125340.GD10405@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=hias@horus.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.