From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Matthias Reichl <hias@horus.com>,
Mark Brown <broonie@kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
Date: 11 Jan 2019 09:52:12 +0900 [thread overview]
Message-ID: <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <a2068291-e554-cc4f-9af9-0022f3c4de34@nvidia.com>
Hi Jon
> Actually no. Looking at snd_soc_init_multicodec() it always allocates
> memory if any of the 'legacy' codec members
> (codec_name/codec_of_node/codec_dai_name) are populated. However, this
> looks quite fragile to me and is susceptible to leaking memory if the
> user/machine driver already incorrectly allocated the memory as well as
> populating these legacy codec members.
Yeah, sorry I was 100% misunderstood.
I thought there is a case that defered card connected to
unbind_card_list, and try snd_soc_init_platform/codec again
without freeing memory...
very mess
> My concern about all of this is it is not fool proof and hard to detect
> if a machine driver is doing something bad that it should not.
Yeah, agree.
Best solution is removing legacy style, I think.
> It is still fragile. Again the machine driver could have incorrectly set
> these 'allocated_platform/codecs' members as they are exposed to the
> machine driver. You have no way to determine if the machine driver is
> doing the correct thing or not. The problem becomes more complex with
> probe deferral.
Indeed there is such case so far, but my understanding is that current
driver should select "legacy style" or "modern style".
If driver setup it as "legacy", but access to "modern" member,
it is driver side bug, right ?
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-tegra@vger.kernel.org>, Matthias Reichl <hias@horus.com>,
<alsa-devel@alsa-project.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>
Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
Date: 11 Jan 2019 09:52:12 +0900 [thread overview]
Message-ID: <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <a2068291-e554-cc4f-9af9-0022f3c4de34@nvidia.com>
Hi Jon
> Actually no. Looking at snd_soc_init_multicodec() it always allocates
> memory if any of the 'legacy' codec members
> (codec_name/codec_of_node/codec_dai_name) are populated. However, this
> looks quite fragile to me and is susceptible to leaking memory if the
> user/machine driver already incorrectly allocated the memory as well as
> populating these legacy codec members.
Yeah, sorry I was 100% misunderstood.
I thought there is a case that defered card connected to
unbind_card_list, and try snd_soc_init_platform/codec again
without freeing memory...
very mess
> My concern about all of this is it is not fool proof and hard to detect
> if a machine driver is doing something bad that it should not.
Yeah, agree.
Best solution is removing legacy style, I think.
> It is still fragile. Again the machine driver could have incorrectly set
> these 'allocated_platform/codecs' members as they are exposed to the
> machine driver. You have no way to determine if the machine driver is
> doing the correct thing or not. The problem becomes more complex with
> probe deferral.
Indeed there is such case so far, but my understanding is that current
driver should select "legacy style" or "modern style".
If driver setup it as "legacy", but access to "modern" member,
it is driver side bug, right ?
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2019-01-11 0:52 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 11:18 [PATCH v1 0/3] ASoC: last minute fixes Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 1/3] ASoC: tegra_sgtl5000: fix device_node refcounting Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 2/3] ASoC: soc-core: fix trivial checkpatch issues Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-19 12:26 ` Applied "ASoC: soc-core: fix trivial checkpatch issues" to the asoc tree Mark Brown
2018-10-19 12:26 ` Mark Brown
2018-10-19 12:26 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-18 11:18 ` [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement Marcel Ziswiler
2018-10-18 11:18 ` Marcel Ziswiler
2018-10-19 10:22 ` Jon Hunter
2018-10-19 10:22 ` Jon Hunter
2018-10-21 11:23 ` Mark Brown
2018-10-21 11:23 ` Mark Brown
2018-12-18 17:40 ` Matthias Reichl
2018-12-18 17:40 ` [alsa-devel] " Matthias Reichl
2019-01-03 16:42 ` Jon Hunter
2019-01-03 16:42 ` Jon Hunter
2019-01-08 2:25 ` Kuninori Morimoto
2019-01-08 2:25 ` Kuninori Morimoto
2019-01-08 10:50 ` Jon Hunter
2019-01-08 10:50 ` [alsa-devel] " Jon Hunter
2019-01-08 12:03 ` Jon Hunter
2019-01-08 12:03 ` Jon Hunter
2019-01-08 15:48 ` Jon Hunter
2019-01-08 15:48 ` Jon Hunter
2019-01-08 16:09 ` Mark Brown
2019-01-08 16:09 ` [alsa-devel] " Mark Brown
2019-01-09 1:51 ` Kuninori Morimoto
2019-01-09 1:51 ` Kuninori Morimoto
2019-01-09 11:03 ` Jon Hunter
2019-01-09 11:03 ` Jon Hunter
2019-01-09 12:53 ` Mark Brown
2019-01-09 12:53 ` [alsa-devel] " Mark Brown
2019-01-09 14:11 ` Jon Hunter
2019-01-09 14:11 ` Jon Hunter
2019-01-09 14:14 ` Mark Brown
2019-01-09 14:14 ` [alsa-devel] " Mark Brown
2019-01-10 1:16 ` Kuninori Morimoto
2019-01-10 3:46 ` Kuninori Morimoto
2019-01-10 10:56 ` Jon Hunter
2019-01-10 10:56 ` Jon Hunter
2019-01-11 0:52 ` Kuninori Morimoto [this message]
2019-01-11 0:52 ` Kuninori Morimoto
2019-01-11 8:41 ` Jon Hunter
2019-01-11 8:41 ` Jon Hunter
2019-01-11 8:51 ` Kuninori Morimoto
2019-01-11 8:51 ` Kuninori Morimoto
2019-01-11 9:15 ` Jon Hunter
2019-01-11 9:15 ` Jon Hunter
2019-01-14 23:02 ` Mark Brown
2019-01-14 23:02 ` [alsa-devel] " Mark Brown
2019-01-15 15:26 ` Jon Hunter
2019-01-15 15:26 ` Jon Hunter
2019-01-15 18:07 ` Matthias Reichl
2019-01-08 15:33 ` Mark Brown
2019-01-08 15:33 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s5kqb43.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hias@horus.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.