From: "Michael S. Tsirkin" <mst@redhat.com> To: Igor Mammedov <imammedo@redhat.com> Cc: Samuel Ortiz <sameo@linux.intel.com>, qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Richard Henderson <rth@twiddle.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, xen-devel@lists.xenproject.org, Paolo Bonzini <pbonzini@redhat.com>, qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Yang Zhong <yang.zhong@intel.com> Subject: Re: [Qemu-devel] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error Date: Mon, 14 Jan 2019 13:35:37 -0500 [thread overview] Message-ID: <20190114133455-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20181108152341.68e5a147@redhat.com> On Thu, Nov 08, 2018 at 03:23:41PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:39 +0100 > Samuel Ortiz <sameo@linux.intel.com> wrote: > > > From: Yang Zhong <yang.zhong@intel.com> > > > > When using the generated memory hotplug AML, the iasl > > compiler would give the following error: > > > > dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) > > Error 6080 - Called method returns no value ^ > > > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > Reviewed-by: Igor Mammedov <imammedo@redhat.com> > > I suggest to put this patch at the beginning of the series > before reference tables in test are updated. Samuel how about a separate small series with just bugfixes for starters? > > --- > > hw/acpi/memory_hotplug.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > index db2c4df961..893fc2bd27 100644 > > --- a/hw/acpi/memory_hotplug.c > > +++ b/hw/acpi/memory_hotplug.c > > @@ -686,15 +686,15 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem, > > > > method = aml_method("_OST", 3, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_OST_METHOD; > > - aml_append(method, aml_return(aml_call4( > > - s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2) > > - ))); > > + aml_append(method, > > + aml_call4(s, aml_name("_UID"), aml_arg(0), > > + aml_arg(1), aml_arg(2))); > > aml_append(dev, method); > > > > method = aml_method("_EJ0", 1, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_EJECT_METHOD; > > - aml_append(method, aml_return(aml_call2( > > - s, aml_name("_UID"), aml_arg(0)))); > > + aml_append(method, > > + aml_call2(s, aml_name("_UID"), aml_arg(0))); > > aml_append(dev, method); > > > > aml_append(dev_container, dev);
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Igor Mammedov <imammedo@redhat.com> Cc: Yang Zhong <yang.zhong@intel.com>, Peter Maydell <peter.maydell@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>, Samuel Ortiz <sameo@linux.intel.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, qemu-arm@nongnu.org, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Richard Henderson <rth@twiddle.net> Subject: Re: [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error Date: Mon, 14 Jan 2019 13:35:37 -0500 [thread overview] Message-ID: <20190114133455-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20181108152341.68e5a147@redhat.com> On Thu, Nov 08, 2018 at 03:23:41PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:39 +0100 > Samuel Ortiz <sameo@linux.intel.com> wrote: > > > From: Yang Zhong <yang.zhong@intel.com> > > > > When using the generated memory hotplug AML, the iasl > > compiler would give the following error: > > > > dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) > > Error 6080 - Called method returns no value ^ > > > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > Reviewed-by: Igor Mammedov <imammedo@redhat.com> > > I suggest to put this patch at the beginning of the series > before reference tables in test are updated. Samuel how about a separate small series with just bugfixes for starters? > > --- > > hw/acpi/memory_hotplug.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > index db2c4df961..893fc2bd27 100644 > > --- a/hw/acpi/memory_hotplug.c > > +++ b/hw/acpi/memory_hotplug.c > > @@ -686,15 +686,15 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem, > > > > method = aml_method("_OST", 3, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_OST_METHOD; > > - aml_append(method, aml_return(aml_call4( > > - s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2) > > - ))); > > + aml_append(method, > > + aml_call4(s, aml_name("_UID"), aml_arg(0), > > + aml_arg(1), aml_arg(2))); > > aml_append(dev, method); > > > > method = aml_method("_EJ0", 1, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_EJECT_METHOD; > > - aml_append(method, aml_return(aml_call2( > > - s, aml_name("_UID"), aml_arg(0)))); > > + aml_append(method, > > + aml_call2(s, aml_name("_UID"), aml_arg(0))); > > aml_append(dev, method); > > > > aml_append(dev_container, dev); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-14 18:35 UTC|newest] Thread overview: 170+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 1:40 [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-09 14:23 ` [Qemu-devel] " Igor Mammedov 2018-11-09 14:23 ` Igor Mammedov 2018-11-21 14:42 ` [Qemu-devel] " Samuel Ortiz 2018-11-21 14:42 ` Samuel Ortiz 2018-11-22 15:13 ` Igor Mammedov 2018-11-22 15:13 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-09 14:27 ` [Qemu-devel] " Igor Mammedov 2018-11-09 14:27 ` Igor Mammedov 2018-11-21 14:42 ` [Qemu-devel] " Samuel Ortiz 2018-11-21 14:42 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-06 10:23 ` [Qemu-devel] " Paolo Bonzini 2018-11-06 10:23 ` Paolo Bonzini 2018-11-06 10:43 ` [Qemu-devel] " Samuel Ortiz 2018-11-06 10:43 ` Samuel Ortiz 2018-11-08 14:24 ` [Qemu-devel] " Igor Mammedov 2018-11-08 14:24 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 04/24] hw: acpi: Export the RSDP build API Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-08 14:16 ` [Qemu-devel] " Igor Mammedov 2018-11-08 14:16 ` Igor Mammedov 2018-11-08 14:36 ` [Qemu-devel] " Samuel Ortiz 2018-11-08 14:36 ` Samuel Ortiz 2018-11-08 14:53 ` [Qemu-devel] " Igor Mammedov 2018-11-08 14:53 ` Igor Mammedov 2018-11-19 18:27 ` Michael S. Tsirkin 2018-11-19 18:27 ` Michael S. Tsirkin 2018-11-20 8:23 ` [Qemu-devel] " Igor Mammedov 2018-11-20 8:23 ` Igor Mammedov 2018-11-21 14:42 ` [Qemu-devel] " Samuel Ortiz 2018-11-21 14:42 ` Samuel Ortiz 2018-11-22 16:26 ` Igor Mammedov 2018-11-22 16:26 ` Igor Mammedov 2018-11-23 9:36 ` Samuel Ortiz 2018-11-23 9:36 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 06/24] hw: acpi: Factorize the RSDP build API implementation Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-09 13:37 ` [Qemu-devel] " Igor Mammedov 2018-11-21 15:00 ` Samuel Ortiz 2018-11-21 15:00 ` Samuel Ortiz 2018-11-09 13:37 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 08/24] hw: acpi: Factorize _OSC AML across architectures Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-09 14:30 ` [Qemu-devel] " Igor Mammedov 2018-11-09 14:30 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-13 15:59 ` [Qemu-devel] " Igor Mammedov 2018-11-13 15:59 ` Igor Mammedov 2018-11-21 15:43 ` Samuel Ortiz 2018-11-21 15:43 ` Samuel Ortiz 2018-11-23 10:55 ` Igor Mammedov 2018-11-23 10:55 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-14 10:55 ` [Qemu-devel] " Igor Mammedov 2018-11-14 10:55 ` Igor Mammedov 2018-11-21 23:12 ` [Qemu-devel] " Samuel Ortiz 2018-11-21 23:12 ` Samuel Ortiz 2018-11-23 11:04 ` Igor Mammedov 2018-11-23 11:04 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 12/24] hw: acpi: Export the MCFG getter Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-15 12:36 ` [Qemu-devel] " Igor Mammedov 2018-11-15 12:36 ` Igor Mammedov 2018-11-21 23:21 ` [Qemu-devel] " Samuel Ortiz 2018-11-21 23:21 ` Samuel Ortiz 2018-11-27 13:54 ` Igor Mammedov 2018-11-27 13:54 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 13/24] hw: acpi: Do not create hotplug method when handler is not defined Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-09 9:12 ` [Qemu-devel] " Igor Mammedov 2018-11-09 9:12 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 14/24] hw: i386: Make the hotpluggable memory size property more generic Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-15 12:49 ` [Qemu-devel] " Igor Mammedov 2018-11-15 12:49 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-15 13:28 ` [Qemu-devel] " Igor Mammedov 2018-11-15 13:28 ` Igor Mammedov 2018-11-21 23:27 ` Samuel Ortiz 2018-11-21 23:27 ` Samuel Ortiz 2018-11-26 15:47 ` Igor Mammedov 2018-11-26 15:47 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-08 14:23 ` [Qemu-devel] " Igor Mammedov 2018-11-08 14:23 ` Igor Mammedov 2019-01-14 18:35 ` Michael S. Tsirkin [this message] 2019-01-14 18:35 ` Michael S. Tsirkin 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 17/24] hw: acpi: Export the PCI hotplug API Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-16 9:27 ` [Qemu-devel] " Igor Mammedov 2018-11-16 9:27 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-16 9:39 ` [Qemu-devel] " Igor Mammedov 2018-11-16 9:39 ` Igor Mammedov 2018-11-16 19:42 ` [Qemu-devel] " Boeuf, Sebastien 2018-11-19 15:37 ` Igor Mammedov 2018-11-19 15:37 ` Igor Mammedov 2018-11-19 18:02 ` [Qemu-devel] " Boeuf, Sebastien 2018-11-19 18:02 ` Boeuf, Sebastien 2018-11-20 8:26 ` [Qemu-devel] " Igor Mammedov 2018-11-20 8:26 ` Igor Mammedov 2018-11-16 19:42 ` Boeuf, Sebastien 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-16 16:02 ` [Qemu-devel] " Igor Mammedov 2018-11-16 16:02 ` Igor Mammedov 2018-11-21 23:57 ` Samuel Ortiz 2018-11-21 23:57 ` Samuel Ortiz 2018-11-27 14:08 ` Igor Mammedov 2018-11-27 14:08 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 21/24] hw: i386: Implement the ACPI builder interface for PC Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 22/24] hw: pci-host: piix: Return PCI host pointer instead of PCI bus Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-16 11:09 ` [Qemu-devel] " Igor Mammedov 2018-11-16 11:09 ` Igor Mammedov 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 23/24] hw: i386: Set ACPI configuration PCI host pointer Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-05 1:40 ` [Qemu-devel] [PATCH v5 24/24] hw: i386: Refactor PCI host getter Samuel Ortiz 2018-11-05 1:40 ` Samuel Ortiz 2018-11-16 16:29 ` [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition Igor Mammedov 2018-11-16 16:29 ` Igor Mammedov 2018-11-16 16:37 ` Paolo Bonzini 2018-11-16 16:37 ` Paolo Bonzini 2018-11-19 15:31 ` Igor Mammedov 2018-11-19 15:31 ` Igor Mammedov 2018-11-19 17:14 ` Paolo Bonzini 2018-11-19 17:14 ` Paolo Bonzini 2018-11-19 18:14 ` Michael S. Tsirkin 2018-11-19 18:14 ` Michael S. Tsirkin 2018-11-20 21:35 ` Paolo Bonzini 2018-11-20 21:35 ` Paolo Bonzini 2018-11-20 12:57 ` Igor Mammedov 2018-11-20 12:57 ` Igor Mammedov 2018-11-20 21:36 ` Paolo Bonzini 2018-11-20 21:36 ` Paolo Bonzini 2018-11-21 12:35 ` Michael S. Tsirkin 2018-11-21 12:35 ` Michael S. Tsirkin 2018-11-21 13:50 ` Samuel Ortiz 2018-11-21 13:50 ` Samuel Ortiz 2018-11-21 13:57 ` Michael S. Tsirkin 2018-11-21 13:57 ` Michael S. Tsirkin 2018-11-21 14:15 ` Igor Mammedov 2018-11-21 14:15 ` Igor Mammedov 2018-11-21 14:38 ` Samuel Ortiz 2018-11-21 14:38 ` Samuel Ortiz 2018-11-22 10:39 ` Igor Mammedov 2018-11-22 10:39 ` Igor Mammedov 2018-11-22 0:17 ` Samuel Ortiz 2018-11-22 0:17 ` Samuel Ortiz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190114133455-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=anthony.perard@citrix.com \ --cc=ehabkost@redhat.com \ --cc=imammedo@redhat.com \ --cc=marcel.apfelbaum@gmail.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=sameo@linux.intel.com \ --cc=shannon.zhaosl@gmail.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ --cc=yang.zhong@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.