From: Geert Uytterhoeven <geert+renesas@glider.be> To: Shuah Khan <shuah@kernel.org>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <michal.lkml@markovi.net> Cc: Jonathan Corbet <corbet@lwn.net>, Bamvor Jian Zhang <bamv2005@gmail.com>, Kees Cook <keescook@chromium.org>, linux-kselftest@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 04/12] selftests: android: ion: Fix ionmap_test dependencies Date: Mon, 14 Jan 2019 14:51:36 +0100 [thread overview] Message-ID: <20190114135144.26096-5-geert+renesas@glider.be> (raw) In-Reply-To: <20190114135144.26096-1-geert+renesas@glider.be> When building kselftest in a separate output directory: /tmp/cc44s4yX.o: In function `socket_send_fd': tools/testing/selftests/android/ion/ionutils.c:221: undefined reference to `sendtosocket' /tmp/cc44s4yX.o: In function `socket_receive_fd': tools/testing/selftests/android/ion/ionutils.c:243: undefined reference to `receivefromsocket' The dependencies for the various test programs are expressed twice: 1. Once using $(TEST_GEN_FILES), which supports building in the source directory only, 2. A second time using $(OUTPUT), which supports building in either the source or build directory, but lacks a dependency of ionmap_test on ipcsocket, causing the link error above. Fix this by: - Adding the missing dependency to 2, - Dropping superfluous rule 1. Remove the "all" target while at it, as that is already handled by the included lib.mk. Fixes: ac93f7046a5371ff ("selftests: ion: Add simple test with the vgem driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- tools/testing/selftests/android/ion/Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/testing/selftests/android/ion/Makefile b/tools/testing/selftests/android/ion/Makefile index 88cfe88e466fb0e6..ce05c5f3594bcf87 100644 --- a/tools/testing/selftests/android/ion/Makefile +++ b/tools/testing/selftests/android/ion/Makefile @@ -4,10 +4,6 @@ CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test -all: $(TEST_GEN_FILES) - -$(TEST_GEN_FILES): ipcsocket.c ionutils.c - TEST_PROGS := ion_test.sh KSFT_KHDR_INSTALL := 1 @@ -16,4 +12,4 @@ include ../../lib.mk $(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c $(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c -$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c +$(OUTPUT)/ionmap_test: ionmap_test.c ipcsocket.c ionutils.c -- 2.17.1
WARNING: multiple messages have this Message-ID
From: geert+renesas at glider.be (Geert Uytterhoeven) Subject: [PATCH 04/12] selftests: android: ion: Fix ionmap_test dependencies Date: Mon, 14 Jan 2019 14:51:36 +0100 [thread overview] Message-ID: <20190114135144.26096-5-geert+renesas@glider.be> (raw) In-Reply-To: <20190114135144.26096-1-geert+renesas@glider.be> When building kselftest in a separate output directory: /tmp/cc44s4yX.o: In function `socket_send_fd': tools/testing/selftests/android/ion/ionutils.c:221: undefined reference to `sendtosocket' /tmp/cc44s4yX.o: In function `socket_receive_fd': tools/testing/selftests/android/ion/ionutils.c:243: undefined reference to `receivefromsocket' The dependencies for the various test programs are expressed twice: 1. Once using $(TEST_GEN_FILES), which supports building in the source directory only, 2. A second time using $(OUTPUT), which supports building in either the source or build directory, but lacks a dependency of ionmap_test on ipcsocket, causing the link error above. Fix this by: - Adding the missing dependency to 2, - Dropping superfluous rule 1. Remove the "all" target while at it, as that is already handled by the included lib.mk. Fixes: ac93f7046a5371ff ("selftests: ion: Add simple test with the vgem driver") Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be> --- tools/testing/selftests/android/ion/Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/testing/selftests/android/ion/Makefile b/tools/testing/selftests/android/ion/Makefile index 88cfe88e466fb0e6..ce05c5f3594bcf87 100644 --- a/tools/testing/selftests/android/ion/Makefile +++ b/tools/testing/selftests/android/ion/Makefile @@ -4,10 +4,6 @@ CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test -all: $(TEST_GEN_FILES) - -$(TEST_GEN_FILES): ipcsocket.c ionutils.c - TEST_PROGS := ion_test.sh KSFT_KHDR_INSTALL := 1 @@ -16,4 +12,4 @@ include ../../lib.mk $(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c $(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c -$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c +$(OUTPUT)/ionmap_test: ionmap_test.c ipcsocket.c ionutils.c -- 2.17.1
WARNING: multiple messages have this Message-ID
From: geert+renesas@glider.be (Geert Uytterhoeven) Subject: [PATCH 04/12] selftests: android: ion: Fix ionmap_test dependencies Date: Mon, 14 Jan 2019 14:51:36 +0100 [thread overview] Message-ID: <20190114135144.26096-5-geert+renesas@glider.be> (raw) Message-ID: <20190114135136.K0KVaqAtUhZDEH3HKhVyeQ8OUpG6fN3WsIm7CSxti4o@z> (raw) In-Reply-To: <20190114135144.26096-1-geert+renesas@glider.be> When building kselftest in a separate output directory: /tmp/cc44s4yX.o: In function `socket_send_fd': tools/testing/selftests/android/ion/ionutils.c:221: undefined reference to `sendtosocket' /tmp/cc44s4yX.o: In function `socket_receive_fd': tools/testing/selftests/android/ion/ionutils.c:243: undefined reference to `receivefromsocket' The dependencies for the various test programs are expressed twice: 1. Once using $(TEST_GEN_FILES), which supports building in the source directory only, 2. A second time using $(OUTPUT), which supports building in either the source or build directory, but lacks a dependency of ionmap_test on ipcsocket, causing the link error above. Fix this by: - Adding the missing dependency to 2, - Dropping superfluous rule 1. Remove the "all" target while at it, as that is already handled by the included lib.mk. Fixes: ac93f7046a5371ff ("selftests: ion: Add simple test with the vgem driver") Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be> --- tools/testing/selftests/android/ion/Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/testing/selftests/android/ion/Makefile b/tools/testing/selftests/android/ion/Makefile index 88cfe88e466fb0e6..ce05c5f3594bcf87 100644 --- a/tools/testing/selftests/android/ion/Makefile +++ b/tools/testing/selftests/android/ion/Makefile @@ -4,10 +4,6 @@ CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test -all: $(TEST_GEN_FILES) - -$(TEST_GEN_FILES): ipcsocket.c ionutils.c - TEST_PROGS := ion_test.sh KSFT_KHDR_INSTALL := 1 @@ -16,4 +12,4 @@ include ../../lib.mk $(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c $(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c -$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c +$(OUTPUT)/ionmap_test: ionmap_test.c ipcsocket.c ionutils.c -- 2.17.1
next prev parent reply other threads:[~2019-01-14 13:52 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-14 13:51 [PATCH 00/12] selftests: Miscellaneous fixes Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 01/12] selftests: gpio-mockup-chardev: Check asprintf() for error Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-16 22:03 ` shuah 2019-01-16 22:03 ` shuah 2019-01-16 22:03 ` shuah 2019-01-14 13:51 ` [PATCH 02/12] selftests: Fix output directory with O= Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 03/12] selftests: Fix header install " Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` Geert Uytterhoeven [this message] 2019-01-14 13:51 ` [PATCH 04/12] selftests: android: ion: Fix ionmap_test dependencies Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 05/12] selftests: seccomp: Fix test dependencies and rules Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 23:16 ` Kees Cook 2019-01-14 23:16 ` Kees Cook 2019-01-14 23:16 ` Kees Cook 2019-01-14 23:16 ` keescook 2019-01-14 13:51 ` [PATCH 06/12] selftests: lib.mk: Add rule to build object file from C source file Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 07/12] selftests: memfd: Fix build with O= Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 08/12] selftests: timestamping: Remove superfluous rules Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 09/12] selftests: sparc64: " Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 10/12] selftests: intel_pstate: Remove unused header dependency rule Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH 11/12] selftests: Add kselftest-build target Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-14 13:51 ` [PATCH/RFC 12/12] selftests: gpio: Fix building tools/gpio from kselftests Geert Uytterhoeven 2019-01-14 13:51 ` Geert Uytterhoeven 2019-01-14 13:51 ` geert+renesas 2019-01-18 4:14 ` [PATCH 00/12] selftests: Miscellaneous fixes Masahiro Yamada 2019-01-18 4:14 ` Masahiro Yamada 2019-01-18 4:14 ` Masahiro Yamada 2019-01-18 4:14 ` yamada.masahiro 2019-01-18 7:57 ` Geert Uytterhoeven 2019-01-18 7:57 ` Geert Uytterhoeven 2019-01-18 7:57 ` Geert Uytterhoeven 2019-01-18 7:57 ` geert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190114135144.26096-5-geert+renesas@glider.be \ --to=geert+renesas@glider.be \ --cc=bamv2005@gmail.com \ --cc=corbet@lwn.net \ --cc=keescook@chromium.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=michal.lkml@markovi.net \ --cc=shuah@kernel.org \ --cc=yamada.masahiro@socionext.com \ --subject='Re: [PATCH 04/12] selftests: android: ion: Fix ionmap_test dependencies' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.