All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Evan Green <evgreen@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Can Guo <cang@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	David Brown <david.brown@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1 3/8] arm64: dts: sdm845: Add UFS PHY reset
Date: Mon, 21 Jan 2019 18:25:49 -0600	[thread overview]
Message-ID: <20190122002549.GA20481@bogus> (raw)
In-Reply-To: <20190111230129.127037-4-evgreen@chromium.org>

On Fri, Jan 11, 2019 at 03:01:24PM -0800, Evan Green wrote:
> Wire up the reset controller in the Qcom UFS controller for the PHY.
> This will be used to toggle PHY reset during initialization of the PHY.
> 
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
> This commit is based atop the series at [1]. Patches 1 and 2 of that
> series have landed, but 3, 4, and 5 are still outstanding.
> 
> [1] https://lore.kernel.org/lkml/20181210192826.241350-1-evgreen@chromium.org/
> 
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index b29332b265d9e..029ab66405cf4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -990,6 +990,7 @@
>  			phy-names = "ufsphy";
>  			lanes-per-direction = <2>;
>  			power-domains = <&gcc UFS_PHY_GDSC>;
> +			#reset-cells = <1>;

Is this documented?

>  
>  			clock-names =
>  				"core_clk",
> @@ -1033,6 +1034,8 @@
>  			clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
>  				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
>  
> +			resets = <&ufs_mem_hc 0>;
> +			reset-names = "ufsphy";
>  			status = "disabled";
>  
>  			ufs_mem_phy_lanes: lanes@1d87400 {
> -- 
> 2.18.1
> 

  parent reply	other threads:[~2019-01-22  0:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 23:01 [PATCH v1 0/8] phy: qcom-ufs: Enable regulators to be off in suspend Evan Green
2019-01-11 23:01 ` [PATCH v1 1/8] dt-bindings: phy-qcom-qmp: Add UFS PHY reset Evan Green
2019-01-22  0:21   ` Rob Herring
2019-01-22  0:21     ` Rob Herring
2019-01-11 23:01 ` [PATCH v1 2/8] dt-bindings: phy: qcom-ufs: Add resets property Evan Green
2019-01-16 21:29   ` Stephen Boyd
2019-01-16 21:29     ` Stephen Boyd
2019-01-22 18:34     ` Evan Green
2019-01-22  0:26   ` Rob Herring
2019-01-22  0:26     ` Rob Herring
2019-01-11 23:01 ` [PATCH v1 3/8] arm64: dts: sdm845: Add UFS PHY reset Evan Green
2019-01-18 22:20   ` Stephen Boyd
2019-01-18 22:20     ` Stephen Boyd
2019-01-22  0:25   ` Rob Herring [this message]
2019-01-22 18:13     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 4/8] arm64: dts: msm8996: Add UFS PHY reset controller Evan Green
2019-01-18 22:20   ` Stephen Boyd
2019-01-18 22:20     ` Stephen Boyd
2019-01-11 23:01 ` [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY Evan Green
2019-01-16  8:52   ` Kishon Vijay Abraham I
2019-01-16  8:52     ` Kishon Vijay Abraham I
2019-01-17  2:28     ` Martin K. Petersen
2019-01-17  2:28       ` Martin K. Petersen
2019-01-18 22:31   ` Stephen Boyd
2019-01-18 22:31     ` Stephen Boyd
2019-01-22 22:40     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 6/8] phy: qcom-qmp: Utilize UFS reset controller Evan Green
2019-01-18 22:33   ` Stephen Boyd
2019-01-22 22:41     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 7/8] phy: qcom-qmp: Move UFS phy to phy_poweron/off Evan Green
2019-01-18 22:39   ` Stephen Boyd
2019-01-22 22:42     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 8/8] phy: qcom-ufs: Refactor all init steps into phy_poweron Evan Green
2019-01-18 23:50   ` Stephen Boyd
2019-01-22 22:44     ` Evan Green
2019-01-16 22:32 ` [PATCH v1 0/8] phy: qcom-ufs: Enable regulators to be off in suspend Stephen Boyd
2019-01-16 22:32   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122002549.GA20481@bogus \
    --to=robh@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=swboyd@chromium.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.