All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Evan Green <evgreen@chromium.org>,
	Andy Gross <andy.gross@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Can Guo <cang@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY
Date: Wed, 16 Jan 2019 21:28:07 -0500	[thread overview]
Message-ID: <yq1imyoqaq0.fsf@oracle.com> (raw)
In-Reply-To: <a289d841-858d-5583-ce9a-8dc0f2d18a78@ti.com> (Kishon Vijay Abraham, I's message of "Wed, 16 Jan 2019 14:22:25 +0530")


Kishon,

> On 12/01/19 4:31 AM, Evan Green wrote:
>> Expose a reset controller that the phy can use to perform its
>> initialization in a single callback.
>> 
>> Also, change the use of the phy functions from ufs-qcom such that
>> phy_poweron actually fires up the phy, and phy_poweroff actually
>> powers it down.
>> 
>> Signed-off-by: Evan Green <evgreen@chromium.org>
>
> Can I get Ack for this patch from SCSI MAINTAINERS?

No objection from me if there is general consensus that moving reset to
the phy is the right thing to do.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Evan Green <evgreen@chromium.org>,
	Andy Gross <andy.gross@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Can Guo <cang@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY
Date: Wed, 16 Jan 2019 21:28:07 -0500	[thread overview]
Message-ID: <yq1imyoqaq0.fsf@oracle.com> (raw)
In-Reply-To: <a289d841-858d-5583-ce9a-8dc0f2d18a78@ti.com> (Kishon Vijay Abraham, I's message of "Wed, 16 Jan 2019 14:22:25 +0530")


Kishon,

> On 12/01/19 4:31 AM, Evan Green wrote:
>> Expose a reset controller that the phy can use to perform its
>> initialization in a single callback.
>> 
>> Also, change the use of the phy functions from ufs-qcom such that
>> phy_poweron actually fires up the phy, and phy_poweroff actually
>> powers it down.
>> 
>> Signed-off-by: Evan Green <evgreen@chromium.org>
>
> Can I get Ack for this patch from SCSI MAINTAINERS?

No objection from me if there is general consensus that moving reset to
the phy is the right thing to do.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-01-17  2:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 23:01 [PATCH v1 0/8] phy: qcom-ufs: Enable regulators to be off in suspend Evan Green
2019-01-11 23:01 ` [PATCH v1 1/8] dt-bindings: phy-qcom-qmp: Add UFS PHY reset Evan Green
2019-01-22  0:21   ` Rob Herring
2019-01-22  0:21     ` Rob Herring
2019-01-11 23:01 ` [PATCH v1 2/8] dt-bindings: phy: qcom-ufs: Add resets property Evan Green
2019-01-16 21:29   ` Stephen Boyd
2019-01-16 21:29     ` Stephen Boyd
2019-01-22 18:34     ` Evan Green
2019-01-22  0:26   ` Rob Herring
2019-01-22  0:26     ` Rob Herring
2019-01-11 23:01 ` [PATCH v1 3/8] arm64: dts: sdm845: Add UFS PHY reset Evan Green
2019-01-18 22:20   ` Stephen Boyd
2019-01-18 22:20     ` Stephen Boyd
2019-01-22  0:25   ` Rob Herring
2019-01-22 18:13     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 4/8] arm64: dts: msm8996: Add UFS PHY reset controller Evan Green
2019-01-18 22:20   ` Stephen Boyd
2019-01-18 22:20     ` Stephen Boyd
2019-01-11 23:01 ` [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY Evan Green
2019-01-16  8:52   ` Kishon Vijay Abraham I
2019-01-16  8:52     ` Kishon Vijay Abraham I
2019-01-17  2:28     ` Martin K. Petersen [this message]
2019-01-17  2:28       ` Martin K. Petersen
2019-01-18 22:31   ` Stephen Boyd
2019-01-18 22:31     ` Stephen Boyd
2019-01-22 22:40     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 6/8] phy: qcom-qmp: Utilize UFS reset controller Evan Green
2019-01-18 22:33   ` Stephen Boyd
2019-01-22 22:41     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 7/8] phy: qcom-qmp: Move UFS phy to phy_poweron/off Evan Green
2019-01-18 22:39   ` Stephen Boyd
2019-01-22 22:42     ` Evan Green
2019-01-11 23:01 ` [PATCH v1 8/8] phy: qcom-ufs: Refactor all init steps into phy_poweron Evan Green
2019-01-18 23:50   ` Stephen Boyd
2019-01-22 22:44     ` Evan Green
2019-01-16 22:32 ` [PATCH v1 0/8] phy: qcom-ufs: Enable regulators to be off in suspend Stephen Boyd
2019-01-16 22:32   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1imyoqaq0.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=andy.gross@linaro.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=dianders@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=jejb@linux.ibm.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.