All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Haber <mh+netdev@zugschlus.de>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19
Date: Wed, 30 Jan 2019 09:46:47 +0100	[thread overview]
Message-ID: <20190130084647.GM27062@torres.zugschlus.de> (raw)
In-Reply-To: <1f40f95a-f595-45f5-5641-9eb4837da71e@gmail.com>

On Tue, Jan 29, 2019 at 08:01:14PM +0100, Heiner Kallweit wrote:
> the change to replace __rtl8169_set_wol(tp, 0) doesn't seem to be the right commit
> because it was included in 4.18 already. And if you read the commit description you'll
> see that it was replaced because it caused issues with certain boards. Having said that
> it's not an option for us.

:-(

> Can you in addition apply the following (again it may not apply cleanly) and provide
> the results for 4.18 and 4.19?

In addition to the debug output? Can I do that together with the other
patch you sent yesterday or does that need to be two different tests?

> And from today's run, can you provide the full dmesg output? I'd like to check
> why the message was written on resume only.

I guess that it just didn't find its way to syslog before resume and got
stuck in some buffer during suspend.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

  reply	other threads:[~2019-01-30  8:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 20:08 WoL broken in r8169.c since kernel 4.19 Marc Haber
2019-01-12 20:28 ` Heiner Kallweit
2019-01-12 20:44   ` Heiner Kallweit
2019-01-13 16:01   ` Marc Haber
2019-01-13 16:19     ` Heiner Kallweit
2019-01-22 16:10       ` Marc Haber
2019-01-22 18:47         ` Heiner Kallweit
2019-01-25  5:59           ` Marc Haber
2019-01-25  6:49             ` Heiner Kallweit
2019-01-25 12:02               ` Marc Haber
2019-01-25 18:22                 ` Heiner Kallweit
2019-01-26 13:56                   ` Marc Haber
2019-01-26 14:04                     ` Heiner Kallweit
2019-01-26 17:07                       ` Marc Haber
2019-01-26 19:22                         ` Heiner Kallweit
2019-01-27 20:55                           ` Marc Haber
2019-01-27 21:09                             ` Heiner Kallweit
2019-01-28  7:30                               ` Marc Haber
2019-01-28 19:02                                 ` Heiner Kallweit
2019-01-28 20:59                                   ` Marc Haber
2019-01-28 21:21                                     ` Heiner Kallweit
2019-01-29 11:52                                       ` Marc Haber
2019-01-28 20:22                                 ` Marc Haber
2019-01-28 20:28                                   ` Heiner Kallweit
2019-01-29  7:32                                     ` Marc Haber
2019-01-29 15:35                                       ` Marc Haber
2019-01-29 19:01                                         ` Heiner Kallweit
2019-01-30  8:46                                           ` Marc Haber [this message]
2019-01-29 21:20                                         ` Heiner Kallweit
2019-01-30 15:37                                           ` Marc Haber
2019-02-01  6:49                                             ` Heiner Kallweit
2019-02-01 17:19                                               ` Marc Haber
2019-02-01 18:24                                                 ` Heiner Kallweit
2019-02-01 18:41                                                   ` Marc Haber
2019-01-26 14:08     ` Heiner Kallweit
2019-01-26 14:09       ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130084647.GM27062@torres.zugschlus.de \
    --to=mh+netdev@zugschlus.de \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.