From: Heiner Kallweit <hkallweit1@gmail.com>
To: Marc Haber <mh+netdev@zugschlus.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19
Date: Sun, 27 Jan 2019 22:09:51 +0100 [thread overview]
Message-ID: <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com> (raw)
In-Reply-To: <20190127205555.GF27062@torres.zugschlus.de>
On 27.01.2019 21:55, Marc Haber wrote:
> On Sat, Jan 26, 2019 at 08:22:33PM +0100, Heiner Kallweit wrote:
>> You could go with this range:
>> from 4ff364662814 ("r8169: replace get_protocol with vlan_get_protocol")
>> to 649f0837a8cc ("r8169: fix broken Wake-on-LAN from S5 (poweroff)")
>
> I am quite inexperienced with bisecting and am therefore giving a better
> account of my actions here.
>
> [2/4994]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git pull
> remote: Counting objects: 786, done.
> remote: Compressing objects: 100% (197/197), done.
> remote: Total 786 (delta 659), reused 697 (delta 589)
> Receiving objects: 100% (786/786), 146.00 KiB | 1.20 MiB/s, done.
> Resolving deltas: 100% (659/659), completed with 237 local objects.
>>From git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
> ba6069759381..1fc7f56db7a7 master -> origin/master
> You are not currently on a branch.
> 1 [3/4995]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git checkout 4ff364662814
> Checking out files: 100% (13994/13994), done.
> Previous HEAD position was 6b3252287aa2 Linux 4.18.16
> HEAD is now at 4ff364662814 r8169: replace get_protocol with vlan_get_protocol
> [4/4996]mh@fan:~/linux/git/linux ((4ff364662814...) %) $ git bisect start drivers/net/ethernet/realtek/r8169.c
> [5/4997]mh@fan:~/linux/git/linux ((4ff364662814...) %|BISECTING) $
> (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try)
> this boots and wakes up on magic packet from suspend to ram
> [2/4994]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git bisect good
> [3/4995]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git checkout 649f0837a8cc
> Checking out files: 100% (21794/21794), done.
> M scripts/package/Makefile
> Previous HEAD position was 4ff364662814 r8169: replace get_protocol with vlan_get_protocol
> HEAD is now at 649f0837a8cc r8169: fix broken Wake-on-LAN from S5 (poweroff)
> [4/4996]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $
> (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try)
> this boots and does not wake up from StR on magic packet, after
> waking up with any key on the keyboard I had an amdgpu issue on the console
> and a dead console, but was able to ssh in and reboot.
>
> [2/4994]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ git
> bisect bad
> Bisecting: 33 revisions left to test after this (roughly 5 steps)
> [098b01ad9837b4d4d0022f407300f069a999e55a] r8169: don't include asm
> headers directly
> [3/4995]mh@fan:~/linux/git/linux ((098b01ad9837...) *%|BISECTING) $
>
> I think I am on the right way here, am I?
>
> Greetings
> Marc
>
Yes. All you have to do after each "git bisect good/bad" is build again,
test, and make current build as good or bad.
next prev parent reply other threads:[~2019-01-27 21:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:08 WoL broken in r8169.c since kernel 4.19 Marc Haber
2019-01-12 20:28 ` Heiner Kallweit
2019-01-12 20:44 ` Heiner Kallweit
2019-01-13 16:01 ` Marc Haber
2019-01-13 16:19 ` Heiner Kallweit
2019-01-22 16:10 ` Marc Haber
2019-01-22 18:47 ` Heiner Kallweit
2019-01-25 5:59 ` Marc Haber
2019-01-25 6:49 ` Heiner Kallweit
2019-01-25 12:02 ` Marc Haber
2019-01-25 18:22 ` Heiner Kallweit
2019-01-26 13:56 ` Marc Haber
2019-01-26 14:04 ` Heiner Kallweit
2019-01-26 17:07 ` Marc Haber
2019-01-26 19:22 ` Heiner Kallweit
2019-01-27 20:55 ` Marc Haber
2019-01-27 21:09 ` Heiner Kallweit [this message]
2019-01-28 7:30 ` Marc Haber
2019-01-28 19:02 ` Heiner Kallweit
2019-01-28 20:59 ` Marc Haber
2019-01-28 21:21 ` Heiner Kallweit
2019-01-29 11:52 ` Marc Haber
2019-01-28 20:22 ` Marc Haber
2019-01-28 20:28 ` Heiner Kallweit
2019-01-29 7:32 ` Marc Haber
2019-01-29 15:35 ` Marc Haber
2019-01-29 19:01 ` Heiner Kallweit
2019-01-30 8:46 ` Marc Haber
2019-01-29 21:20 ` Heiner Kallweit
2019-01-30 15:37 ` Marc Haber
2019-02-01 6:49 ` Heiner Kallweit
2019-02-01 17:19 ` Marc Haber
2019-02-01 18:24 ` Heiner Kallweit
2019-02-01 18:41 ` Marc Haber
2019-01-26 14:08 ` Heiner Kallweit
2019-01-26 14:09 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=mh+netdev@zugschlus.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.