From: Heiner Kallweit <hkallweit1@gmail.com>
To: Marc Haber <mh+netdev@zugschlus.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19
Date: Fri, 1 Feb 2019 19:24:01 +0100 [thread overview]
Message-ID: <075de04d-4a5d-e557-aba6-7e569826a356@gmail.com> (raw)
In-Reply-To: <20190201171943.GA25308@torres.zugschlus.de>
It's too much effort to make the current r8169 compile under an older kernel.
But thanks anyway for trying!
Heiner
On 01.02.2019 18:19, Marc Haber wrote:
> On Fri, Feb 01, 2019 at 07:49:09AM +0100, Heiner Kallweit wrote:
>> Great, thanks. This patch has been applied and is part of latest linux-next kernel already:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20190201
>> Would be much appreciated if you could build and test this kernel version.
>
> I regret that I have not been able to get this through the compiler.
> When I clone the linux-next repo and try to build with deb-pkg, some
> process chokes on the weird version number of the linux-next kernel, and
> transplanting the r8169.c from linux-next on to 4.20.6, compile aborts:
>
> In file included from drivers/net/ethernet/realtek/r8169.c:13:
> ./include/linux/pci.h:830:12: error: ‘PCI_VENDOR_ID_USR’ undeclared here (not in a function); did you mean ‘PCI_VENDOR_ID_UMC’?
> .vendor = PCI_VENDOR_ID_##vend, .device = (dev), \
> ^~~~~~~~~~~~~~
> drivers/net/ethernet/realtek/r8169.c:222:4: note: in expansion of macro ‘PCI_VDEVICE’
> { PCI_VDEVICE(USR, 0x0116), RTL_CFG_0 },
> ^~~~~~~~~~~
> drivers/net/ethernet/realtek/r8169.c: In function ‘rtl8169_start_xmit’:
> drivers/net/ethernet/realtek/r8169.c:6261:6: error: implicit declaration of function ‘__netdev_sent_queue’; did you mean ‘netdev_sent_queue’? [-Werror=implicit-function-declaration]
> if (__netdev_sent_queue(dev, skb->len, skb->xmit_more))
> ^~~~~~~~~~~~~~~~~~~
> netdev_sent_queue
> drivers/net/ethernet/realtek/r8169.c: In function ‘r8169_phy_connect’:
> drivers/net/ethernet/realtek/r8169.c:6653:22: warning: passing argument 1 of ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion]
> linkmode_copy(phydev->advertising, phydev->supported);
> ~~~~~~^~~~~~~~~~~~~
> In file included from ./include/linux/phy.h:22,
> from drivers/net/ethernet/realtek/r8169.c:19:
> ./include/linux/linkmode.h:13:49: note: expected ‘long unsigned int *’ but argument is of type ‘u32’ {aka ‘unsigned int’}
> static inline void linkmode_copy(unsigned long *dst, const unsigned long *src)
> ~~~~~~~~~~~~~~~^~~
> drivers/net/ethernet/realtek/r8169.c:6653:43: warning: passing argument 2 of ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion]
> linkmode_copy(phydev->advertising, phydev->supported);
> ~~~~~~^~~~~~~~~~~
> In file included from ./include/linux/phy.h:22,
> from drivers/net/ethernet/realtek/r8169.c:19:
> ./include/linux/linkmode.h:13:75: note: expected ‘const long unsigned int *’ but argument is of type ‘u32’ {aka ‘unsigned int’}
> static inline void linkmode_copy(unsigned long *dst, const unsigned long *src)
> ~~~~~~~~~~~~~~~~~~~~~^~~
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:297: drivers/net/ethernet/realtek/r8169.o] Error 1
>
> Will it help if I transplant more files from linux-next to 4.20.6?
>
> Greetings
> Marc
>
next prev parent reply other threads:[~2019-02-01 18:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:08 WoL broken in r8169.c since kernel 4.19 Marc Haber
2019-01-12 20:28 ` Heiner Kallweit
2019-01-12 20:44 ` Heiner Kallweit
2019-01-13 16:01 ` Marc Haber
2019-01-13 16:19 ` Heiner Kallweit
2019-01-22 16:10 ` Marc Haber
2019-01-22 18:47 ` Heiner Kallweit
2019-01-25 5:59 ` Marc Haber
2019-01-25 6:49 ` Heiner Kallweit
2019-01-25 12:02 ` Marc Haber
2019-01-25 18:22 ` Heiner Kallweit
2019-01-26 13:56 ` Marc Haber
2019-01-26 14:04 ` Heiner Kallweit
2019-01-26 17:07 ` Marc Haber
2019-01-26 19:22 ` Heiner Kallweit
2019-01-27 20:55 ` Marc Haber
2019-01-27 21:09 ` Heiner Kallweit
2019-01-28 7:30 ` Marc Haber
2019-01-28 19:02 ` Heiner Kallweit
2019-01-28 20:59 ` Marc Haber
2019-01-28 21:21 ` Heiner Kallweit
2019-01-29 11:52 ` Marc Haber
2019-01-28 20:22 ` Marc Haber
2019-01-28 20:28 ` Heiner Kallweit
2019-01-29 7:32 ` Marc Haber
2019-01-29 15:35 ` Marc Haber
2019-01-29 19:01 ` Heiner Kallweit
2019-01-30 8:46 ` Marc Haber
2019-01-29 21:20 ` Heiner Kallweit
2019-01-30 15:37 ` Marc Haber
2019-02-01 6:49 ` Heiner Kallweit
2019-02-01 17:19 ` Marc Haber
2019-02-01 18:24 ` Heiner Kallweit [this message]
2019-02-01 18:41 ` Marc Haber
2019-01-26 14:08 ` Heiner Kallweit
2019-01-26 14:09 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075de04d-4a5d-e557-aba6-7e569826a356@gmail.com \
--to=hkallweit1@gmail.com \
--cc=mh+netdev@zugschlus.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.