From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
xen-devel@lists.xenproject.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] xen-block: handle resize callback
Date: Thu, 31 Jan 2019 15:20:42 +0000 [thread overview]
Message-ID: <20190131152042.GF2306@perard.uk.xensource.com> (raw)
In-Reply-To: <20190130161948.15888-1-paul.durrant@citrix.com>
On Wed, Jan 30, 2019 at 04:19:48PM +0000, Paul Durrant wrote:
> Some frontend drivers will handle dynamic resizing of PV disks, so set up
> the BlockDevOps resize_cb() method during xen_block_realize() to allow
> this to be done.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> + /*
> + * Mimic the behaviour of Linux xen-blkback and re-write the state
> + * to trigger the frontend watch.
> + */
> + xen_device_backend_set_state(xendev, backend_state);
:(, that function doesn't write the state again if it hasn't changed.
So in my testing, Linux never did anything.
--
Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen-block: handle resize callback
Date: Thu, 31 Jan 2019 15:20:42 +0000 [thread overview]
Message-ID: <20190131152042.GF2306@perard.uk.xensource.com> (raw)
In-Reply-To: <20190130161948.15888-1-paul.durrant@citrix.com>
On Wed, Jan 30, 2019 at 04:19:48PM +0000, Paul Durrant wrote:
> Some frontend drivers will handle dynamic resizing of PV disks, so set up
> the BlockDevOps resize_cb() method during xen_block_realize() to allow
> this to be done.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> + /*
> + * Mimic the behaviour of Linux xen-blkback and re-write the state
> + * to trigger the frontend watch.
> + */
> + xen_device_backend_set_state(xendev, backend_state);
:(, that function doesn't write the state again if it hasn't changed.
So in my testing, Linux never did anything.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-31 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:19 [Qemu-devel] [PATCH v2] xen-block: handle resize callback Paul Durrant
2019-01-31 15:20 ` Anthony PERARD [this message]
2019-01-31 15:20 ` Anthony PERARD
2019-01-31 15:22 ` Paul Durrant
2019-01-31 15:22 ` [Qemu-devel] " Paul Durrant
2019-01-31 15:25 ` Anthony PERARD
2019-01-31 15:25 ` Anthony PERARD
2019-01-31 15:26 ` [Qemu-devel] " Paul Durrant
2019-01-31 15:26 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131152042.GF2306@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.