* [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h
@ 2019-02-04 21:04 Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 21:04 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: qemu-ppc, Artyom Tarasenko, Hervé Poussineau, Guan Xuetao,
David Gibson, Mark Cave-Ayland, Philippe Mathieu-Daudé
Since 47973a2dbf, it is useless to include "hw/i386/pc.h"
on the ppc/unicore32/sparc64 boards.
The last non-x86 targets still requiring it are alpha/hppa/mips,
because the I8259 intc is still deeply mixed with the PC board.
Philippe Mathieu-Daudé (3):
hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"
hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"
hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"
hw/ppc/prep.c | 1 -
hw/sparc64/sun4u.c | 1 -
hw/unicore32/puv3.c | 1 -
3 files changed, 3 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h Philippe Mathieu-Daudé
@ 2019-02-04 21:04 ` Philippe Mathieu-Daudé
2019-02-05 9:41 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
` (2 more replies)
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 3/3] hw/ppc/prep: " Philippe Mathieu-Daudé
2 siblings, 3 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 21:04 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: qemu-ppc, Artyom Tarasenko, Hervé Poussineau, Guan Xuetao,
David Gibson, Mark Cave-Ayland, Philippe Mathieu-Daudé
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/sparc64/sun4u.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index f76b19e4e9..fdf3f14a29 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -33,7 +33,6 @@
#include "hw/pci/pci_bus.h"
#include "hw/pci/pci_host.h"
#include "hw/pci-host/sabre.h"
-#include "hw/i386/pc.h"
#include "hw/char/serial.h"
#include "hw/char/parallel.h"
#include "hw/timer/m48t59.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
@ 2019-02-04 21:04 ` Philippe Mathieu-Daudé
2019-02-05 9:42 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-02-06 14:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-04 21:04 ` [Qemu-devel] [PATCH 3/3] hw/ppc/prep: " Philippe Mathieu-Daudé
2 siblings, 2 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 21:04 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: qemu-ppc, Artyom Tarasenko, Hervé Poussineau, Guan Xuetao,
David Gibson, Mark Cave-Ayland, Philippe Mathieu-Daudé
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/unicore32/puv3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
index 830fe3face..b42e600f74 100644
--- a/hw/unicore32/puv3.c
+++ b/hw/unicore32/puv3.c
@@ -15,7 +15,6 @@
#include "ui/console.h"
#include "hw/boards.h"
#include "hw/loader.h"
-#include "hw/i386/pc.h"
#include "sysemu/qtest.h"
#undef DEBUG_PUV3
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH 3/3] hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
@ 2019-02-04 21:04 ` Philippe Mathieu-Daudé
2019-02-04 21:11 ` Hervé Poussineau
2 siblings, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 21:04 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: qemu-ppc, Artyom Tarasenko, Hervé Poussineau, Guan Xuetao,
David Gibson, Mark Cave-Ayland, Philippe Mathieu-Daudé
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/ppc/prep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 7bda86a7d0..847d320465 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -26,7 +26,6 @@
#include "cpu.h"
#include "hw/hw.h"
#include "hw/timer/m48t59.h"
-#include "hw/i386/pc.h"
#include "hw/char/serial.h"
#include "hw/block/fdc.h"
#include "net/net.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 3/3] hw/ppc/prep: " Philippe Mathieu-Daudé
@ 2019-02-04 21:11 ` Hervé Poussineau
2019-02-05 2:25 ` David Gibson
0 siblings, 1 reply; 11+ messages in thread
From: Hervé Poussineau @ 2019-02-04 21:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
Cc: qemu-ppc, Artyom Tarasenko, Guan Xuetao, David Gibson, Mark Cave-Ayland
Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit :
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:11 ` Hervé Poussineau
@ 2019-02-05 2:25 ` David Gibson
0 siblings, 0 replies; 11+ messages in thread
From: David Gibson @ 2019-02-05 2:25 UTC (permalink / raw)
To: Hervé Poussineau
Cc: Philippe Mathieu-Daudé,
qemu-devel, qemu-trivial, qemu-ppc, Artyom Tarasenko,
Guan Xuetao, Mark Cave-Ayland
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
On Mon, Feb 04, 2019 at 10:11:07PM +0100, Hervé Poussineau wrote:
> Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit :
> > In 47973a2dbf we split the last generic chipset out of the PC
> > board, but forgot to remove the include of "hw/i386/pc.h".
> > Since it is now unused, remove it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Applied to ppc-for-4.0, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
@ 2019-02-05 9:41 ` Thomas Huth
2019-02-05 17:12 ` [Qemu-devel] " Mark Cave-Ayland
2019-02-06 14:53 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 11+ messages in thread
From: Thomas Huth @ 2019-02-05 9:41 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
Cc: Hervé Poussineau, qemu-ppc, Artyom Tarasenko, Mark Cave-Ayland
On 2019-02-04 22:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/sparc64/sun4u.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index f76b19e4e9..fdf3f14a29 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -33,7 +33,6 @@
> #include "hw/pci/pci_bus.h"
> #include "hw/pci/pci_host.h"
> #include "hw/pci-host/sabre.h"
> -#include "hw/i386/pc.h"
> #include "hw/char/serial.h"
> #include "hw/char/parallel.h"
> #include "hw/timer/m48t59.h"
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
@ 2019-02-05 9:42 ` Thomas Huth
2019-02-06 14:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Huth @ 2019-02-05 9:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial; +Cc: Guan Xuetao
On 2019-02-04 22:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/unicore32/puv3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
> index 830fe3face..b42e600f74 100644
> --- a/hw/unicore32/puv3.c
> +++ b/hw/unicore32/puv3.c
> @@ -15,7 +15,6 @@
> #include "ui/console.h"
> #include "hw/boards.h"
> #include "hw/loader.h"
> -#include "hw/i386/pc.h"
> #include "sysemu/qtest.h"
>
> #undef DEBUG_PUV3
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
2019-02-05 9:41 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2019-02-05 17:12 ` Mark Cave-Ayland
2019-02-06 14:53 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 11+ messages in thread
From: Mark Cave-Ayland @ 2019-02-05 17:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
Cc: Hervé Poussineau, qemu-ppc, Guan Xuetao, Artyom Tarasenko,
David Gibson
On 04/02/2019 21:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/sparc64/sun4u.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index f76b19e4e9..fdf3f14a29 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -33,7 +33,6 @@
> #include "hw/pci/pci_bus.h"
> #include "hw/pci/pci_host.h"
> #include "hw/pci-host/sabre.h"
> -#include "hw/i386/pc.h"
> #include "hw/char/serial.h"
> #include "hw/char/parallel.h"
> #include "hw/timer/m48t59.h"
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
2019-02-05 9:41 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-02-05 17:12 ` [Qemu-devel] " Mark Cave-Ayland
@ 2019-02-06 14:53 ` Laurent Vivier
2 siblings, 0 replies; 11+ messages in thread
From: Laurent Vivier @ 2019-02-06 14:53 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
Cc: Mark Cave-Ayland, Hervé Poussineau, qemu-ppc, Guan Xuetao,
Artyom Tarasenko, David Gibson
On 04/02/2019 22:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/sparc64/sun4u.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index f76b19e4e9..fdf3f14a29 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -33,7 +33,6 @@
> #include "hw/pci/pci_bus.h"
> #include "hw/pci/pci_host.h"
> #include "hw/pci-host/sabre.h"
> -#include "hw/i386/pc.h"
> #include "hw/char/serial.h"
> #include "hw/char/parallel.h"
> #include "hw/timer/m48t59.h"
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
2019-02-05 9:42 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2019-02-06 14:54 ` Laurent Vivier
1 sibling, 0 replies; 11+ messages in thread
From: Laurent Vivier @ 2019-02-06 14:54 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
Cc: Mark Cave-Ayland, Hervé Poussineau, qemu-ppc, Guan Xuetao,
Artyom Tarasenko, David Gibson
On 04/02/2019 22:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/unicore32/puv3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
> index 830fe3face..b42e600f74 100644
> --- a/hw/unicore32/puv3.c
> +++ b/hw/unicore32/puv3.c
> @@ -15,7 +15,6 @@
> #include "ui/console.h"
> #include "hw/boards.h"
> #include "hw/loader.h"
> -#include "hw/i386/pc.h"
> #include "sysemu/qtest.h"
>
> #undef DEBUG_PUV3
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-02-06 14:54 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 21:04 [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
2019-02-05 9:41 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-02-05 17:12 ` [Qemu-devel] " Mark Cave-Ayland
2019-02-06 14:53 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
2019-02-05 9:42 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-02-06 14:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-04 21:04 ` [Qemu-devel] [PATCH 3/3] hw/ppc/prep: " Philippe Mathieu-Daudé
2019-02-04 21:11 ` Hervé Poussineau
2019-02-05 2:25 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.