From: Torsten Duwe <duwe@lst.de> To: Vasily Khoruzhick <anarsoul@gmail.com> Cc: Icenowy Zheng <icenowy@aosc.io>, devicetree <devicetree@vger.kernel.org>, Archit Taneja <architt@codeaurora.org>, Andrzej Hajda <a.hajda@samsung.com>, David Airlie <airlied@linux.ie>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, Thierry Reding <thierry.reding@gmail.com>, Sean Paul <seanpaul@chromium.org>, arm-linux <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Date: Tue, 5 Feb 2019 14:19:02 +0100 [thread overview] Message-ID: <20190205131902.GA7432@lst.de> (raw) In-Reply-To: <20190203185501.8958-6-anarsoul@gmail.com> First thing that struck me is that the chip's reset is actually low active reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ ^^^^ (please correct this in patches 11 and 12) Consequently, you're using inverted values here in the driver: > +static void anx6345_poweron(struct anx6345 *anx6345) > +{ [...] > + gpiod_set_value_cansleep(pdata->gpiod_reset, 0); 0 = reset on, ok. > + usleep_range(1000, 2000); > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); 1 = reset off, also fine. > + > + /* Power on registers module */ > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > + anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_REGISTER_PD | SP_TOTAL_PD); > + > + anx6345->powered = true; > +} > + > +static void anx6345_poweroff(struct anx6345 *anx6345) > +{ > + struct anx6345_platform_data *pdata = &anx6345->pdata; > + int err; > + > + if (WARN_ON(!anx6345->powered)) > + return; > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); > + usleep_range(1000, 2000); This one got me a bit confused. Assert or deassert reset (again) before poweroff? Please stick to the logical value of the reset line. Torsten
WARNING: multiple messages have this Message-ID (diff)
From: Torsten Duwe <duwe@lst.de> To: Vasily Khoruzhick <anarsoul@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, Archit Taneja <architt@codeaurora.org>, David Airlie <airlied@linux.ie>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Daniel Vetter <daniel@ffwll.ch>, Maxime Ripard <maxime.ripard@bootlin.com>, Sean Paul <seanpaul@chromium.org>, arm-linux <linux-arm-kernel@lists.infradead.org>, Icenowy Zheng <icenowy@aosc.io> Subject: Re: [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Date: Tue, 5 Feb 2019 14:19:02 +0100 [thread overview] Message-ID: <20190205131902.GA7432@lst.de> (raw) In-Reply-To: <20190203185501.8958-6-anarsoul@gmail.com> First thing that struck me is that the chip's reset is actually low active reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ ^^^^ (please correct this in patches 11 and 12) Consequently, you're using inverted values here in the driver: > +static void anx6345_poweron(struct anx6345 *anx6345) > +{ [...] > + gpiod_set_value_cansleep(pdata->gpiod_reset, 0); 0 = reset on, ok. > + usleep_range(1000, 2000); > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); 1 = reset off, also fine. > + > + /* Power on registers module */ > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > + anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_REGISTER_PD | SP_TOTAL_PD); > + > + anx6345->powered = true; > +} > + > +static void anx6345_poweroff(struct anx6345 *anx6345) > +{ > + struct anx6345_platform_data *pdata = &anx6345->pdata; > + int err; > + > + if (WARN_ON(!anx6345->powered)) > + return; > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); > + usleep_range(1000, 2000); This one got me a bit confused. Assert or deassert reset (again) before poweroff? Please stick to the logical value of the reset line. Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-05 13:19 UTC|newest] Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-03 18:54 [PATCH RESEND v2 00/12] Analogix ANX6345 RGB-(e)DP bridge support Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick [not found] ` <20190203185501.8958-1-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2019-02-03 18:54 ` [PATCH RESEND v2 01/12] drm/bridge: move ANA78xx driver to analogix subdirectory Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 02/12] drm/bridge: split some definitions of ANX78xx to dedicated headers Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 03/12] drm/bridge: extract some Analogix I2C DP common code Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 04/12] dt-bindings: Add ANX6345 DP/eDP transmitter binding Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-05 13:19 ` Torsten Duwe [this message] 2019-02-05 13:19 ` Torsten Duwe 2019-02-03 18:54 ` [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick [not found] ` <20190203185501.8958-7-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2019-02-04 14:20 ` Maxime Ripard 2019-02-04 14:20 ` Maxime Ripard 2019-02-04 16:26 ` Vasily Khoruzhick 2019-02-04 16:26 ` Vasily Khoruzhick [not found] ` <CA+E=qVfTfJ9E29gz83tdVGx5_KGWSQVJOAxKTzC+-n7=gdj0cA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 16:28 ` Icenowy Zheng 2019-02-04 16:28 ` Icenowy Zheng [not found] ` <0F6CBEA4-6DB6-40F1-A2FD-65101AF64F1F-h8G6r0blFSE@public.gmane.org> 2019-02-04 18:50 ` Vasily Khoruzhick 2019-02-04 18:50 ` [linux-sunxi] " Vasily Khoruzhick [not found] ` <CA+E=qVd7yh=JNZSvrfY4Diu+VJWFK6yLUJ5MavBcZ8Cftn6f-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-05 15:41 ` Maxime Ripard 2019-02-05 15:41 ` [linux-sunxi] " Maxime Ripard 2019-02-05 17:49 ` Vasily Khoruzhick 2019-02-05 17:49 ` [linux-sunxi] " Vasily Khoruzhick 2019-02-06 9:16 ` Maxime Ripard 2019-02-06 9:16 ` Maxime Ripard 2019-02-06 11:42 ` Thierry Reding 2019-02-06 11:42 ` Thierry Reding 2019-02-03 18:54 ` [PATCH RESEND v2 07/12] drm/panel: simple: don't fail if we don't have panel desc Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick [not found] ` <20190203185501.8958-9-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2019-02-04 7:43 ` Thierry Reding 2019-02-04 7:43 ` Thierry Reding 2019-02-04 8:13 ` Vasily Khoruzhick 2019-02-04 8:13 ` Vasily Khoruzhick [not found] ` <CA+E=qVecudACOEXt74Kf=UA_F-uuHgEqHzKpYAq1ocMx3Sx+eQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 8:23 ` Thierry Reding 2019-02-04 8:23 ` Thierry Reding 2019-02-04 9:40 ` Daniel Vetter 2019-02-04 9:40 ` Daniel Vetter [not found] ` <20190204094012.GP3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2019-02-04 11:22 ` Thierry Reding 2019-02-04 11:22 ` Thierry Reding 2019-02-04 15:59 ` Daniel Vetter 2019-02-04 15:59 ` Daniel Vetter [not found] ` <20190204155909.GU3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2019-02-04 16:22 ` Thierry Reding 2019-02-04 16:22 ` Thierry Reding 2019-02-05 8:57 ` Daniel Vetter 2019-02-05 8:57 ` Daniel Vetter 2019-02-05 10:24 ` Thierry Reding 2019-02-05 10:24 ` Thierry Reding 2019-02-05 16:36 ` Daniel Vetter 2019-02-05 16:36 ` Daniel Vetter [not found] ` <20190205163649.GG3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2019-02-14 19:51 ` Vasily Khoruzhick 2019-02-14 19:51 ` Vasily Khoruzhick 2019-02-14 20:05 ` Vasily Khoruzhick 2019-02-14 20:05 ` Vasily Khoruzhick [not found] ` <CA+E=qVcUsz=5s1+RqDdQ4Hm3_Q3jDFuZwuYXUuVx3ubFWmcG7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-14 20:38 ` Rob Herring 2019-02-14 20:38 ` Rob Herring [not found] ` <CAL_JsqKQ0EmyYGYvz__ZZGN7_6jLezevHWc+psn82Uy6hWZXMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-14 20:54 ` Vasily Khoruzhick 2019-02-14 20:54 ` Vasily Khoruzhick 2019-02-04 16:11 ` Vasily Khoruzhick 2019-02-04 16:11 ` Vasily Khoruzhick [not found] ` <CA+E=qVew+8__yrAud1gFnLQ8HCwDdGhVjV=c173HGvZxH=7zZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 16:27 ` Thierry Reding 2019-02-04 16:27 ` Thierry Reding 2019-02-04 16:39 ` Rob Herring 2019-02-04 16:39 ` Rob Herring [not found] ` <CAL_JsqLAODca_U94hCi9O3E6XiUjAYCoL7_0gkf_eMY0nnT8Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 17:02 ` Vasily Khoruzhick 2019-02-04 17:02 ` [linux-sunxi] " Vasily Khoruzhick 2019-02-04 16:27 ` Rob Herring 2019-02-04 16:27 ` Rob Herring [not found] ` <CAL_JsqKt1kOXmRNvkYsQ6AL69+TPZURKpDbKkkEUb2+KZ5hKjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 16:56 ` Thierry Reding 2019-02-04 16:56 ` Thierry Reding 2019-02-04 17:07 ` Vasily Khoruzhick 2019-02-04 17:07 ` Vasily Khoruzhick 2019-02-04 20:23 ` Rob Herring 2019-02-04 20:23 ` Rob Herring [not found] ` <CAL_JsqJx98DfHZSafiXA8QiO=bn1zy8g6keQ15L=cUmbVkTTOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-04 20:26 ` Vasily Khoruzhick 2019-02-04 20:26 ` Vasily Khoruzhick 2019-02-04 20:34 ` Rob Herring 2019-02-04 20:34 ` Rob Herring 2019-02-03 18:54 ` [PATCH RESEND v2 09/12] drm/panel: simple: add " Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:54 ` [PATCH RESEND v2 10/12] arm64: allwinner: a64: add pinmux for RGB666 LCD Vasily Khoruzhick 2019-02-03 18:54 ` Vasily Khoruzhick 2019-02-03 18:55 ` [PATCH RESEND v2 11/12] arm64: allwinner: a64: enable LCD-related hardware for Pinebook Vasily Khoruzhick 2019-02-03 18:55 ` Vasily Khoruzhick 2019-02-03 18:55 ` [PATCH RESEND v2 12/12] arm64: allwinner: a64: enable LCD-related hardware for TERES-I Vasily Khoruzhick 2019-02-03 18:55 ` Vasily Khoruzhick -- strict thread matches above, loose matches on Subject: below -- 2018-10-18 7:33 [PATCH 0/9] Analogix ANX6345 RGB-(e)DP bridge support Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 1/9] drm/bridge: move ANA78xx driver to analogix subdirectory Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 8:47 ` Laurent Pinchart 2018-10-18 8:47 ` Laurent Pinchart 2018-10-18 8:47 ` Laurent Pinchart 2018-10-18 7:33 ` [PATCH 2/9] drm/bridge: split some definitions of ANX78xx to dedicated headers Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 3/9] drm/bridge: extract some Analogix I2C DP common code Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 8:53 ` Laurent Pinchart 2018-10-18 8:53 ` Laurent Pinchart 2018-10-18 8:53 ` Laurent Pinchart 2018-10-18 10:00 ` Icenowy Zheng 2018-10-18 10:00 ` Icenowy Zheng 2018-10-18 11:23 ` Laurent Pinchart 2018-10-18 11:23 ` Laurent Pinchart 2018-10-18 11:23 ` Laurent Pinchart 2018-10-18 12:40 ` Icenowy Zheng 2018-10-18 12:40 ` Icenowy Zheng 2018-10-25 18:30 ` Rob Herring 2018-10-25 18:30 ` Rob Herring 2018-10-25 18:30 ` Rob Herring 2018-10-26 0:08 ` Icenowy Zheng 2018-10-26 0:08 ` Icenowy Zheng 2018-10-26 0:08 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 5/9] drm/bridge: Add Analogix anx6345 support Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 6/9] arm64: allwinner: a64: add pinmux for RGB666 LCD Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 7/9] arm64: allwinner: a64: enable ANX6345 bridge on Pinebook Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 15:17 ` Vasily Khoruzhick 2018-10-18 15:17 ` Vasily Khoruzhick 2018-10-19 5:50 ` Icenowy Zheng 2018-10-19 5:50 ` Icenowy Zheng 2018-10-19 5:50 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 8/9] arm64: allwinner: a64: enable ANX6345 bridge on TERES-I Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 7:33 ` Icenowy Zheng 2018-10-18 8:55 ` Laurent Pinchart 2018-10-18 8:55 ` Laurent Pinchart 2018-10-18 8:55 ` Laurent Pinchart 2018-10-18 9:18 ` Daniel Vetter 2018-10-18 9:18 ` Daniel Vetter 2018-10-18 9:42 ` Maxime Ripard 2018-10-18 9:42 ` Maxime Ripard 2018-10-18 9:42 ` Maxime Ripard 2018-10-18 11:31 ` Laurent Pinchart 2018-10-18 11:31 ` Laurent Pinchart 2018-10-18 11:31 ` Laurent Pinchart 2018-10-18 12:18 ` Maxime Ripard 2018-10-18 12:18 ` Maxime Ripard 2018-10-18 12:18 ` Maxime Ripard 2018-10-18 12:50 ` Icenowy Zheng 2018-10-18 12:50 ` Icenowy Zheng 2018-10-18 12:50 ` Icenowy Zheng 2018-10-18 13:07 ` Maxime Ripard 2018-10-18 13:07 ` Maxime Ripard 2018-10-18 13:07 ` Maxime Ripard 2018-10-18 13:57 ` Laurent Pinchart 2018-10-18 13:57 ` Laurent Pinchart 2018-10-18 13:57 ` Laurent Pinchart 2019-02-03 1:32 ` Vasily Khoruzhick 2019-02-03 1:32 ` Vasily Khoruzhick 2019-02-03 1:32 ` Vasily Khoruzhick 2018-10-18 12:25 ` Stefan Monnier 2018-10-29 2:20 ` [PATCH 0/9] Analogix ANX6345 RGB-(e)DP bridge support Vasily Khoruzhick 2018-10-29 2:20 ` Vasily Khoruzhick 2019-02-04 12:22 ` Torsten Duwe 2019-02-04 12:22 ` Torsten Duwe 2019-02-04 20:21 ` Vasily Khoruzhick 2019-02-04 20:21 ` Vasily Khoruzhick 2019-02-04 20:21 ` Vasily Khoruzhick
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190205131902.GA7432@lst.de \ --to=duwe@lst.de \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=anarsoul@gmail.com \ --cc=architt@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=icenowy@aosc.io \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=seanpaul@chromium.org \ --cc=thierry.reding@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.