From: Yizhuo <yzhai003@ucr.edu> To: unlisted-recipients:; (no To-header on input) Cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Maxime Ripard <maxime.ripard@free-electrons.com>, Chen-Yu Tsai <wens@csie.org>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Date: Tue, 5 Feb 2019 14:15:59 -0800 [thread overview] Message-ID: <20190205221559.17545-1-yzhai003@ucr.edu> (raw) In function sun8i_dwmac_set_syscon(), local variable "val" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used directly in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo <yzhai003@ucr.edu> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 39c2122a4f26..11d481c9e7ab 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) struct sunxi_priv_data *gmac = priv->plat->bsp_priv; struct device_node *node = priv->device->of_node; int ret; - u32 reg, val; + u32 reg, val = 0; + + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); + if (ret) { + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); + return ret; + } - regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); reg = gmac->variant->default_syscon_value; if (reg != val) dev_warn(priv->device, -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Yizhuo <yzhai003@ucr.edu> Cc: csong@cs.ucr.edu, Alexandre Torgue <alexandre.torgue@st.com>, netdev@vger.kernel.org, zhiyunq@cs.ucr.edu, linux-kernel@vger.kernel.org, Yizhuo <yzhai003@ucr.edu>, Chen-Yu Tsai <wens@csie.org>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Maxime Ripard <maxime.ripard@free-electrons.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Date: Tue, 5 Feb 2019 14:15:59 -0800 [thread overview] Message-ID: <20190205221559.17545-1-yzhai003@ucr.edu> (raw) In function sun8i_dwmac_set_syscon(), local variable "val" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used directly in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo <yzhai003@ucr.edu> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 39c2122a4f26..11d481c9e7ab 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) struct sunxi_priv_data *gmac = priv->plat->bsp_priv; struct device_node *node = priv->device->of_node; int ret; - u32 reg, val; + u32 reg, val = 0; + + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); + if (ret) { + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); + return ret; + } - regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); reg = gmac->variant->default_syscon_value; if (reg != val) dev_warn(priv->device, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-02-05 22:16 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-05 22:15 Yizhuo [this message] 2019-02-05 22:15 ` [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Yizhuo 2019-02-06 9:18 ` Maxime Ripard 2019-02-06 9:18 ` Maxime Ripard 2019-02-07 4:17 ` David Miller 2019-02-07 4:17 ` David Miller [not found] ` <CABvMjLQ6MYtGYeLxwceZsvcyn4oScgMo+BGQMHw7SkZ1uxFmHQ@mail.gmail.com> 2019-02-07 5:53 ` Yizhuo Zhai 2019-02-07 5:53 ` Yizhuo Zhai 2019-02-07 9:24 ` Maxime Ripard 2019-02-07 9:24 ` Maxime Ripard 2019-02-07 17:48 ` Yizhuo Zhai 2019-02-07 17:48 ` Yizhuo Zhai 2019-02-07 17:53 ` David Miller 2019-02-07 17:53 ` David Miller 2019-02-07 17:46 Yizhuo 2019-02-07 17:46 ` Yizhuo 2019-02-08 7:44 ` Maxime Ripard 2019-02-08 7:44 ` Maxime Ripard 2019-02-09 7:01 ` David Miller 2019-02-09 7:01 ` David Miller 2019-08-30 22:29 ` Yizhuo Zhai 2019-08-30 22:29 ` Yizhuo Zhai 2019-08-31 0:37 ` David Miller 2019-08-31 0:37 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190205221559.17545-1-yzhai003@ucr.edu \ --to=yzhai003@ucr.edu \ --cc=alexandre.torgue@st.com \ --cc=csong@cs.ucr.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=wens@csie.org \ --cc=zhiyunq@cs.ucr.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.