From: David Miller <davem@davemloft.net>
To: yzhai003@ucr.edu
Cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, peppe.cavallaro@st.com,
alexandre.torgue@st.com, maxime.ripard@free-electrons.com,
wens@csie.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized
Date: Fri, 08 Feb 2019 23:01:17 -0800 (PST) [thread overview]
Message-ID: <20190208.230117.1867217574108955553.davem@davemloft.net> (raw)
In-Reply-To: <20190207174623.16712-1-yzhai003@ucr.edu>
From: Yizhuo <yzhai003@ucr.edu>
Date: Thu, 7 Feb 2019 09:46:23 -0800
> In function sun8i_dwmac_set_syscon(), local variable "val" could
> be uninitialized if function regmap_read() returns -EINVAL.
> However, it will be used directly in the if statement, which
> is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
This doesn't apply to any of my trees.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: yzhai003@ucr.edu
Cc: csong@cs.ucr.edu, alexandre.torgue@st.com,
netdev@vger.kernel.org, zhiyunq@cs.ucr.edu,
linux-kernel@vger.kernel.org, wens@csie.org,
peppe.cavallaro@st.com, maxime.ripard@free-electrons.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized
Date: Fri, 08 Feb 2019 23:01:17 -0800 (PST) [thread overview]
Message-ID: <20190208.230117.1867217574108955553.davem@davemloft.net> (raw)
In-Reply-To: <20190207174623.16712-1-yzhai003@ucr.edu>
From: Yizhuo <yzhai003@ucr.edu>
Date: Thu, 7 Feb 2019 09:46:23 -0800
> In function sun8i_dwmac_set_syscon(), local variable "val" could
> be uninitialized if function regmap_read() returns -EINVAL.
> However, it will be used directly in the if statement, which
> is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
This doesn't apply to any of my trees.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-09 7:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 17:46 [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Yizhuo
2019-02-07 17:46 ` Yizhuo
2019-02-08 7:44 ` Maxime Ripard
2019-02-08 7:44 ` Maxime Ripard
2019-02-09 7:01 ` David Miller [this message]
2019-02-09 7:01 ` David Miller
2019-08-30 22:29 ` Yizhuo Zhai
2019-08-30 22:29 ` Yizhuo Zhai
2019-08-31 0:37 ` David Miller
2019-08-31 0:37 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-02-05 22:15 Yizhuo
2019-02-05 22:15 ` Yizhuo
2019-02-06 9:18 ` Maxime Ripard
2019-02-06 9:18 ` Maxime Ripard
2019-02-07 4:17 ` David Miller
2019-02-07 4:17 ` David Miller
[not found] ` <CABvMjLQ6MYtGYeLxwceZsvcyn4oScgMo+BGQMHw7SkZ1uxFmHQ@mail.gmail.com>
2019-02-07 5:53 ` Yizhuo Zhai
2019-02-07 5:53 ` Yizhuo Zhai
2019-02-07 9:24 ` Maxime Ripard
2019-02-07 9:24 ` Maxime Ripard
2019-02-07 17:48 ` Yizhuo Zhai
2019-02-07 17:48 ` Yizhuo Zhai
2019-02-07 17:53 ` David Miller
2019-02-07 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208.230117.1867217574108955553.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=csong@cs.ucr.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wens@csie.org \
--cc=yzhai003@ucr.edu \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.