* [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
@ 2019-02-01 5:34 ` Surabhi Vishnoi
0 siblings, 0 replies; 8+ messages in thread
From: Surabhi Vishnoi @ 2019-02-01 5:34 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Surabhi Vishnoi
The firmware advertises the LDPC support information for HT in
HT capability info in the wmi service ready event. To provide
granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
capabilities.
Add a condition to existing logic in host to know whether firmware
supports LDPC or not.
Tested HW: WCN3990
Tested SW: WLAN.HL.2.0
Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
drivers/net/wireless/ath/ath10k/wmi.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index e49b367..1645b1e 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -4549,7 +4549,8 @@ static struct ieee80211_sta_ht_cap ath10k_get_ht_cap(struct ath10k *ar)
ht_cap.cap |= stbc;
}
- if (ar->ht_cap_info & WMI_HT_CAP_LDPC)
+ if (ar->ht_cap_info & WMI_HT_CAP_LDPC || (ar->ht_cap_info &
+ WMI_HT_CAP_RX_LDPC && (ar->ht_cap_info & WMI_HT_CAP_TX_LDPC)))
ht_cap.cap |= IEEE80211_HT_CAP_LDPC_CODING;
if (ar->ht_cap_info & WMI_HT_CAP_L_SIG_TXOP_PROT)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index 427ca79..0aca84e 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -2076,6 +2076,8 @@ enum wmi_channel_change_cause {
#define WMI_HT_CAP_MPDU_DENSITY 0x0700 /* MPDU Density */
#define WMI_HT_CAP_MPDU_DENSITY_MASK_SHIFT 8
#define WMI_HT_CAP_HT40_SGI 0x0800
+#define WMI_HT_CAP_RX_LDPC 0x1000 /* LDPC RX support */
+#define WMI_HT_CAP_TX_LDPC 0x2000 /* LDPC TX support */
#define WMI_HT_CAP_DEFAULT_ALL (WMI_HT_CAP_ENABLED | \
WMI_HT_CAP_HT20_SGI | \
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
@ 2019-02-01 5:34 ` Surabhi Vishnoi
0 siblings, 0 replies; 8+ messages in thread
From: Surabhi Vishnoi @ 2019-02-01 5:34 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Surabhi Vishnoi
The firmware advertises the LDPC support information for HT in
HT capability info in the wmi service ready event. To provide
granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
capabilities.
Add a condition to existing logic in host to know whether firmware
supports LDPC or not.
Tested HW: WCN3990
Tested SW: WLAN.HL.2.0
Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
drivers/net/wireless/ath/ath10k/wmi.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index e49b367..1645b1e 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -4549,7 +4549,8 @@ static struct ieee80211_sta_ht_cap ath10k_get_ht_cap(struct ath10k *ar)
ht_cap.cap |= stbc;
}
- if (ar->ht_cap_info & WMI_HT_CAP_LDPC)
+ if (ar->ht_cap_info & WMI_HT_CAP_LDPC || (ar->ht_cap_info &
+ WMI_HT_CAP_RX_LDPC && (ar->ht_cap_info & WMI_HT_CAP_TX_LDPC)))
ht_cap.cap |= IEEE80211_HT_CAP_LDPC_CODING;
if (ar->ht_cap_info & WMI_HT_CAP_L_SIG_TXOP_PROT)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index 427ca79..0aca84e 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -2076,6 +2076,8 @@ enum wmi_channel_change_cause {
#define WMI_HT_CAP_MPDU_DENSITY 0x0700 /* MPDU Density */
#define WMI_HT_CAP_MPDU_DENSITY_MASK_SHIFT 8
#define WMI_HT_CAP_HT40_SGI 0x0800
+#define WMI_HT_CAP_RX_LDPC 0x1000 /* LDPC RX support */
+#define WMI_HT_CAP_TX_LDPC 0x2000 /* LDPC TX support */
#define WMI_HT_CAP_DEFAULT_ALL (WMI_HT_CAP_ENABLED | \
WMI_HT_CAP_HT20_SGI | \
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
2019-02-01 5:34 ` Surabhi Vishnoi
@ 2019-02-04 15:32 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-04 15:32 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: ath10k, linux-wireless
Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
> The firmware advertises the LDPC support information for HT in
> HT capability info in the wmi service ready event. To provide
> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
> capabilities.
>
> Add a condition to existing logic in host to know whether firmware
> supports LDPC or not.
>
> Tested HW: WCN3990
> Tested SW: WLAN.HL.2.0
Can you give exact firmware version you tested, please? I'll add it to
the commit log.
I'll also fix the typo "condtion" in the title.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
@ 2019-02-04 15:32 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-04 15:32 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: linux-wireless, ath10k
Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
> The firmware advertises the LDPC support information for HT in
> HT capability info in the wmi service ready event. To provide
> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
> capabilities.
>
> Add a condition to existing logic in host to know whether firmware
> supports LDPC or not.
>
> Tested HW: WCN3990
> Tested SW: WLAN.HL.2.0
Can you give exact firmware version you tested, please? I'll add it to
the commit log.
I'll also fix the typo "condtion" in the title.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
[not found] ` <b14e2139c794201664a49d36cc28ab48@codeaurora.org>
@ 2019-02-07 9:10 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-07 9:10 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: linux-wireless, ath10k
+ lists
Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
> On 2019-02-04 21:02, Kalle Valo wrote:
>> Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
>>
>>> The firmware advertises the LDPC support information for HT in
>>> HT capability info in the wmi service ready event. To provide
>>> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
>>> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
>>> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
>>> capabilities.
>>>
>>> Add a condition to existing logic in host to know whether firmware
>>> supports LDPC or not.
>>>
>>> Tested HW: WCN3990
>>> Tested SW: WLAN.HL.2.0
>>
>> Can you give exact firmware version you tested, please? I'll add it to
>> the commit log.
>>
>> I'll also fix the typo "condtion" in the title.
>
>
> Hi Kalle,
>
> The Fw version tested are:
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,
> WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1
Thanks. But please do not drop the lists, otherwise patchwork won't see
this.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
@ 2019-02-07 9:10 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-07 9:10 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: linux-wireless, ath10k
+ lists
Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
> On 2019-02-04 21:02, Kalle Valo wrote:
>> Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
>>
>>> The firmware advertises the LDPC support information for HT in
>>> HT capability info in the wmi service ready event. To provide
>>> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
>>> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
>>> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
>>> capabilities.
>>>
>>> Add a condition to existing logic in host to know whether firmware
>>> supports LDPC or not.
>>>
>>> Tested HW: WCN3990
>>> Tested SW: WLAN.HL.2.0
>>
>> Can you give exact firmware version you tested, please? I'll add it to
>> the commit log.
>>
>> I'll also fix the typo "condtion" in the title.
>
>
> Hi Kalle,
>
> The Fw version tested are:
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,
> WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1
Thanks. But please do not drop the lists, otherwise patchwork won't see
this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
2019-02-01 5:34 ` Surabhi Vishnoi
` (2 preceding siblings ...)
(?)
@ 2019-02-07 14:57 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-07 14:57 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: ath10k, linux-wireless, Surabhi Vishnoi
Surabhi Vishnoi <svishnoi@codeaurora.org> wrote:
> The firmware advertises the LDPC support information for HT in
> HT capability info in the wmi service ready event. To provide
> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
> capabilities.
>
> Add a condition to existing logic in host to know whether firmware
> supports LDPC or not.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,
> WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1
>
> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
ff488d0ef1c2 ath10k: add a condition to fill the LDPC capability correctly
--
https://patchwork.kernel.org/patch/10791807/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly
2019-02-01 5:34 ` Surabhi Vishnoi
(?)
(?)
@ 2019-02-07 14:57 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2019-02-07 14:57 UTC (permalink / raw)
To: Surabhi Vishnoi; +Cc: linux-wireless, ath10k
Surabhi Vishnoi <svishnoi@codeaurora.org> wrote:
> The firmware advertises the LDPC support information for HT in
> HT capability info in the wmi service ready event. To provide
> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and
> WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should
> also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT
> capabilities.
>
> Add a condition to existing logic in host to know whether firmware
> supports LDPC or not.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,
> WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1
>
> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
ff488d0ef1c2 ath10k: add a condition to fill the LDPC capability correctly
--
https://patchwork.kernel.org/patch/10791807/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-07 14:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-01 5:34 [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly Surabhi Vishnoi
2019-02-01 5:34 ` Surabhi Vishnoi
2019-02-04 15:32 ` Kalle Valo
2019-02-04 15:32 ` Kalle Valo
[not found] ` <b14e2139c794201664a49d36cc28ab48@codeaurora.org>
2019-02-07 9:10 ` Kalle Valo
2019-02-07 9:10 ` Kalle Valo
2019-02-07 14:57 ` Kalle Valo
2019-02-07 14:57 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.