From: Will Deacon <will.deacon@arm.com>
To: Mars Cheng <mars.cheng@mediatek.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
CC Hwang <cc.hwang@mediatek.com>,
Loda Chou <loda.chou@mediatek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
Date: Wed, 13 Feb 2019 13:19:25 +0000 [thread overview]
Message-ID: <20190213131924.GD5875@brain-police> (raw)
In-Reply-To: <1549969765-3707-1-git-send-email-mars.cheng@mediatek.com>
On Tue, Feb 12, 2019 at 07:09:25PM +0800, Mars Cheng wrote:
> fix similar issue for aarch64 as the commit 7c64cc0531fa
> ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
> in aarch32
I'm not convinced about this justification. As far as I can tell, the commit
mentioned above fixed a cross-call from the idle path as a result of
ARCH_NEEDS_CPU_IDLE_COUPLED, but this never appears to be selected on arm64
afaict.
Are you actually seeing a problem on arm64 in practice?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Mars Cheng <mars.cheng@mediatek.com>
Cc: CC Hwang <cc.hwang@mediatek.com>,
wsd_upstream@mediatek.com,
Catalin Marinas <catalin.marinas@arm.com>,
Loda Chou <loda.chou@mediatek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
Date: Wed, 13 Feb 2019 13:19:25 +0000 [thread overview]
Message-ID: <20190213131924.GD5875@brain-police> (raw)
In-Reply-To: <1549969765-3707-1-git-send-email-mars.cheng@mediatek.com>
On Tue, Feb 12, 2019 at 07:09:25PM +0800, Mars Cheng wrote:
> fix similar issue for aarch64 as the commit 7c64cc0531fa
> ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
> in aarch32
I'm not convinced about this justification. As far as I can tell, the commit
mentioned above fixed a cross-call from the idle path as a result of
ARCH_NEEDS_CPU_IDLE_COUPLED, but this never appears to be selected on arm64
afaict.
Are you actually seeing a problem on arm64 in practice?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-13 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 11:09 [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints Mars Cheng
2019-02-12 11:09 ` Mars Cheng
2019-02-12 11:09 ` Mars Cheng
2019-02-13 13:19 ` Will Deacon [this message]
2019-02-13 13:19 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213131924.GD5875@brain-police \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cc.hwang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=loda.chou@mediatek.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.