* [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
@ 2019-02-12 11:09 ` Mars Cheng
0 siblings, 0 replies; 5+ messages in thread
From: Mars Cheng @ 2019-02-12 11:09 UTC (permalink / raw)
To: Will Deacon, Catalin Marinas, Matthias Brugger, Paul E. McKenney
Cc: CC Hwang, Loda Chou, linux-kernel, linux-mediatek,
linux-arm-kernel, wsd_upstream, Mars Cheng
fix similar issue for aarch64 as the commit 7c64cc0531fa
("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
in aarch32
Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
---
arch/arm64/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 1598d6f..c1cf8f9 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -758,7 +758,7 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
{
- trace_ipi_raise(target, ipi_types[ipinr]);
+ trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
__smp_cross_call(target, ipinr);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
@ 2019-02-12 11:09 ` Mars Cheng
0 siblings, 0 replies; 5+ messages in thread
From: Mars Cheng @ 2019-02-12 11:09 UTC (permalink / raw)
To: Will Deacon, Catalin Marinas, Matthias Brugger, Paul E. McKenney
Cc: CC Hwang, wsd_upstream, Loda Chou, linux-kernel, linux-mediatek,
Mars Cheng, linux-arm-kernel
fix similar issue for aarch64 as the commit 7c64cc0531fa
("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
in aarch32
Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
---
arch/arm64/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 1598d6f..c1cf8f9 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -758,7 +758,7 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
{
- trace_ipi_raise(target, ipi_types[ipinr]);
+ trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
__smp_cross_call(target, ipinr);
}
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
@ 2019-02-12 11:09 ` Mars Cheng
0 siblings, 0 replies; 5+ messages in thread
From: Mars Cheng @ 2019-02-12 11:09 UTC (permalink / raw)
To: Will Deacon, Catalin Marinas, Matthias Brugger, Paul E. McKenney
Cc: CC Hwang, Loda Chou, linux-kernel, linux-mediatek,
linux-arm-kernel, wsd_upstream, Mars Cheng
fix similar issue for aarch64 as the commit 7c64cc0531fa
("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
in aarch32
Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
---
arch/arm64/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 1598d6f..c1cf8f9 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -758,7 +758,7 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
{
- trace_ipi_raise(target, ipi_types[ipinr]);
+ trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
__smp_cross_call(target, ipinr);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
2019-02-12 11:09 ` Mars Cheng
@ 2019-02-13 13:19 ` Will Deacon
-1 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2019-02-13 13:19 UTC (permalink / raw)
To: Mars Cheng
Cc: Catalin Marinas, Matthias Brugger, Paul E. McKenney, CC Hwang,
Loda Chou, linux-kernel, linux-mediatek, linux-arm-kernel,
wsd_upstream
On Tue, Feb 12, 2019 at 07:09:25PM +0800, Mars Cheng wrote:
> fix similar issue for aarch64 as the commit 7c64cc0531fa
> ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
> in aarch32
I'm not convinced about this justification. As far as I can tell, the commit
mentioned above fixed a cross-call from the idle path as a result of
ARCH_NEEDS_CPU_IDLE_COUPLED, but this never appears to be selected on arm64
afaict.
Are you actually seeing a problem on arm64 in practice?
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints
@ 2019-02-13 13:19 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2019-02-13 13:19 UTC (permalink / raw)
To: Mars Cheng
Cc: CC Hwang, wsd_upstream, Catalin Marinas, Loda Chou, linux-kernel,
linux-mediatek, Matthias Brugger, Paul E. McKenney,
linux-arm-kernel
On Tue, Feb 12, 2019 at 07:09:25PM +0800, Mars Cheng wrote:
> fix similar issue for aarch64 as the commit 7c64cc0531fa
> ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed
> in aarch32
I'm not convinced about this justification. As far as I can tell, the commit
mentioned above fixed a cross-call from the idle path as a result of
ARCH_NEEDS_CPU_IDLE_COUPLED, but this never appears to be selected on arm64
afaict.
Are you actually seeing a problem on arm64 in practice?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-13 13:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 11:09 [PATCH 1/1] arm64: Use _rcuidle for smp_cross_call() tracepoints Mars Cheng
2019-02-12 11:09 ` Mars Cheng
2019-02-12 11:09 ` Mars Cheng
2019-02-13 13:19 ` Will Deacon
2019-02-13 13:19 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.