* [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
@ 2019-01-29 7:15 ` Maya Nakamura
0 siblings, 0 replies; 22+ messages in thread
From: Maya Nakamura @ 2019-01-29 7:15 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Cc: marcelo.cerri, vkuznets, haiyangz, driverdev-devel, linux-kernel
This patchset removes a duplicate definition of VP set (hv_vp_set) and
uses the common definition (hv_vpset) that is used in other places. It
changes the order of the members in struct hv_pcibus_device due to
flexible array in hv_vpset.
It also removes the duplicate implementation of cpumask_to_vpset(), uses
the shared implementation, and exports hv_max_vp_index, which is
required by cpumask_to_vpset().
Maya Nakamura (2):
PCI: hv: Replace hv_vp_set with hv_vpset
PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
arch/x86/hyperv/hv_init.c | 1 +
drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
2 files changed, 28 insertions(+), 32 deletions(-)
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
2019-01-29 7:15 ` Maya Nakamura
@ 2019-01-29 7:18 ` Maya Nakamura
-1 siblings, 0 replies; 22+ messages in thread
From: Maya Nakamura @ 2019-01-29 7:18 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Cc: linux-kernel, driverdev-devel, haiyangz, vkuznets, marcelo.cerri
Remove a duplicate definition of VP set (hv_vp_set) and use the common
definition (hv_vpset) that is used in other places.
Change the order of the members in struct hv_pcibus_device so that the
declaration of retarget_msi_interrupt_params is the last member. Struct
hv_vpset, which contains a flexible array, is nested two levels deep in
struct hv_pcibus_device via retarget_msi_interrupt_params.
Add a comment that retarget_msi_interrupt_params should be the last member
of struct hv_pcibus_device.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
Change in v3:
- Correct the v2 change log.
Change in v2:
- Update the commit message.
drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index 9ba4d12c179c..da8b58d8630d 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -393,12 +393,6 @@ struct hv_interrupt_entry {
#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
-struct hv_vp_set {
- u64 format; /* 0 (HvGenericSetSparse4k) */
- u64 valid_banks;
- u64 masks[HV_VP_SET_BANK_COUNT_MAX];
-};
-
/*
* flags for hv_device_interrupt_target.flags
*/
@@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
u32 flags;
union {
u64 vp_mask;
- struct hv_vp_set vp_set;
+ struct hv_vpset vp_set;
};
};
@@ -460,12 +454,16 @@ struct hv_pcibus_device {
struct msi_controller msi_chip;
struct irq_domain *irq_domain;
- /* hypercall arg, must not cross page boundary */
- struct retarget_msi_interrupt retarget_msi_interrupt_params;
-
spinlock_t retarget_msi_interrupt_lock;
struct workqueue_struct *wq;
+
+ /* hypercall arg, must not cross page boundary */
+ struct retarget_msi_interrupt retarget_msi_interrupt_params;
+
+ /*
+ * Don't put anything here: retarget_msi_interrupt_params must be last
+ */
};
/*
@@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
*/
params->int_target.flags |=
HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
- params->int_target.vp_set.valid_banks =
+ params->int_target.vp_set.valid_bank_mask =
(1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
/*
* var-sized hypercall, var-size starts after vp_mask (thus
- * vp_set.format does not count, but vp_set.valid_banks does).
+ * vp_set.format does not count, but vp_set.valid_bank_mask
+ * does).
*/
var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
@@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
goto exit_unlock;
}
- params->int_target.vp_set.masks[cpu_vmbus / 64] |=
+ params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
(1ULL << (cpu_vmbus & 63));
}
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
@ 2019-01-29 7:18 ` Maya Nakamura
0 siblings, 0 replies; 22+ messages in thread
From: Maya Nakamura @ 2019-01-29 7:18 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Cc: marcelo.cerri, vkuznets, haiyangz, driverdev-devel, linux-kernel
Remove a duplicate definition of VP set (hv_vp_set) and use the common
definition (hv_vpset) that is used in other places.
Change the order of the members in struct hv_pcibus_device so that the
declaration of retarget_msi_interrupt_params is the last member. Struct
hv_vpset, which contains a flexible array, is nested two levels deep in
struct hv_pcibus_device via retarget_msi_interrupt_params.
Add a comment that retarget_msi_interrupt_params should be the last member
of struct hv_pcibus_device.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
Change in v3:
- Correct the v2 change log.
Change in v2:
- Update the commit message.
drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index 9ba4d12c179c..da8b58d8630d 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -393,12 +393,6 @@ struct hv_interrupt_entry {
#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
-struct hv_vp_set {
- u64 format; /* 0 (HvGenericSetSparse4k) */
- u64 valid_banks;
- u64 masks[HV_VP_SET_BANK_COUNT_MAX];
-};
-
/*
* flags for hv_device_interrupt_target.flags
*/
@@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
u32 flags;
union {
u64 vp_mask;
- struct hv_vp_set vp_set;
+ struct hv_vpset vp_set;
};
};
@@ -460,12 +454,16 @@ struct hv_pcibus_device {
struct msi_controller msi_chip;
struct irq_domain *irq_domain;
- /* hypercall arg, must not cross page boundary */
- struct retarget_msi_interrupt retarget_msi_interrupt_params;
-
spinlock_t retarget_msi_interrupt_lock;
struct workqueue_struct *wq;
+
+ /* hypercall arg, must not cross page boundary */
+ struct retarget_msi_interrupt retarget_msi_interrupt_params;
+
+ /*
+ * Don't put anything here: retarget_msi_interrupt_params must be last
+ */
};
/*
@@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
*/
params->int_target.flags |=
HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
- params->int_target.vp_set.valid_banks =
+ params->int_target.vp_set.valid_bank_mask =
(1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
/*
* var-sized hypercall, var-size starts after vp_mask (thus
- * vp_set.format does not count, but vp_set.valid_banks does).
+ * vp_set.format does not count, but vp_set.valid_bank_mask
+ * does).
*/
var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
@@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
goto exit_unlock;
}
- params->int_target.vp_set.masks[cpu_vmbus / 64] |=
+ params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
(1ULL << (cpu_vmbus & 63));
}
} else {
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* RE: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
2019-01-29 7:18 ` Maya Nakamura
(?)
@ 2019-01-29 19:21 ` Michael Kelley
-1 siblings, 0 replies; 22+ messages in thread
From: Michael Kelley @ 2019-01-29 19:21 UTC (permalink / raw)
To: m.maya.nakamura, lorenzo.pieralisi, bhelgaas, linux-pci,
KY Srinivasan, Stephen Hemminger, olaf, apw, jasowang,
Sasha Levin
Cc: marcelo.cerri, vkuznets, Haiyang Zhang, driverdev-devel, linux-kernel
From: Maya Nakamura <m.maya.nakamura@gmail.com> Sent: Monday, January 28, 2019 11:18 PM
>
> Remove a duplicate definition of VP set (hv_vp_set) and use the common
> definition (hv_vpset) that is used in other places.
>
> Change the order of the members in struct hv_pcibus_device so that the
> declaration of retarget_msi_interrupt_params is the last member. Struct
> hv_vpset, which contains a flexible array, is nested two levels deep in
> struct hv_pcibus_device via retarget_msi_interrupt_params.
>
> Add a comment that retarget_msi_interrupt_params should be the last member
> of struct hv_pcibus_device.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Change in v3:
> - Correct the v2 change log.
>
> Change in v2:
> - Update the commit message.
>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
2019-01-29 7:18 ` Maya Nakamura
@ 2019-02-27 15:53 ` Vitaly Kuznetsov
-1 siblings, 0 replies; 22+ messages in thread
From: Vitaly Kuznetsov @ 2019-02-27 15:53 UTC (permalink / raw)
To: Maya Nakamura
Cc: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin, linux-kernel,
driverdev-devel, haiyangz, marcelo.cerri
Maya Nakamura <m.maya.nakamura@gmail.com> writes:
> Remove a duplicate definition of VP set (hv_vp_set) and use the common
> definition (hv_vpset) that is used in other places.
>
> Change the order of the members in struct hv_pcibus_device so that the
> declaration of retarget_msi_interrupt_params is the last member. Struct
> hv_vpset, which contains a flexible array, is nested two levels deep in
> struct hv_pcibus_device via retarget_msi_interrupt_params.
>
> Add a comment that retarget_msi_interrupt_params should be the last member
> of struct hv_pcibus_device.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Change in v3:
> - Correct the v2 change log.
>
> Change in v2:
> - Update the commit message.
>
> drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 9ba4d12c179c..da8b58d8630d 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -393,12 +393,6 @@ struct hv_interrupt_entry {
>
> #define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
>
> -struct hv_vp_set {
> - u64 format; /* 0 (HvGenericSetSparse4k) */
> - u64 valid_banks;
> - u64 masks[HV_VP_SET_BANK_COUNT_MAX];
> -};
> -
> /*
> * flags for hv_device_interrupt_target.flags
> */
> @@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
> u32 flags;
> union {
> u64 vp_mask;
> - struct hv_vp_set vp_set;
> + struct hv_vpset vp_set;
> };
> };
>
> @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> struct msi_controller msi_chip;
> struct irq_domain *irq_domain;
>
> - /* hypercall arg, must not cross page boundary */
> - struct retarget_msi_interrupt retarget_msi_interrupt_params;
> -
> spinlock_t retarget_msi_interrupt_lock;
>
> struct workqueue_struct *wq;
> +
> + /* hypercall arg, must not cross page boundary */
> + struct retarget_msi_interrupt retarget_msi_interrupt_params;
> +
One more thing here (and again sorry for being late): this structure is
being used as Hyper-V hypercall argument and these have special
requirements on alignment (8 bytes). struct retarget_msi_interrupt is
packed and depending on your environment/compiler you may or may not see
the issue but I has able to get HVCALL_RETARGET_INTERRUPT failing with
the return value of 4 (HV_STATUS_INVALID_ALIGNMENT).
I suggest we add __aligned(8) to 'struct retarget_msi_interrupt'
definition (I haven't tested this but should work). This is not a new
issue, it existed before your patch, but the code movement you do may
change the exposure.
> + /*
> + * Don't put anything here: retarget_msi_interrupt_params must be last
> + */
> };
>
> /*
> @@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
> */
> params->int_target.flags |=
> HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> - params->int_target.vp_set.valid_banks =
> + params->int_target.vp_set.valid_bank_mask =
> (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
>
> /*
> * var-sized hypercall, var-size starts after vp_mask (thus
> - * vp_set.format does not count, but vp_set.valid_banks does).
> + * vp_set.format does not count, but vp_set.valid_bank_mask
> + * does).
> */
> var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
>
> @@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
> goto exit_unlock;
> }
>
> - params->int_target.vp_set.masks[cpu_vmbus / 64] |=
> + params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> (1ULL << (cpu_vmbus & 63));
> }
> } else {
--
Vitaly
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
@ 2019-02-27 15:53 ` Vitaly Kuznetsov
0 siblings, 0 replies; 22+ messages in thread
From: Vitaly Kuznetsov @ 2019-02-27 15:53 UTC (permalink / raw)
To: Maya Nakamura
Cc: olaf, lorenzo.pieralisi, sthemmin, linux-pci, jasowang,
driverdev-devel, linux-kernel, mikelley, Alexander.Levin, apw,
marcelo.cerri, bhelgaas, haiyangz
Maya Nakamura <m.maya.nakamura@gmail.com> writes:
> Remove a duplicate definition of VP set (hv_vp_set) and use the common
> definition (hv_vpset) that is used in other places.
>
> Change the order of the members in struct hv_pcibus_device so that the
> declaration of retarget_msi_interrupt_params is the last member. Struct
> hv_vpset, which contains a flexible array, is nested two levels deep in
> struct hv_pcibus_device via retarget_msi_interrupt_params.
>
> Add a comment that retarget_msi_interrupt_params should be the last member
> of struct hv_pcibus_device.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Change in v3:
> - Correct the v2 change log.
>
> Change in v2:
> - Update the commit message.
>
> drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 9ba4d12c179c..da8b58d8630d 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -393,12 +393,6 @@ struct hv_interrupt_entry {
>
> #define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
>
> -struct hv_vp_set {
> - u64 format; /* 0 (HvGenericSetSparse4k) */
> - u64 valid_banks;
> - u64 masks[HV_VP_SET_BANK_COUNT_MAX];
> -};
> -
> /*
> * flags for hv_device_interrupt_target.flags
> */
> @@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
> u32 flags;
> union {
> u64 vp_mask;
> - struct hv_vp_set vp_set;
> + struct hv_vpset vp_set;
> };
> };
>
> @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> struct msi_controller msi_chip;
> struct irq_domain *irq_domain;
>
> - /* hypercall arg, must not cross page boundary */
> - struct retarget_msi_interrupt retarget_msi_interrupt_params;
> -
> spinlock_t retarget_msi_interrupt_lock;
>
> struct workqueue_struct *wq;
> +
> + /* hypercall arg, must not cross page boundary */
> + struct retarget_msi_interrupt retarget_msi_interrupt_params;
> +
One more thing here (and again sorry for being late): this structure is
being used as Hyper-V hypercall argument and these have special
requirements on alignment (8 bytes). struct retarget_msi_interrupt is
packed and depending on your environment/compiler you may or may not see
the issue but I has able to get HVCALL_RETARGET_INTERRUPT failing with
the return value of 4 (HV_STATUS_INVALID_ALIGNMENT).
I suggest we add __aligned(8) to 'struct retarget_msi_interrupt'
definition (I haven't tested this but should work). This is not a new
issue, it existed before your patch, but the code movement you do may
change the exposure.
> + /*
> + * Don't put anything here: retarget_msi_interrupt_params must be last
> + */
> };
>
> /*
> @@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
> */
> params->int_target.flags |=
> HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> - params->int_target.vp_set.valid_banks =
> + params->int_target.vp_set.valid_bank_mask =
> (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
>
> /*
> * var-sized hypercall, var-size starts after vp_mask (thus
> - * vp_set.format does not count, but vp_set.valid_banks does).
> + * vp_set.format does not count, but vp_set.valid_bank_mask
> + * does).
> */
> var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
>
> @@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
> goto exit_unlock;
> }
>
> - params->int_target.vp_set.masks[cpu_vmbus / 64] |=
> + params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> (1ULL << (cpu_vmbus & 63));
> }
> } else {
--
Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
2019-02-27 15:53 ` Vitaly Kuznetsov
@ 2019-02-27 16:42 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-27 16:42 UTC (permalink / raw)
To: Vitaly Kuznetsov, Maya Nakamura
Cc: bhelgaas, linux-pci, kys, sthemmin, olaf, apw, jasowang,
mikelley, Alexander.Levin, linux-kernel, driverdev-devel,
haiyangz, marcelo.cerri
On Wed, Feb 27, 2019 at 04:53:37PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@gmail.com> writes:
>
> > Remove a duplicate definition of VP set (hv_vp_set) and use the common
> > definition (hv_vpset) that is used in other places.
> >
> > Change the order of the members in struct hv_pcibus_device so that the
> > declaration of retarget_msi_interrupt_params is the last member. Struct
> > hv_vpset, which contains a flexible array, is nested two levels deep in
> > struct hv_pcibus_device via retarget_msi_interrupt_params.
> >
> > Add a comment that retarget_msi_interrupt_params should be the last member
> > of struct hv_pcibus_device.
> >
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> > Change in v3:
> > - Correct the v2 change log.
> >
> > Change in v2:
> > - Update the commit message.
> >
> > drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
> > 1 file changed, 12 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index 9ba4d12c179c..da8b58d8630d 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -393,12 +393,6 @@ struct hv_interrupt_entry {
> >
> > #define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> >
> > -struct hv_vp_set {
> > - u64 format; /* 0 (HvGenericSetSparse4k) */
> > - u64 valid_banks;
> > - u64 masks[HV_VP_SET_BANK_COUNT_MAX];
> > -};
> > -
> > /*
> > * flags for hv_device_interrupt_target.flags
> > */
> > @@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
> > u32 flags;
> > union {
> > u64 vp_mask;
> > - struct hv_vp_set vp_set;
> > + struct hv_vpset vp_set;
> > };
> > };
> >
> > @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> > struct msi_controller msi_chip;
> > struct irq_domain *irq_domain;
> >
> > - /* hypercall arg, must not cross page boundary */
> > - struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > -
> > spinlock_t retarget_msi_interrupt_lock;
> >
> > struct workqueue_struct *wq;
> > +
> > + /* hypercall arg, must not cross page boundary */
> > + struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > +
>
> One more thing here (and again sorry for being late): this structure is
> being used as Hyper-V hypercall argument and these have special
> requirements on alignment (8 bytes). struct retarget_msi_interrupt is
> packed and depending on your environment/compiler you may or may not see
> the issue but I has able to get HVCALL_RETARGET_INTERRUPT failing with
> the return value of 4 (HV_STATUS_INVALID_ALIGNMENT).
>
> I suggest we add __aligned(8) to 'struct retarget_msi_interrupt'
> definition (I haven't tested this but should work). This is not a new
> issue, it existed before your patch, but the code movement you do may
> change the exposure.
I am happy to apply this small fix _before_ this patch but if you want
me to merge them for v5.1 this must be put together and tested quite
quickly.
For the time being I am not dropping this patch from the PCI queue,
waiting for an update from you guys.
Thanks,
Lorenzo
>
>
> > + /*
> > + * Don't put anything here: retarget_msi_interrupt_params must be last
> > + */
> > };
> >
> > /*
> > @@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
> > */
> > params->int_target.flags |=
> > HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> > - params->int_target.vp_set.valid_banks =
> > + params->int_target.vp_set.valid_bank_mask =
> > (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> >
> > /*
> > * var-sized hypercall, var-size starts after vp_mask (thus
> > - * vp_set.format does not count, but vp_set.valid_banks does).
> > + * vp_set.format does not count, but vp_set.valid_bank_mask
> > + * does).
> > */
> > var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> >
> > @@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
> > goto exit_unlock;
> > }
> >
> > - params->int_target.vp_set.masks[cpu_vmbus / 64] |=
> > + params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> > (1ULL << (cpu_vmbus & 63));
> > }
> > } else {
>
> --
> Vitaly
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
@ 2019-02-27 16:42 ` Lorenzo Pieralisi
0 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-27 16:42 UTC (permalink / raw)
To: Vitaly Kuznetsov, Maya Nakamura
Cc: olaf, sthemmin, linux-pci, jasowang, driverdev-devel,
linux-kernel, mikelley, Alexander.Levin, apw, marcelo.cerri,
bhelgaas, haiyangz
On Wed, Feb 27, 2019 at 04:53:37PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@gmail.com> writes:
>
> > Remove a duplicate definition of VP set (hv_vp_set) and use the common
> > definition (hv_vpset) that is used in other places.
> >
> > Change the order of the members in struct hv_pcibus_device so that the
> > declaration of retarget_msi_interrupt_params is the last member. Struct
> > hv_vpset, which contains a flexible array, is nested two levels deep in
> > struct hv_pcibus_device via retarget_msi_interrupt_params.
> >
> > Add a comment that retarget_msi_interrupt_params should be the last member
> > of struct hv_pcibus_device.
> >
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> > Change in v3:
> > - Correct the v2 change log.
> >
> > Change in v2:
> > - Update the commit message.
> >
> > drivers/pci/controller/pci-hyperv.c | 25 ++++++++++++-------------
> > 1 file changed, 12 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index 9ba4d12c179c..da8b58d8630d 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -393,12 +393,6 @@ struct hv_interrupt_entry {
> >
> > #define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> >
> > -struct hv_vp_set {
> > - u64 format; /* 0 (HvGenericSetSparse4k) */
> > - u64 valid_banks;
> > - u64 masks[HV_VP_SET_BANK_COUNT_MAX];
> > -};
> > -
> > /*
> > * flags for hv_device_interrupt_target.flags
> > */
> > @@ -410,7 +404,7 @@ struct hv_device_interrupt_target {
> > u32 flags;
> > union {
> > u64 vp_mask;
> > - struct hv_vp_set vp_set;
> > + struct hv_vpset vp_set;
> > };
> > };
> >
> > @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> > struct msi_controller msi_chip;
> > struct irq_domain *irq_domain;
> >
> > - /* hypercall arg, must not cross page boundary */
> > - struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > -
> > spinlock_t retarget_msi_interrupt_lock;
> >
> > struct workqueue_struct *wq;
> > +
> > + /* hypercall arg, must not cross page boundary */
> > + struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > +
>
> One more thing here (and again sorry for being late): this structure is
> being used as Hyper-V hypercall argument and these have special
> requirements on alignment (8 bytes). struct retarget_msi_interrupt is
> packed and depending on your environment/compiler you may or may not see
> the issue but I has able to get HVCALL_RETARGET_INTERRUPT failing with
> the return value of 4 (HV_STATUS_INVALID_ALIGNMENT).
>
> I suggest we add __aligned(8) to 'struct retarget_msi_interrupt'
> definition (I haven't tested this but should work). This is not a new
> issue, it existed before your patch, but the code movement you do may
> change the exposure.
I am happy to apply this small fix _before_ this patch but if you want
me to merge them for v5.1 this must be put together and tested quite
quickly.
For the time being I am not dropping this patch from the PCI queue,
waiting for an update from you guys.
Thanks,
Lorenzo
>
>
> > + /*
> > + * Don't put anything here: retarget_msi_interrupt_params must be last
> > + */
> > };
> >
> > /*
> > @@ -955,12 +953,13 @@ static void hv_irq_unmask(struct irq_data *data)
> > */
> > params->int_target.flags |=
> > HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> > - params->int_target.vp_set.valid_banks =
> > + params->int_target.vp_set.valid_bank_mask =
> > (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> >
> > /*
> > * var-sized hypercall, var-size starts after vp_mask (thus
> > - * vp_set.format does not count, but vp_set.valid_banks does).
> > + * vp_set.format does not count, but vp_set.valid_bank_mask
> > + * does).
> > */
> > var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> >
> > @@ -974,7 +973,7 @@ static void hv_irq_unmask(struct irq_data *data)
> > goto exit_unlock;
> > }
> >
> > - params->int_target.vp_set.masks[cpu_vmbus / 64] |=
> > + params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> > (1ULL << (cpu_vmbus & 63));
> > }
> > } else {
>
> --
> Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
2019-01-29 7:15 ` Maya Nakamura
@ 2019-01-29 7:20 ` Maya Nakamura
-1 siblings, 0 replies; 22+ messages in thread
From: Maya Nakamura @ 2019-01-29 7:20 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Cc: linux-kernel, driverdev-devel, haiyangz, vkuznets, marcelo.cerri
Remove the duplicate implementation of cpumask_to_vpset() and use the
shared implementation. Export hv_max_vp_index, which is required by
cpumask_to_vpset().
Apply changes to hv_irq_unmask() based on feedback.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
Changes in v3:
- Modify to catch all failures from cpumask_to_vpset().
- Correct the v2 change log about the commit message.
Changes in v2:
- Remove unnecessary nr_bank initialization.
- Delete two unnecessary dev_err()'s.
- Unlock before returning.
- Update the commit message.
arch/x86/hyperv/hv_init.c | 1 +
drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
2 files changed, 18 insertions(+), 21 deletions(-)
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
index 7abb09e2eeb8..7f2eed1fc81b 100644
--- a/arch/x86/hyperv/hv_init.c
+++ b/arch/x86/hyperv/hv_init.c
@@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
u32 hv_max_vp_index;
+EXPORT_SYMBOL_GPL(hv_max_vp_index);
static int hv_cpu_init(unsigned int cpu)
{
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index da8b58d8630d..a78def332bbc 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -391,8 +391,6 @@ struct hv_interrupt_entry {
u32 data;
};
-#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
-
/*
* flags for hv_device_interrupt_target.flags
*/
@@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
struct retarget_msi_interrupt *params;
struct hv_pcibus_device *hbus;
struct cpumask *dest;
+ cpumask_var_t tmp;
struct pci_bus *pbus;
struct pci_dev *pdev;
unsigned long flags;
u32 var_size = 0;
- int cpu_vmbus;
- int cpu;
+ int cpu, nr_bank;
u64 res;
dest = irq_data_get_effective_affinity_mask(data);
@@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
*/
params->int_target.flags |=
HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
- params->int_target.vp_set.valid_bank_mask =
- (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
+
+ if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
+ res = 1;
+ goto exit_unlock;
+ }
+
+ cpumask_and(tmp, dest, cpu_online_mask);
+ nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
+ free_cpumask_var(tmp);
+
+ if (nr_bank <= 0) {
+ res = 1;
+ goto exit_unlock;
+ }
/*
* var-sized hypercall, var-size starts after vp_mask (thus
* vp_set.format does not count, but vp_set.valid_bank_mask
* does).
*/
- var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
-
- for_each_cpu_and(cpu, dest, cpu_online_mask) {
- cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
-
- if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
- dev_err(&hbus->hdev->device,
- "too high CPU %d", cpu_vmbus);
- res = 1;
- goto exit_unlock;
- }
-
- params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
- (1ULL << (cpu_vmbus & 63));
- }
+ var_size = 1 + nr_bank;
} else {
for_each_cpu_and(cpu, dest, cpu_online_mask) {
params->int_target.vp_mask |=
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
@ 2019-01-29 7:20 ` Maya Nakamura
0 siblings, 0 replies; 22+ messages in thread
From: Maya Nakamura @ 2019-01-29 7:20 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Cc: marcelo.cerri, vkuznets, haiyangz, driverdev-devel, linux-kernel
Remove the duplicate implementation of cpumask_to_vpset() and use the
shared implementation. Export hv_max_vp_index, which is required by
cpumask_to_vpset().
Apply changes to hv_irq_unmask() based on feedback.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
Changes in v3:
- Modify to catch all failures from cpumask_to_vpset().
- Correct the v2 change log about the commit message.
Changes in v2:
- Remove unnecessary nr_bank initialization.
- Delete two unnecessary dev_err()'s.
- Unlock before returning.
- Update the commit message.
arch/x86/hyperv/hv_init.c | 1 +
drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
2 files changed, 18 insertions(+), 21 deletions(-)
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
index 7abb09e2eeb8..7f2eed1fc81b 100644
--- a/arch/x86/hyperv/hv_init.c
+++ b/arch/x86/hyperv/hv_init.c
@@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
u32 hv_max_vp_index;
+EXPORT_SYMBOL_GPL(hv_max_vp_index);
static int hv_cpu_init(unsigned int cpu)
{
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index da8b58d8630d..a78def332bbc 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -391,8 +391,6 @@ struct hv_interrupt_entry {
u32 data;
};
-#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
-
/*
* flags for hv_device_interrupt_target.flags
*/
@@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
struct retarget_msi_interrupt *params;
struct hv_pcibus_device *hbus;
struct cpumask *dest;
+ cpumask_var_t tmp;
struct pci_bus *pbus;
struct pci_dev *pdev;
unsigned long flags;
u32 var_size = 0;
- int cpu_vmbus;
- int cpu;
+ int cpu, nr_bank;
u64 res;
dest = irq_data_get_effective_affinity_mask(data);
@@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
*/
params->int_target.flags |=
HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
- params->int_target.vp_set.valid_bank_mask =
- (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
+
+ if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
+ res = 1;
+ goto exit_unlock;
+ }
+
+ cpumask_and(tmp, dest, cpu_online_mask);
+ nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
+ free_cpumask_var(tmp);
+
+ if (nr_bank <= 0) {
+ res = 1;
+ goto exit_unlock;
+ }
/*
* var-sized hypercall, var-size starts after vp_mask (thus
* vp_set.format does not count, but vp_set.valid_bank_mask
* does).
*/
- var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
-
- for_each_cpu_and(cpu, dest, cpu_online_mask) {
- cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
-
- if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
- dev_err(&hbus->hdev->device,
- "too high CPU %d", cpu_vmbus);
- res = 1;
- goto exit_unlock;
- }
-
- params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
- (1ULL << (cpu_vmbus & 63));
- }
+ var_size = 1 + nr_bank;
} else {
for_each_cpu_and(cpu, dest, cpu_online_mask) {
params->int_target.vp_mask |=
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* RE: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
2019-01-29 7:20 ` Maya Nakamura
(?)
@ 2019-01-29 19:25 ` Michael Kelley
-1 siblings, 0 replies; 22+ messages in thread
From: Michael Kelley @ 2019-01-29 19:25 UTC (permalink / raw)
To: m.maya.nakamura, lorenzo.pieralisi, bhelgaas, linux-pci,
KY Srinivasan, Stephen Hemminger, olaf, apw, jasowang,
Sasha Levin
Cc: marcelo.cerri, vkuznets, Haiyang Zhang, driverdev-devel, linux-kernel
From: Maya Nakamura <m.maya.nakamura@gmail.com> Sent: Monday, January 28, 2019 11:21 PM
>
> Remove the duplicate implementation of cpumask_to_vpset() and use the
> shared implementation. Export hv_max_vp_index, which is required by
> cpumask_to_vpset().
>
> Apply changes to hv_irq_unmask() based on feedback.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Changes in v3:
> - Modify to catch all failures from cpumask_to_vpset().
> - Correct the v2 change log about the commit message.
>
> Changes in v2:
> - Remove unnecessary nr_bank initialization.
> - Delete two unnecessary dev_err()'s.
> - Unlock before returning.
> - Update the commit message.
>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
2019-01-29 7:20 ` Maya Nakamura
@ 2019-02-27 12:34 ` Vitaly Kuznetsov
-1 siblings, 0 replies; 22+ messages in thread
From: Vitaly Kuznetsov @ 2019-02-27 12:34 UTC (permalink / raw)
To: Maya Nakamura
Cc: linux-kernel, driverdev-devel, haiyangz, marcelo.cerri,
lorenzo.pieralisi, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
Maya Nakamura <m.maya.nakamura@gmail.com> writes:
> Remove the duplicate implementation of cpumask_to_vpset() and use the
> shared implementation. Export hv_max_vp_index, which is required by
> cpumask_to_vpset().
>
> Apply changes to hv_irq_unmask() based on feedback.
>
I just noticed an issue with this patch, sorry I've missed it before. I
don't see the commit in Linus' tree, not sure if we should amend this
one or a follow-up patch is needed.
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Changes in v3:
> - Modify to catch all failures from cpumask_to_vpset().
> - Correct the v2 change log about the commit message.
>
> Changes in v2:
> - Remove unnecessary nr_bank initialization.
> - Delete two unnecessary dev_err()'s.
> - Unlock before returning.
> - Update the commit message.
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
> 2 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 7abb09e2eeb8..7f2eed1fc81b 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
> EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
>
> u32 hv_max_vp_index;
> +EXPORT_SYMBOL_GPL(hv_max_vp_index);
>
> static int hv_cpu_init(unsigned int cpu)
> {
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index da8b58d8630d..a78def332bbc 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -391,8 +391,6 @@ struct hv_interrupt_entry {
> u32 data;
> };
>
> -#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> -
> /*
> * flags for hv_device_interrupt_target.flags
> */
> @@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
> struct retarget_msi_interrupt *params;
> struct hv_pcibus_device *hbus;
> struct cpumask *dest;
> + cpumask_var_t tmp;
> struct pci_bus *pbus;
> struct pci_dev *pdev;
> unsigned long flags;
> u32 var_size = 0;
> - int cpu_vmbus;
> - int cpu;
> + int cpu, nr_bank;
> u64 res;
>
> dest = irq_data_get_effective_affinity_mask(data);
> @@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
> */
> params->int_target.flags |=
> HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> - params->int_target.vp_set.valid_bank_mask =
> - (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> +
> + if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
We can't use GFP_KERNEL here: this is happening under
hbus->retarget_msi_interrupt_lock spinlock, we should use GFP_ATOMIC
instead. It may, however, make sense to add the cpumask to a
pre-allocated structure (e.g. struct hv_pcibus_device) to make sure the
allocation never fails.
> + res = 1;
> + goto exit_unlock;
> + }
> +
> + cpumask_and(tmp, dest, cpu_online_mask);
> + nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
> + free_cpumask_var(tmp);
> +
> + if (nr_bank <= 0) {
> + res = 1;
> + goto exit_unlock;
> + }
>
> /*
> * var-sized hypercall, var-size starts after vp_mask (thus
> * vp_set.format does not count, but vp_set.valid_bank_mask
> * does).
> */
> - var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> -
> - for_each_cpu_and(cpu, dest, cpu_online_mask) {
> - cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
> -
> - if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
> - dev_err(&hbus->hdev->device,
> - "too high CPU %d", cpu_vmbus);
> - res = 1;
> - goto exit_unlock;
> - }
> -
> - params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> - (1ULL << (cpu_vmbus & 63));
> - }
> + var_size = 1 + nr_bank;
> } else {
> for_each_cpu_and(cpu, dest, cpu_online_mask) {
> params->int_target.vp_mask |=
--
Vitaly
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
@ 2019-02-27 12:34 ` Vitaly Kuznetsov
0 siblings, 0 replies; 22+ messages in thread
From: Vitaly Kuznetsov @ 2019-02-27 12:34 UTC (permalink / raw)
To: Maya Nakamura
Cc: apw, olaf, lorenzo.pieralisi, sthemmin, linux-pci, haiyangz,
driverdev-devel, linux-kernel, mikelley, Alexander.Levin,
bhelgaas, marcelo.cerri, jasowang
Maya Nakamura <m.maya.nakamura@gmail.com> writes:
> Remove the duplicate implementation of cpumask_to_vpset() and use the
> shared implementation. Export hv_max_vp_index, which is required by
> cpumask_to_vpset().
>
> Apply changes to hv_irq_unmask() based on feedback.
>
I just noticed an issue with this patch, sorry I've missed it before. I
don't see the commit in Linus' tree, not sure if we should amend this
one or a follow-up patch is needed.
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> Changes in v3:
> - Modify to catch all failures from cpumask_to_vpset().
> - Correct the v2 change log about the commit message.
>
> Changes in v2:
> - Remove unnecessary nr_bank initialization.
> - Delete two unnecessary dev_err()'s.
> - Unlock before returning.
> - Update the commit message.
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
> 2 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 7abb09e2eeb8..7f2eed1fc81b 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
> EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
>
> u32 hv_max_vp_index;
> +EXPORT_SYMBOL_GPL(hv_max_vp_index);
>
> static int hv_cpu_init(unsigned int cpu)
> {
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index da8b58d8630d..a78def332bbc 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -391,8 +391,6 @@ struct hv_interrupt_entry {
> u32 data;
> };
>
> -#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> -
> /*
> * flags for hv_device_interrupt_target.flags
> */
> @@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
> struct retarget_msi_interrupt *params;
> struct hv_pcibus_device *hbus;
> struct cpumask *dest;
> + cpumask_var_t tmp;
> struct pci_bus *pbus;
> struct pci_dev *pdev;
> unsigned long flags;
> u32 var_size = 0;
> - int cpu_vmbus;
> - int cpu;
> + int cpu, nr_bank;
> u64 res;
>
> dest = irq_data_get_effective_affinity_mask(data);
> @@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
> */
> params->int_target.flags |=
> HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> - params->int_target.vp_set.valid_bank_mask =
> - (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> +
> + if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
We can't use GFP_KERNEL here: this is happening under
hbus->retarget_msi_interrupt_lock spinlock, we should use GFP_ATOMIC
instead. It may, however, make sense to add the cpumask to a
pre-allocated structure (e.g. struct hv_pcibus_device) to make sure the
allocation never fails.
> + res = 1;
> + goto exit_unlock;
> + }
> +
> + cpumask_and(tmp, dest, cpu_online_mask);
> + nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
> + free_cpumask_var(tmp);
> +
> + if (nr_bank <= 0) {
> + res = 1;
> + goto exit_unlock;
> + }
>
> /*
> * var-sized hypercall, var-size starts after vp_mask (thus
> * vp_set.format does not count, but vp_set.valid_bank_mask
> * does).
> */
> - var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> -
> - for_each_cpu_and(cpu, dest, cpu_online_mask) {
> - cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
> -
> - if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
> - dev_err(&hbus->hdev->device,
> - "too high CPU %d", cpu_vmbus);
> - res = 1;
> - goto exit_unlock;
> - }
> -
> - params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> - (1ULL << (cpu_vmbus & 63));
> - }
> + var_size = 1 + nr_bank;
> } else {
> for_each_cpu_and(cpu, dest, cpu_online_mask) {
> params->int_target.vp_mask |=
--
Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
2019-02-27 12:34 ` Vitaly Kuznetsov
@ 2019-02-27 14:28 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-27 14:28 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Maya Nakamura, linux-kernel, driverdev-devel, haiyangz,
marcelo.cerri, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin
On Wed, Feb 27, 2019 at 01:34:44PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@gmail.com> writes:
>
> > Remove the duplicate implementation of cpumask_to_vpset() and use the
> > shared implementation. Export hv_max_vp_index, which is required by
> > cpumask_to_vpset().
> >
> > Apply changes to hv_irq_unmask() based on feedback.
> >
>
> I just noticed an issue with this patch, sorry I've missed it before. I
> don't see the commit in Linus' tree, not sure if we should amend this
> one or a follow-up patch is needed.
I will drop this patch from the PCI queue, it does not make sense
to merge a patch adding a bug and fix it up later with a subsequent
one given that it is not upstream yet.
Lorenzo
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> > Changes in v3:
> > - Modify to catch all failures from cpumask_to_vpset().
> > - Correct the v2 change log about the commit message.
> >
> > Changes in v2:
> > - Remove unnecessary nr_bank initialization.
> > - Delete two unnecessary dev_err()'s.
> > - Unlock before returning.
> > - Update the commit message.
> >
> > arch/x86/hyperv/hv_init.c | 1 +
> > drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
> > 2 files changed, 18 insertions(+), 21 deletions(-)
> >
> > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> > index 7abb09e2eeb8..7f2eed1fc81b 100644
> > --- a/arch/x86/hyperv/hv_init.c
> > +++ b/arch/x86/hyperv/hv_init.c
> > @@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
> > EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
> >
> > u32 hv_max_vp_index;
> > +EXPORT_SYMBOL_GPL(hv_max_vp_index);
> >
> > static int hv_cpu_init(unsigned int cpu)
> > {
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index da8b58d8630d..a78def332bbc 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -391,8 +391,6 @@ struct hv_interrupt_entry {
> > u32 data;
> > };
> >
> > -#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> > -
> > /*
> > * flags for hv_device_interrupt_target.flags
> > */
> > @@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
> > struct retarget_msi_interrupt *params;
> > struct hv_pcibus_device *hbus;
> > struct cpumask *dest;
> > + cpumask_var_t tmp;
> > struct pci_bus *pbus;
> > struct pci_dev *pdev;
> > unsigned long flags;
> > u32 var_size = 0;
> > - int cpu_vmbus;
> > - int cpu;
> > + int cpu, nr_bank;
> > u64 res;
> >
> > dest = irq_data_get_effective_affinity_mask(data);
> > @@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
> > */
> > params->int_target.flags |=
> > HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> > - params->int_target.vp_set.valid_bank_mask =
> > - (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> > +
> > + if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
>
> We can't use GFP_KERNEL here: this is happening under
> hbus->retarget_msi_interrupt_lock spinlock, we should use GFP_ATOMIC
> instead. It may, however, make sense to add the cpumask to a
> pre-allocated structure (e.g. struct hv_pcibus_device) to make sure the
> allocation never fails.
>
> > + res = 1;
> > + goto exit_unlock;
> > + }
> > +
> > + cpumask_and(tmp, dest, cpu_online_mask);
> > + nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
> > + free_cpumask_var(tmp);
> > +
> > + if (nr_bank <= 0) {
> > + res = 1;
> > + goto exit_unlock;
> > + }
> >
> > /*
> > * var-sized hypercall, var-size starts after vp_mask (thus
> > * vp_set.format does not count, but vp_set.valid_bank_mask
> > * does).
> > */
> > - var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> > -
> > - for_each_cpu_and(cpu, dest, cpu_online_mask) {
> > - cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
> > -
> > - if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
> > - dev_err(&hbus->hdev->device,
> > - "too high CPU %d", cpu_vmbus);
> > - res = 1;
> > - goto exit_unlock;
> > - }
> > -
> > - params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> > - (1ULL << (cpu_vmbus & 63));
> > - }
> > + var_size = 1 + nr_bank;
> > } else {
> > for_each_cpu_and(cpu, dest, cpu_online_mask) {
> > params->int_target.vp_mask |=
>
> --
> Vitaly
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
@ 2019-02-27 14:28 ` Lorenzo Pieralisi
0 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-27 14:28 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: apw, olaf, sthemmin, linux-pci, haiyangz, driverdev-devel,
linux-kernel, mikelley, Alexander.Levin, bhelgaas, marcelo.cerri,
Maya Nakamura, jasowang
On Wed, Feb 27, 2019 at 01:34:44PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@gmail.com> writes:
>
> > Remove the duplicate implementation of cpumask_to_vpset() and use the
> > shared implementation. Export hv_max_vp_index, which is required by
> > cpumask_to_vpset().
> >
> > Apply changes to hv_irq_unmask() based on feedback.
> >
>
> I just noticed an issue with this patch, sorry I've missed it before. I
> don't see the commit in Linus' tree, not sure if we should amend this
> one or a follow-up patch is needed.
I will drop this patch from the PCI queue, it does not make sense
to merge a patch adding a bug and fix it up later with a subsequent
one given that it is not upstream yet.
Lorenzo
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> > Changes in v3:
> > - Modify to catch all failures from cpumask_to_vpset().
> > - Correct the v2 change log about the commit message.
> >
> > Changes in v2:
> > - Remove unnecessary nr_bank initialization.
> > - Delete two unnecessary dev_err()'s.
> > - Unlock before returning.
> > - Update the commit message.
> >
> > arch/x86/hyperv/hv_init.c | 1 +
> > drivers/pci/controller/pci-hyperv.c | 38 +++++++++++++----------------
> > 2 files changed, 18 insertions(+), 21 deletions(-)
> >
> > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> > index 7abb09e2eeb8..7f2eed1fc81b 100644
> > --- a/arch/x86/hyperv/hv_init.c
> > +++ b/arch/x86/hyperv/hv_init.c
> > @@ -96,6 +96,7 @@ void __percpu **hyperv_pcpu_input_arg;
> > EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
> >
> > u32 hv_max_vp_index;
> > +EXPORT_SYMBOL_GPL(hv_max_vp_index);
> >
> > static int hv_cpu_init(unsigned int cpu)
> > {
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index da8b58d8630d..a78def332bbc 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -391,8 +391,6 @@ struct hv_interrupt_entry {
> > u32 data;
> > };
> >
> > -#define HV_VP_SET_BANK_COUNT_MAX 5 /* current implementation limit */
> > -
> > /*
> > * flags for hv_device_interrupt_target.flags
> > */
> > @@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data)
> > struct retarget_msi_interrupt *params;
> > struct hv_pcibus_device *hbus;
> > struct cpumask *dest;
> > + cpumask_var_t tmp;
> > struct pci_bus *pbus;
> > struct pci_dev *pdev;
> > unsigned long flags;
> > u32 var_size = 0;
> > - int cpu_vmbus;
> > - int cpu;
> > + int cpu, nr_bank;
> > u64 res;
> >
> > dest = irq_data_get_effective_affinity_mask(data);
> > @@ -953,29 +951,27 @@ static void hv_irq_unmask(struct irq_data *data)
> > */
> > params->int_target.flags |=
> > HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
> > - params->int_target.vp_set.valid_bank_mask =
> > - (1ull << HV_VP_SET_BANK_COUNT_MAX) - 1;
> > +
> > + if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) {
>
> We can't use GFP_KERNEL here: this is happening under
> hbus->retarget_msi_interrupt_lock spinlock, we should use GFP_ATOMIC
> instead. It may, however, make sense to add the cpumask to a
> pre-allocated structure (e.g. struct hv_pcibus_device) to make sure the
> allocation never fails.
>
> > + res = 1;
> > + goto exit_unlock;
> > + }
> > +
> > + cpumask_and(tmp, dest, cpu_online_mask);
> > + nr_bank = cpumask_to_vpset(¶ms->int_target.vp_set, tmp);
> > + free_cpumask_var(tmp);
> > +
> > + if (nr_bank <= 0) {
> > + res = 1;
> > + goto exit_unlock;
> > + }
> >
> > /*
> > * var-sized hypercall, var-size starts after vp_mask (thus
> > * vp_set.format does not count, but vp_set.valid_bank_mask
> > * does).
> > */
> > - var_size = 1 + HV_VP_SET_BANK_COUNT_MAX;
> > -
> > - for_each_cpu_and(cpu, dest, cpu_online_mask) {
> > - cpu_vmbus = hv_cpu_number_to_vp_number(cpu);
> > -
> > - if (cpu_vmbus >= HV_VP_SET_BANK_COUNT_MAX * 64) {
> > - dev_err(&hbus->hdev->device,
> > - "too high CPU %d", cpu_vmbus);
> > - res = 1;
> > - goto exit_unlock;
> > - }
> > -
> > - params->int_target.vp_set.bank_contents[cpu_vmbus / 64] |=
> > - (1ULL << (cpu_vmbus & 63));
> > - }
> > + var_size = 1 + nr_bank;
> > } else {
> > for_each_cpu_and(cpu, dest, cpu_online_mask) {
> > params->int_target.vp_mask |=
>
> --
> Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
2019-01-29 7:15 ` Maya Nakamura
@ 2019-02-13 15:15 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-13 15:15 UTC (permalink / raw)
To: Maya Nakamura
Cc: bhelgaas, linux-pci, kys, sthemmin, olaf, apw, jasowang,
mikelley, Alexander.Levin, linux-kernel, driverdev-devel,
haiyangz, vkuznets, marcelo.cerri
On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
> This patchset removes a duplicate definition of VP set (hv_vp_set) and
> uses the common definition (hv_vpset) that is used in other places. It
> changes the order of the members in struct hv_pcibus_device due to
> flexible array in hv_vpset.
>
> It also removes the duplicate implementation of cpumask_to_vpset(), uses
> the shared implementation, and exports hv_max_vp_index, which is
> required by cpumask_to_vpset().
>
> Maya Nakamura (2):
> PCI: hv: Replace hv_vp_set with hv_vpset
> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
> 2 files changed, 28 insertions(+), 32 deletions(-)
I need a maintainer ACK to merge this series.
Lorenzo
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
@ 2019-02-13 15:15 ` Lorenzo Pieralisi
0 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-13 15:15 UTC (permalink / raw)
To: Maya Nakamura
Cc: olaf, sthemmin, linux-pci, jasowang, driverdev-devel,
linux-kernel, mikelley, Alexander.Levin, apw, marcelo.cerri,
bhelgaas, vkuznets, haiyangz
On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
> This patchset removes a duplicate definition of VP set (hv_vp_set) and
> uses the common definition (hv_vpset) that is used in other places. It
> changes the order of the members in struct hv_pcibus_device due to
> flexible array in hv_vpset.
>
> It also removes the duplicate implementation of cpumask_to_vpset(), uses
> the shared implementation, and exports hv_max_vp_index, which is
> required by cpumask_to_vpset().
>
> Maya Nakamura (2):
> PCI: hv: Replace hv_vp_set with hv_vpset
> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
> 2 files changed, 28 insertions(+), 32 deletions(-)
I need a maintainer ACK to merge this series.
Lorenzo
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
2019-02-13 15:15 ` Lorenzo Pieralisi
@ 2019-02-15 1:58 ` Sasha Levin
-1 siblings, 0 replies; 22+ messages in thread
From: Sasha Levin @ 2019-02-15 1:58 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Maya Nakamura, bhelgaas, linux-pci, kys, sthemmin, olaf, apw,
jasowang, mikelley, Alexander.Levin, linux-kernel,
driverdev-devel, haiyangz, vkuznets, marcelo.cerri
On Wed, Feb 13, 2019 at 03:15:49PM +0000, Lorenzo Pieralisi wrote:
>On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
>> This patchset removes a duplicate definition of VP set (hv_vp_set) and
>> uses the common definition (hv_vpset) that is used in other places. It
>> changes the order of the members in struct hv_pcibus_device due to
>> flexible array in hv_vpset.
>>
>> It also removes the duplicate implementation of cpumask_to_vpset(), uses
>> the shared implementation, and exports hv_max_vp_index, which is
>> required by cpumask_to_vpset().
>>
>> Maya Nakamura (2):
>> PCI: hv: Replace hv_vp_set with hv_vpset
>> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>>
>> arch/x86/hyperv/hv_init.c | 1 +
>> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
>> 2 files changed, 28 insertions(+), 32 deletions(-)
>
>I need a maintainer ACK to merge this series.
Acked-by: Sasha Levin <sashal@kernel.org>
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
@ 2019-02-15 1:58 ` Sasha Levin
0 siblings, 0 replies; 22+ messages in thread
From: Sasha Levin @ 2019-02-15 1:58 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: olaf, sthemmin, linux-pci, jasowang, driverdev-devel,
linux-kernel, mikelley, Alexander.Levin, apw, marcelo.cerri,
bhelgaas, Maya Nakamura, vkuznets, haiyangz
On Wed, Feb 13, 2019 at 03:15:49PM +0000, Lorenzo Pieralisi wrote:
>On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
>> This patchset removes a duplicate definition of VP set (hv_vp_set) and
>> uses the common definition (hv_vpset) that is used in other places. It
>> changes the order of the members in struct hv_pcibus_device due to
>> flexible array in hv_vpset.
>>
>> It also removes the duplicate implementation of cpumask_to_vpset(), uses
>> the shared implementation, and exports hv_max_vp_index, which is
>> required by cpumask_to_vpset().
>>
>> Maya Nakamura (2):
>> PCI: hv: Replace hv_vp_set with hv_vpset
>> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>>
>> arch/x86/hyperv/hv_init.c | 1 +
>> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
>> 2 files changed, 28 insertions(+), 32 deletions(-)
>
>I need a maintainer ACK to merge this series.
Acked-by: Sasha Levin <sashal@kernel.org>
--
Thanks,
Sasha
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
2019-01-29 7:15 ` Maya Nakamura
@ 2019-02-15 10:36 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-15 10:36 UTC (permalink / raw)
To: Maya Nakamura
Cc: bhelgaas, linux-pci, kys, sthemmin, olaf, apw, jasowang,
mikelley, Alexander.Levin, linux-kernel, driverdev-devel,
haiyangz, vkuznets, marcelo.cerri
On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
> This patchset removes a duplicate definition of VP set (hv_vp_set) and
> uses the common definition (hv_vpset) that is used in other places. It
> changes the order of the members in struct hv_pcibus_device due to
> flexible array in hv_vpset.
>
> It also removes the duplicate implementation of cpumask_to_vpset(), uses
> the shared implementation, and exports hv_max_vp_index, which is
> required by cpumask_to_vpset().
>
> Maya Nakamura (2):
> PCI: hv: Replace hv_vp_set with hv_vpset
> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
> 2 files changed, 28 insertions(+), 32 deletions(-)
Applied to pci/hv for v5.1, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()
@ 2019-02-15 10:36 ` Lorenzo Pieralisi
0 siblings, 0 replies; 22+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-15 10:36 UTC (permalink / raw)
To: Maya Nakamura
Cc: olaf, sthemmin, linux-pci, jasowang, driverdev-devel,
linux-kernel, mikelley, Alexander.Levin, apw, marcelo.cerri,
bhelgaas, vkuznets, haiyangz
On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote:
> This patchset removes a duplicate definition of VP set (hv_vp_set) and
> uses the common definition (hv_vpset) that is used in other places. It
> changes the order of the members in struct hv_pcibus_device due to
> flexible array in hv_vpset.
>
> It also removes the duplicate implementation of cpumask_to_vpset(), uses
> the shared implementation, and exports hv_max_vp_index, which is
> required by cpumask_to_vpset().
>
> Maya Nakamura (2):
> PCI: hv: Replace hv_vp_set with hv_vpset
> PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
>
> arch/x86/hyperv/hv_init.c | 1 +
> drivers/pci/controller/pci-hyperv.c | 59 +++++++++++++----------------
> 2 files changed, 28 insertions(+), 32 deletions(-)
Applied to pci/hv for v5.1, thanks.
Lorenzo
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 22+ messages in thread