From: David Summers <beagleboard@davidjohnsummers.uk> To: heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-rockchip@lists.infradead.org, David Summers <beagleboard@davidjohnsummers.uk>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth Date: Sun, 17 Feb 2019 12:15:13 +0000 [thread overview] Message-ID: <20190217121513.22965-4-beagleboard@davidjohnsummers.uk> (raw) In-Reply-To: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> This patch is to add Bluetooth to the ASUS Tinker Board (S) device tree. This patch is more contraversal - so probably view it as a request for comments. The reason behind this, is this patch does not currently set Bluetooth working on the these boards. The problem is that the bluetooth/hci_h5.c driver, that is used for Realtek serial devices, depends on ACPI. Unfortantly ACPI can not be enabled on armv7 machines such as the TB(S). And so the kernel module for the RTL8723BS Bluetooth can not be loaded. However this patch is believed to be an accurate description of the Tinker Board (S) wiring. It is strongly based on the ASUS patch: https://github.com/TinkerBoard/debian_kernel/commit/6a3128ade33f758887048578ada61a4b7ab8e678 As the Bluetooth is connected via a UART and this is wired into uart0, this has been described as a SerDev. The ASUS patch mentions the UART_CTS, but not the _RTS. Now as the RTL8723BS has both CTS and RTS on the uart, it has been assumed both are wired into uart0 on the cpu. The Bluetooth connection has several wake up pins both device and host and a reset pin. The wiring of these has been described; however how the kernel driver will use these isn't clear. E.g. should HOST_WAKE be an interupt? The main reason for asking for comments, is that when it comes time to make the changes to the bluetooth uart code, and add compatible flags, robh has indicated that this will only be accepted with a valid example. So the code below is that example. So I would like comments that this approach is valid, which can be used when the later submission comes. Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk> --- arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi index e1796f340eef..931b4c652fdc 100644 --- a/arch/arm/boot/dts/rk3288-tinker.dtsi +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi @@ -481,6 +481,17 @@ &uart0 { status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; + + bluetooth { + clocks = <&rk808 RK808_CLKOUT1>; + reset-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>; + device-wake-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; + host-wake-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; + vcc-18-supply = <&vcc_18>; + vcc-io-supply = <&vcc_io>; + }; }; &uart1 { -- beagleboard@davidjohnsummers.uk
WARNING: multiple messages have this Message-ID (diff)
From: David Summers <beagleboard@davidjohnsummers.uk> To: heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-rockchip@lists.infradead.org, David Summers <beagleboard@davidjohnsummers.uk>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth Date: Sun, 17 Feb 2019 12:15:13 +0000 [thread overview] Message-ID: <20190217121513.22965-4-beagleboard@davidjohnsummers.uk> (raw) In-Reply-To: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> This patch is to add Bluetooth to the ASUS Tinker Board (S) device tree. This patch is more contraversal - so probably view it as a request for comments. The reason behind this, is this patch does not currently set Bluetooth working on the these boards. The problem is that the bluetooth/hci_h5.c driver, that is used for Realtek serial devices, depends on ACPI. Unfortantly ACPI can not be enabled on armv7 machines such as the TB(S). And so the kernel module for the RTL8723BS Bluetooth can not be loaded. However this patch is believed to be an accurate description of the Tinker Board (S) wiring. It is strongly based on the ASUS patch: https://github.com/TinkerBoard/debian_kernel/commit/6a3128ade33f758887048578ada61a4b7ab8e678 As the Bluetooth is connected via a UART and this is wired into uart0, this has been described as a SerDev. The ASUS patch mentions the UART_CTS, but not the _RTS. Now as the RTL8723BS has both CTS and RTS on the uart, it has been assumed both are wired into uart0 on the cpu. The Bluetooth connection has several wake up pins both device and host and a reset pin. The wiring of these has been described; however how the kernel driver will use these isn't clear. E.g. should HOST_WAKE be an interupt? The main reason for asking for comments, is that when it comes time to make the changes to the bluetooth uart code, and add compatible flags, robh has indicated that this will only be accepted with a valid example. So the code below is that example. So I would like comments that this approach is valid, which can be used when the later submission comes. Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk> --- arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi index e1796f340eef..931b4c652fdc 100644 --- a/arch/arm/boot/dts/rk3288-tinker.dtsi +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi @@ -481,6 +481,17 @@ &uart0 { status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; + + bluetooth { + clocks = <&rk808 RK808_CLKOUT1>; + reset-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>; + device-wake-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; + host-wake-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; + vcc-18-supply = <&vcc_18>; + vcc-io-supply = <&vcc_io>; + }; }; &uart1 { -- beagleboard@davidjohnsummers.uk _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-17 12:15 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 12:15 [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 12:15 ` [PATCH 1/3] ARM: dts: rk3288 Tinker Board (S) sdcard changes David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 14:00 ` Robin Murphy 2019-02-17 14:00 ` Robin Murphy 2019-02-17 15:19 ` David Summers 2019-02-17 15:19 ` David Summers 2019-02-18 11:54 ` Robin Murphy 2019-02-18 11:54 ` Robin Murphy 2019-02-19 20:13 ` David Summers 2019-02-19 20:13 ` David Summers [not found] ` <20190217121513.22965-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 20:29 ` Stefan Wahren 2019-02-17 20:29 ` Stefan Wahren [not found] ` <1660942499.343639.1550435365757-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:08 ` David Summers 2019-02-18 20:08 ` David Summers 2019-02-22 18:47 ` [PATCH 1/3 v2] ARM: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers [not found] ` <20190222184708.32004-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:26 ` Jonas Karlman 2019-02-24 19:26 ` Jonas Karlman [not found] ` <AM3PR03MB096656098C6CB4712C73C095AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 19:35 ` David Summers [not found] ` <5387a001-1036-bb5c-e781-18e87ca6e7bd-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:56 ` Jonas Karlman [not found] ` <AM3PR03MB09663F32FC40000E42C1A722AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 20:10 ` David Summers [not found] ` <e1f1a93e-505b-bf53-a253-5c1ddaeaebf8-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 22:54 ` Heiko Stübner 2019-02-24 22:54 ` Heiko Stübner 2019-02-25 8:59 ` Jonas Karlman 2019-02-25 21:00 ` David Summers [not found] ` <31863095-94b5-5fec-0293-b30172426b93-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:14 ` Doug Anderson 2019-02-25 17:13 ` Doug Anderson [not found] ` <CAD=FV=UkQ7pEan4aGezvQZZjBc0gDJ1R7YRbN1Lbv9HBVQRgHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 21:11 ` David Summers [not found] ` <9e90c5dd-7b1e-9e53-81ac-fb3b515215ca-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:18 ` Doug Anderson [not found] ` <CAD=FV=XEPKpDVLdpCVB9eMzJNE8C5Pr=fRgRmJXgxzrDFJ39mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 22:20 ` Heiko Stübner 2019-02-26 14:46 ` Robin Murphy [not found] ` <108411d8-9607-d92d-e546-d0c85bcabc51-5wv7dgnIgG8@public.gmane.org> 2019-02-26 16:43 ` Doug Anderson [not found] ` <CAD=FV=X0rRPkEim1sHS9EqDCLiWPO7e5Vu-0gAcX7YZ_omeKPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-27 13:48 ` Robin Murphy 2019-03-03 11:08 ` David Summers 2019-02-17 12:15 ` [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 14:32 ` Tony McKahan 2019-02-17 14:32 ` Tony McKahan 2019-02-17 15:55 ` David Summers [not found] ` <4ef63671-f58d-3b16-9055-09e69314a0e6-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 17:32 ` Tony McKahan 2019-02-17 17:32 ` Tony McKahan 2019-02-17 21:19 ` Stefan Wahren 2019-02-17 21:19 ` Stefan Wahren [not found] ` <CAERgokmpHQb2czJdx++qFoogFRmkvXZm=4BNOsVuCz-ZvgTEaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-17 19:03 ` David Summers 2019-02-17 19:03 ` David Summers 2019-02-17 20:43 ` Stefan Wahren 2019-02-17 20:43 ` Stefan Wahren 2019-02-18 12:30 ` Robin Murphy 2019-02-18 12:30 ` Robin Murphy [not found] ` <1528638260.343699.1550436208775-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:26 ` David Summers 2019-02-18 20:26 ` David Summers 2019-02-18 21:48 ` Stefan Wahren 2019-02-18 21:48 ` Stefan Wahren 2019-03-03 19:40 ` David Summers 2019-03-03 19:40 ` David Summers [not found] ` <9df2e318-a459-bded-2971-90a6722e1a4f-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-03 22:12 ` Tony McKahan 2019-03-03 22:12 ` Tony McKahan 2019-02-17 12:15 ` David Summers [this message] 2019-02-17 12:15 ` [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth David Summers [not found] ` <20190217121513.22965-4-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 13:31 ` Tony McKahan 2019-02-17 13:31 ` Tony McKahan 2019-02-17 21:05 ` Stefan Wahren 2019-02-17 21:05 ` Stefan Wahren 2019-02-18 20:47 ` David Summers 2019-02-18 21:40 ` Stefan Wahren 2019-03-03 20:15 ` David Summers 2019-03-03 20:15 ` David Summers 2019-02-23 19:42 ` [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-23 19:42 ` David Summers 2019-03-09 15:36 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers 2019-03-09 15:36 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers [not found] ` <20190309153923.22806-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-09 15:39 ` [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 22:18 ` Robin Murphy 2019-03-11 22:18 ` Robin Murphy [not found] ` <383c9884-4885-34e1-9ef7-96e936bb211d-5wv7dgnIgG8@public.gmane.org> 2019-03-12 20:41 ` David Summers 2019-03-12 20:41 ` David Summers [not found] ` <c91db9a2-4283-0ea5-949e-ed190a7a8083-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:55 ` Heiko Stübner 2019-03-12 20:55 ` Heiko Stübner [not found] ` <20190309153923.22806-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:21 ` Stefan Wahren 2019-03-12 14:21 ` Stefan Wahren 2019-03-13 10:50 ` Heiko Stübner 2019-03-13 10:50 ` Heiko Stübner 2019-03-09 15:39 ` [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers [not found] ` <20190309153923.22806-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 19:57 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-12 14:08 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Heiko Stuebner 2019-03-12 14:08 ` Heiko Stuebner 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 20:34 ` David Summers [not found] ` <4a1ad220-103d-543e-56d1-3c6d6ad906ec-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 21:04 ` Jonas Karlman 2019-03-12 21:04 ` Jonas Karlman 2019-03-13 10:40 ` Heiko Stübner 2019-03-13 10:40 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190217121513.22965-4-beagleboard@davidjohnsummers.uk \ --to=beagleboard@davidjohnsummers.uk \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.