From: David Summers <beagleboard@davidjohnsummers.uk> Cc: linux-bluetooth@vger.kernel.org, "linux-rockchip@lists.infradead.org" <linux-rockchip@lists.infradead.org>, arm-linux <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org> Subject: Re: [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support Date: Wed, 13 Mar 2019 20:02:24 +0000 [thread overview] Message-ID: <f71f537d-f7d3-dda8-a960-13dd442d75c4@davidjohnsummers.uk> (raw) In-Reply-To: <4537885.W6WcYDDAQ4@diego> On 13/03/2019 10:56, Heiko Stübner wrote: > Hi David, > > Am Samstag, 9. März 2019, 16:39:23 CET schrieb David Summers: >> This patch is an outline for bluetooth on the ASUS Tinker Board (S). >> >> Bluetooth is provided my RTL8723BS on these machine, and this is wired >> into UART0. >> >> Here this is performed as a SerDev device. >> >> Now as presented, this does not give functioning bluetooth. The >> updates needed to the device driver: >> >> https://www.spinics.net/lists/linux-bluetooth/msg78661.html >> >> Haven't yet been accepted. So this device tree hook doesn't yet have >> "realtek,rtl8723bs-bt" compatible flag. >> >> It is however still submitted as a patch, as it sets the UART up >> correctly. And so basic communciation can be had with the device. This >> has been confirmed by Tony McKahan @ Armbian, in particular that the >> CTS/RTS is needed. >> >> When Vasily patch is accepted, this will be added as a minor patch on >> top of this patch; as this patch gives the pins needed. >> >> The one oddity, is the RESET pin, it is labeled this way on the >> schematic. However the hci_h5.c driver calls this ENABLE. Here we have >> stuck with the schematic name. >> >> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk> >> --- >> arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi >> b/arch/arm/boot/dts/rk3288-tinker.dtsi index 0ffab1b7c940..d29f5b34d7e6 >> 100644 >> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi >> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi >> @@ -486,6 +486,17 @@ >> >> &uart0 { >> status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; >> + >> + bluetooth { >> + clocks = <&rk808 RK808_CLKOUT1>; >> + reset-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; >> + device-wake-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; >> + host-wake-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; >> + vcc-18-supply = <&vcc_18>; >> + vcc-io-supply = <&vcc_io>; >> + }; > As this is supposed to work as serial attached device it should follow a > dt-binding, so first of all definitly needs a compatible and a binding > specifying all the properties declared above. > > See for example Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > for a similar device. > > Heiko > > Heiko, Yes I understand. Means I'll need to take care not to loose these email, as getting all the pins right took some time ... I'll probably follow https://www.spinics.net/lists/linux-bluetooth/msg78654.html if it gets accepted. That is the main problem here, at the moment there is no compatible that can be used, as none yet accepted. Rob H, Question for you, before you said [1]: > There's no interrupts, GPIO control lines, power supplies, etc. for > these chips? The binding should be complete even if your platform > doesn't need these. Now its clear that so far the driver for bluetooth doesn't know about supply, and clocks etc. So should these be included in the dts, as a correct description as how its wired; even if not used in the current driver, they may be used in future. Am happy to do whatever best. Regards, David. [1] https://www.spinics.net/lists/linux-bluetooth/msg78545.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: David Summers <beagleboard@davidjohnsummers.uk> To: unlisted-recipients:; (no To-header on input) Cc: linux-bluetooth@vger.kernel.org, devicetree <devicetree@vger.kernel.org>, arm-linux <linux-arm-kernel@lists.infradead.org>, "linux-rockchip@lists.infradead.org" <linux-rockchip@lists.infradead.org> Subject: Re: [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support Date: Wed, 13 Mar 2019 20:02:24 +0000 [thread overview] Message-ID: <f71f537d-f7d3-dda8-a960-13dd442d75c4@davidjohnsummers.uk> (raw) In-Reply-To: <4537885.W6WcYDDAQ4@diego> On 13/03/2019 10:56, Heiko Stübner wrote: > Hi David, > > Am Samstag, 9. März 2019, 16:39:23 CET schrieb David Summers: >> This patch is an outline for bluetooth on the ASUS Tinker Board (S). >> >> Bluetooth is provided my RTL8723BS on these machine, and this is wired >> into UART0. >> >> Here this is performed as a SerDev device. >> >> Now as presented, this does not give functioning bluetooth. The >> updates needed to the device driver: >> >> https://www.spinics.net/lists/linux-bluetooth/msg78661.html >> >> Haven't yet been accepted. So this device tree hook doesn't yet have >> "realtek,rtl8723bs-bt" compatible flag. >> >> It is however still submitted as a patch, as it sets the UART up >> correctly. And so basic communciation can be had with the device. This >> has been confirmed by Tony McKahan @ Armbian, in particular that the >> CTS/RTS is needed. >> >> When Vasily patch is accepted, this will be added as a minor patch on >> top of this patch; as this patch gives the pins needed. >> >> The one oddity, is the RESET pin, it is labeled this way on the >> schematic. However the hci_h5.c driver calls this ENABLE. Here we have >> stuck with the schematic name. >> >> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk> >> --- >> arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi >> b/arch/arm/boot/dts/rk3288-tinker.dtsi index 0ffab1b7c940..d29f5b34d7e6 >> 100644 >> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi >> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi >> @@ -486,6 +486,17 @@ >> >> &uart0 { >> status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; >> + >> + bluetooth { >> + clocks = <&rk808 RK808_CLKOUT1>; >> + reset-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; >> + device-wake-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; >> + host-wake-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; >> + vcc-18-supply = <&vcc_18>; >> + vcc-io-supply = <&vcc_io>; >> + }; > As this is supposed to work as serial attached device it should follow a > dt-binding, so first of all definitly needs a compatible and a binding > specifying all the properties declared above. > > See for example Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > for a similar device. > > Heiko > > Heiko, Yes I understand. Means I'll need to take care not to loose these email, as getting all the pins right took some time ... I'll probably follow https://www.spinics.net/lists/linux-bluetooth/msg78654.html if it gets accepted. That is the main problem here, at the moment there is no compatible that can be used, as none yet accepted. Rob H, Question for you, before you said [1]: > There's no interrupts, GPIO control lines, power supplies, etc. for > these chips? The binding should be complete even if your platform > doesn't need these. Now its clear that so far the driver for bluetooth doesn't know about supply, and clocks etc. So should these be included in the dts, as a correct description as how its wired; even if not used in the current driver, they may be used in future. Am happy to do whatever best. Regards, David. [1] https://www.spinics.net/lists/linux-bluetooth/msg78545.html
next prev parent reply other threads:[~2019-03-13 20:02 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 12:15 [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 12:15 ` [PATCH 1/3] ARM: dts: rk3288 Tinker Board (S) sdcard changes David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 14:00 ` Robin Murphy 2019-02-17 14:00 ` Robin Murphy 2019-02-17 15:19 ` David Summers 2019-02-17 15:19 ` David Summers 2019-02-18 11:54 ` Robin Murphy 2019-02-18 11:54 ` Robin Murphy 2019-02-19 20:13 ` David Summers 2019-02-19 20:13 ` David Summers [not found] ` <20190217121513.22965-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 20:29 ` Stefan Wahren 2019-02-17 20:29 ` Stefan Wahren [not found] ` <1660942499.343639.1550435365757-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:08 ` David Summers 2019-02-18 20:08 ` David Summers 2019-02-22 18:47 ` [PATCH 1/3 v2] ARM: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers [not found] ` <20190222184708.32004-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:26 ` Jonas Karlman 2019-02-24 19:26 ` Jonas Karlman [not found] ` <AM3PR03MB096656098C6CB4712C73C095AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 19:35 ` David Summers [not found] ` <5387a001-1036-bb5c-e781-18e87ca6e7bd-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:56 ` Jonas Karlman [not found] ` <AM3PR03MB09663F32FC40000E42C1A722AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 20:10 ` David Summers [not found] ` <e1f1a93e-505b-bf53-a253-5c1ddaeaebf8-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 22:54 ` Heiko Stübner 2019-02-24 22:54 ` Heiko Stübner 2019-02-25 8:59 ` Jonas Karlman 2019-02-25 21:00 ` David Summers [not found] ` <31863095-94b5-5fec-0293-b30172426b93-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:14 ` Doug Anderson 2019-02-25 17:13 ` Doug Anderson [not found] ` <CAD=FV=UkQ7pEan4aGezvQZZjBc0gDJ1R7YRbN1Lbv9HBVQRgHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 21:11 ` David Summers [not found] ` <9e90c5dd-7b1e-9e53-81ac-fb3b515215ca-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:18 ` Doug Anderson [not found] ` <CAD=FV=XEPKpDVLdpCVB9eMzJNE8C5Pr=fRgRmJXgxzrDFJ39mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 22:20 ` Heiko Stübner 2019-02-26 14:46 ` Robin Murphy [not found] ` <108411d8-9607-d92d-e546-d0c85bcabc51-5wv7dgnIgG8@public.gmane.org> 2019-02-26 16:43 ` Doug Anderson [not found] ` <CAD=FV=X0rRPkEim1sHS9EqDCLiWPO7e5Vu-0gAcX7YZ_omeKPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-27 13:48 ` Robin Murphy 2019-03-03 11:08 ` David Summers 2019-02-17 12:15 ` [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 14:32 ` Tony McKahan 2019-02-17 14:32 ` Tony McKahan 2019-02-17 15:55 ` David Summers [not found] ` <4ef63671-f58d-3b16-9055-09e69314a0e6-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 17:32 ` Tony McKahan 2019-02-17 17:32 ` Tony McKahan 2019-02-17 21:19 ` Stefan Wahren 2019-02-17 21:19 ` Stefan Wahren [not found] ` <CAERgokmpHQb2czJdx++qFoogFRmkvXZm=4BNOsVuCz-ZvgTEaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-17 19:03 ` David Summers 2019-02-17 19:03 ` David Summers 2019-02-17 20:43 ` Stefan Wahren 2019-02-17 20:43 ` Stefan Wahren 2019-02-18 12:30 ` Robin Murphy 2019-02-18 12:30 ` Robin Murphy [not found] ` <1528638260.343699.1550436208775-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:26 ` David Summers 2019-02-18 20:26 ` David Summers 2019-02-18 21:48 ` Stefan Wahren 2019-02-18 21:48 ` Stefan Wahren 2019-03-03 19:40 ` David Summers 2019-03-03 19:40 ` David Summers [not found] ` <9df2e318-a459-bded-2971-90a6722e1a4f-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-03 22:12 ` Tony McKahan 2019-03-03 22:12 ` Tony McKahan 2019-02-17 12:15 ` [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-4-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 13:31 ` Tony McKahan 2019-02-17 13:31 ` Tony McKahan 2019-02-17 21:05 ` Stefan Wahren 2019-02-17 21:05 ` Stefan Wahren 2019-02-18 20:47 ` David Summers 2019-02-18 21:40 ` Stefan Wahren 2019-03-03 20:15 ` David Summers 2019-03-03 20:15 ` David Summers 2019-02-23 19:42 ` [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-23 19:42 ` David Summers 2019-03-09 15:36 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers 2019-03-09 15:36 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers [not found] ` <20190309153923.22806-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-09 15:39 ` [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 22:18 ` Robin Murphy 2019-03-11 22:18 ` Robin Murphy [not found] ` <383c9884-4885-34e1-9ef7-96e936bb211d-5wv7dgnIgG8@public.gmane.org> 2019-03-12 20:41 ` David Summers 2019-03-12 20:41 ` David Summers [not found] ` <c91db9a2-4283-0ea5-949e-ed190a7a8083-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:55 ` Heiko Stübner 2019-03-12 20:55 ` Heiko Stübner [not found] ` <20190309153923.22806-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:21 ` Stefan Wahren 2019-03-12 14:21 ` Stefan Wahren 2019-03-13 10:50 ` Heiko Stübner 2019-03-13 10:50 ` Heiko Stübner 2019-03-09 15:39 ` [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers [not found] ` <20190309153923.22806-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 19:57 ` David Summers 2019-03-13 20:02 ` David Summers [this message] 2019-03-13 20:02 ` David Summers 2019-03-12 14:08 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Heiko Stuebner 2019-03-12 14:08 ` Heiko Stuebner 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 20:34 ` David Summers [not found] ` <4a1ad220-103d-543e-56d1-3c6d6ad906ec-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 21:04 ` Jonas Karlman 2019-03-12 21:04 ` Jonas Karlman 2019-03-13 10:40 ` Heiko Stübner 2019-03-13 10:40 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f71f537d-f7d3-dda8-a960-13dd442d75c4@davidjohnsummers.uk \ --to=beagleboard@davidjohnsummers.uk \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-bluetooth@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.