All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nsekhar@ti.com, grygorii.strashko@ti.com, vkoul@kernel.org,
	netdev@vger.kernel.org, f.fainelli@gmail.com,
	marc.w.gonzalez@free.fr, niklas.cassel@linaro.org
Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet
Date: Mon, 18 Feb 2019 08:26:13 -0800	[thread overview]
Message-ID: <20190218162613.GH15711@atomide.com> (raw)
In-Reply-To: <a9eea4d0-88d4-e903-8a9f-7f1b8b276c21@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [190218 16:22]:
> 
> 
> On 18/02/2019 16.44, Tony Lindgren wrote:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [190218 14:36]:
> >> Hi,
> >>
> >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the
> >> ethernet networking on evmsk (and most likely on the evm as well):
> >> https://patchwork.ozlabs.org/patch/1028527/
> >>
> >> v1 patch to fix the situation:
> >> https://patchwork.ozlabs.org/patch/1040617/
> >>
> >> It turned out that the at803x driver is actually broken and need to be fixed
> >> along with the DT data.
> >>
> >> The following series is proposed to fix the driver:
> >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611
> >>
> >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid:
> >> The rx delay is enabled by default and the driver never disabled it so when
> >> asking rgmii-txid it actually got rgmii-id.
> >>
> >> The patch can be backported to stable, I have tested that it is not causing
> >> regression with the old, broken driver.
> > 
> > Can the dts changes be merged before the driver changes or
> > does it cause the phy to stop working?
> 
> The phy is not working atm, but this change will not cause regression
> even if it is merged first.

OK so sounds like these are OK to wait for v5.1 merge window
then as the dts changes alone won't fix anything?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com,
	marc.w.gonzalez@free.fr, netdev@vger.kernel.org, nsekhar@ti.com,
	vkoul@kernel.org, f.fainelli@gmail.com, bcousson@baylibre.com,
	niklas.cassel@linaro.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet
Date: Mon, 18 Feb 2019 08:26:13 -0800	[thread overview]
Message-ID: <20190218162613.GH15711@atomide.com> (raw)
In-Reply-To: <a9eea4d0-88d4-e903-8a9f-7f1b8b276c21@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [190218 16:22]:
> 
> 
> On 18/02/2019 16.44, Tony Lindgren wrote:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [190218 14:36]:
> >> Hi,
> >>
> >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the
> >> ethernet networking on evmsk (and most likely on the evm as well):
> >> https://patchwork.ozlabs.org/patch/1028527/
> >>
> >> v1 patch to fix the situation:
> >> https://patchwork.ozlabs.org/patch/1040617/
> >>
> >> It turned out that the at803x driver is actually broken and need to be fixed
> >> along with the DT data.
> >>
> >> The following series is proposed to fix the driver:
> >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611
> >>
> >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid:
> >> The rx delay is enabled by default and the driver never disabled it so when
> >> asking rgmii-txid it actually got rgmii-id.
> >>
> >> The patch can be backported to stable, I have tested that it is not causing
> >> regression with the old, broken driver.
> > 
> > Can the dts changes be merged before the driver changes or
> > does it cause the phy to stop working?
> 
> The phy is not working atm, but this change will not cause regression
> even if it is merged first.

OK so sounds like these are OK to wait for v5.1 merge window
then as the dts changes alone won't fix anything?

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-18 16:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 14:36 [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet Peter Ujfalusi
2019-02-18 14:36 ` Peter Ujfalusi
2019-02-18 14:36 ` Peter Ujfalusi
2019-02-18 14:36 ` [PATCH 1/2] ARM: dts: am335x-evmsk: " Peter Ujfalusi
2019-02-18 14:36   ` Peter Ujfalusi
2019-02-18 14:36   ` Peter Ujfalusi
2019-02-18 14:36 ` [PATCH 2/2] ARM: dts: am335x-evm: " Peter Ujfalusi
2019-02-18 14:36   ` Peter Ujfalusi
2019-02-18 14:36   ` Peter Ujfalusi
2019-02-18 14:44 ` [PATCH 0/2] ARM: dts: am335x-evm/evmsk: " Tony Lindgren
2019-02-18 14:44   ` Tony Lindgren
2019-02-18 14:44   ` Tony Lindgren
2019-02-18 16:22   ` Peter Ujfalusi
2019-02-18 16:22     ` Peter Ujfalusi
2019-02-18 16:22     ` Peter Ujfalusi
2019-02-18 16:26     ` Tony Lindgren [this message]
2019-02-18 16:26       ` Tony Lindgren
2019-02-19  8:02       ` Peter Ujfalusi
2019-02-19  8:02         ` Peter Ujfalusi
2019-02-19  8:02         ` Peter Ujfalusi
2019-02-19 16:52         ` Tony Lindgren
2019-02-19 16:52           ` Tony Lindgren
2019-02-20  8:30           ` Peter Ujfalusi
2019-02-20  8:30             ` Peter Ujfalusi
2019-02-20  8:30             ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218162613.GH15711@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.cassel@linaro.org \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.