All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Erin Lo <erin.lo@mediatek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	devicetree@vger.kernel.org,
	srv_heupstream <srv_heupstream@mediatek.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, yingjoe.chen@mediatek.com,
	mars.cheng@mediatek.com, eddie.huang@mediatek.com,
	linux-clk@vger.kernel.org, Zhiyong Tao <zhiyong.tao@mediatek.com>
Subject: Re: [PATCH v7 5/6] arm64: dts: mt8183: add pintcrl file
Date: Mon, 18 Feb 2019 10:33:42 -0600	[thread overview]
Message-ID: <20190218163342.GA12014@bogus> (raw)
In-Reply-To: <1550210558-30516-6-git-send-email-erin.lo@mediatek.com>

On Fri, Feb 15, 2019 at 02:02:37PM +0800, Erin Lo wrote:
> This patch adds pinctrl file for mt8183.
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 +++++++++++++++++++++++++
>  1 file changed, 1120 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> new file mode 100644
> index 0000000..768e41e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> @@ -0,0 +1,1120 @@
> +// SPDX-License-Identifier: GPL-2.0

Run checkpatch. It will tell you that this should be /* */ comments.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Erin Lo <erin.lo@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Zhiyong Tao <zhiyong.tao@mediatek.com>,
	linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
	mars.cheng@mediatek.com,
	Matthias Brugger <matthias.bgg@gmail.com>,
	yingjoe.chen@mediatek.com, Thomas Gleixner <tglx@linutronix.de>,
	eddie.huang@mediatek.com, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 5/6] arm64: dts: mt8183: add pintcrl file
Date: Mon, 18 Feb 2019 10:33:42 -0600	[thread overview]
Message-ID: <20190218163342.GA12014@bogus> (raw)
In-Reply-To: <1550210558-30516-6-git-send-email-erin.lo@mediatek.com>

On Fri, Feb 15, 2019 at 02:02:37PM +0800, Erin Lo wrote:
> This patch adds pinctrl file for mt8183.
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 +++++++++++++++++++++++++
>  1 file changed, 1120 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> new file mode 100644
> index 0000000..768e41e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> @@ -0,0 +1,1120 @@
> +// SPDX-License-Identifier: GPL-2.0

Run checkpatch. It will tell you that this should be /* */ comments.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-18 16:33 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  6:02 [PATCH v7 0/6] Add basic and clock support for Mediatek MT8183 SoC Erin Lo
2019-02-15  6:02 ` Erin Lo
2019-02-15  6:02 ` Erin Lo
2019-02-15  6:02 ` [PATCH v7 1/6] dt-bindings: mtk-sysirq: Add compatible for Mediatek MT8183 Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  7:21   ` Matthias Brugger
2019-02-15  7:21     ` Matthias Brugger
2019-02-15  8:57     ` Marc Zyngier
2019-02-15  8:57       ` Marc Zyngier
2019-02-15 10:08   ` Matthias Brugger
2019-02-15 10:08     ` Matthias Brugger
2019-02-15  6:02 ` [PATCH v7 2/6] dt-bindings: serial: " Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02 ` [PATCH v7 3/6] dt-bindings: pinctrl: mt8183: add binding document Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  9:35   ` Matthias Brugger
2019-02-15  9:35     ` Matthias Brugger
2019-02-18  9:44     ` Zhiyong Tao
2019-02-18  9:44       ` Zhiyong Tao
2019-02-18  9:44       ` Zhiyong Tao
2019-02-18 15:48     ` Rob Herring
2019-02-18 15:48       ` Rob Herring
2019-02-18 16:32   ` Rob Herring
2019-02-18 16:32     ` Rob Herring
2019-02-19  2:45     ` Zhiyong Tao
2019-02-19  2:45       ` Zhiyong Tao
2019-02-19  2:45       ` Zhiyong Tao
2019-02-19 15:21       ` Rob Herring
2019-02-19 15:21         ` Rob Herring
2019-02-19 15:21         ` Rob Herring
2019-02-15  6:02 ` [PATCH v7 4/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-18  6:10   ` Erin Lo
2019-02-18  6:10     ` Erin Lo
2019-02-18  6:10     ` Erin Lo
2019-02-15  6:02 ` [PATCH v7 5/6] arm64: dts: mt8183: add pintcrl file Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-18 16:33   ` Rob Herring [this message]
2019-02-18 16:33     ` Rob Herring
2019-02-19  7:45   ` Nicolas Boichat
2019-02-19  7:45     ` Nicolas Boichat
2019-02-19  7:45     ` Nicolas Boichat
2019-02-15  6:02 ` [PATCH v7 6/6] arm64: dts: mt8183: add spi node Erin Lo
2019-02-15  6:02   ` Erin Lo
2019-02-15  6:02   ` Erin Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218163342.GA12014@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=erin.lo@mediatek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mars.cheng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=sboyd@codeaurora.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tglx@linutronix.de \
    --cc=yingjoe.chen@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.