From: Keith Busch <keith.busch@intel.com>
To: 陈华才 <chenhc@lemote.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Huacai Chen <chenhuacai@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
linux-pci <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 1/5] genirq/affinity: don't mark 'affd' as const
Date: Tue, 19 Feb 2019 09:12:57 -0700 [thread overview]
Message-ID: <20190219161256.GA16341@localhost.localdomain> (raw)
In-Reply-To: <tencent_6C5D1EC74B826B1E2F22293C@qq.com>
On Mon, Feb 18, 2019 at 04:42:27PM -0800, 陈华才 wrote:
> I've tested, this patch can fix the nvme problem, but it can't be applied
> to 4.19 because of different context. And, I still think my original solution
> (genirq/affinity: Assign default affinity to pre/post vectors) is correct.
> There may be similar problems except nvme.
I'll send a proper patch to fix the warning. It's always a driver bug if
they try to extract affinity from a non-managed irq, but I don't think
this particular nvme instance is very urgent as the end result is the
same, just without the warning.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V3 1/5] genirq/affinity: don't mark 'affd' as const
Date: Tue, 19 Feb 2019 09:12:57 -0700 [thread overview]
Message-ID: <20190219161256.GA16341@localhost.localdomain> (raw)
In-Reply-To: <tencent_6C5D1EC74B826B1E2F22293C@qq.com>
On Mon, Feb 18, 2019@04:42:27PM -0800, ??? wrote:
> I've tested, this patch can fix the nvme problem, but it can't be applied
> to 4.19 because of different context. And, I still think my original solution
> (genirq/affinity: Assign default affinity to pre/post vectors) is correct.
> There may be similar problems except nvme.
I'll send a proper patch to fix the warning. It's always a driver bug if
they try to extract affinity from a non-managed irq, but I don't think
this particular nvme instance is very urgent as the end result is the
same, just without the warning.
next prev parent reply other threads:[~2019-02-19 16:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 10:50 [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 10:50 ` [PATCH V3 1/5] genirq/affinity: don't mark 'affd' as const Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 15:04 ` Bjorn Helgaas
2019-02-13 15:04 ` Bjorn Helgaas
2019-02-13 20:56 ` Thomas Gleixner
2019-02-13 20:56 ` Thomas Gleixner
2019-02-13 21:31 ` Keith Busch
2019-02-13 21:31 ` Keith Busch
2019-02-13 21:41 ` Thomas Gleixner
2019-02-13 21:41 ` Thomas Gleixner
2019-02-13 22:37 ` Keith Busch
2019-02-13 22:37 ` Keith Busch
2019-02-14 8:50 ` Thomas Gleixner
2019-02-14 8:50 ` Thomas Gleixner
2019-02-14 13:04 ` 陈华才
2019-02-14 13:04 ` 陈华才
2019-02-14 13:31 ` Thomas Gleixner
2019-02-14 13:31 ` Thomas Gleixner
2019-02-19 0:42 ` 陈华才
2019-02-19 0:42 ` 陈华才
2019-02-19 6:19 ` Thomas Gleixner
2019-02-19 6:19 ` Thomas Gleixner
2019-02-19 16:12 ` Keith Busch [this message]
2019-02-19 16:12 ` Keith Busch
2019-02-13 10:50 ` [PATCH V3 2/5] genirq/affinity: store irq set vectors in 'struct irq_affinity' Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 15:07 ` Bjorn Helgaas
2019-02-13 15:07 ` Bjorn Helgaas
2019-02-13 10:50 ` [PATCH V3 3/5] genirq/affinity: add new callback for caculating set vectors Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 15:11 ` Bjorn Helgaas
2019-02-13 15:11 ` Bjorn Helgaas
2019-02-13 20:58 ` Thomas Gleixner
2019-02-13 20:58 ` Thomas Gleixner
2019-02-13 10:50 ` [PATCH V3 4/5] nvme-pci: avoid irq allocation retrying via .calc_sets Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 15:13 ` Bjorn Helgaas
2019-02-13 15:13 ` Bjorn Helgaas
2019-02-13 21:26 ` Thomas Gleixner
2019-02-13 21:26 ` Thomas Gleixner
2019-02-13 10:50 ` [PATCH V3 5/5] genirq/affinity: Document .calc_sets as required in case of multiple sets Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 15:16 ` Bjorn Helgaas
2019-02-13 15:16 ` Bjorn Helgaas
2019-02-13 14:36 ` [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread Jens Axboe
2019-02-13 14:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219161256.GA16341@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.