All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH V3 3/5] genirq/affinity: add new callback for caculating set vectors
Date: Wed, 13 Feb 2019 21:58:56 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1902132157060.1659@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190213151149.GD96272@google.com>

On Wed, 13 Feb 2019, Bjorn Helgaas wrote:
> > Add a new callback of .calc_sets into 'struct irq_affinity' so that
> > driver can caculate set vectors after IRQ vector is allocated and
> > before spread IRQ vectors. Add 'priv' so that driver may retrieve
> > its private data via the 'struct irq_affinity'.
> 
> s/caculate/calculate/
> 
> I *think* "set vectors" here has something to do with an affinity
> cpumask?  "Set vectors" doesn't seem like quite the right terminology.

See previous mail. Let's stay with 'interrupt sets' and get rid of the
vector naming completely.

Thanks,

	tglx

WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner)
Subject: [PATCH V3 3/5] genirq/affinity: add new callback for caculating set vectors
Date: Wed, 13 Feb 2019 21:58:56 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1902132157060.1659@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190213151149.GD96272@google.com>

On Wed, 13 Feb 2019, Bjorn Helgaas wrote:
> > Add a new callback of .calc_sets into 'struct irq_affinity' so that
> > driver can caculate set vectors after IRQ vector is allocated and
> > before spread IRQ vectors. Add 'priv' so that driver may retrieve
> > its private data via the 'struct irq_affinity'.
> 
> s/caculate/calculate/
> 
> I *think* "set vectors" here has something to do with an affinity
> cpumask?  "Set vectors" doesn't seem like quite the right terminology.

See previous mail. Let's stay with 'interrupt sets' and get rid of the
vector naming completely.

Thanks,

	tglx

  reply	other threads:[~2019-02-13 20:59 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 10:50 [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread Ming Lei
2019-02-13 10:50 ` Ming Lei
2019-02-13 10:50 ` [PATCH V3 1/5] genirq/affinity: don't mark 'affd' as const Ming Lei
2019-02-13 10:50   ` Ming Lei
2019-02-13 15:04   ` Bjorn Helgaas
2019-02-13 15:04     ` Bjorn Helgaas
2019-02-13 20:56     ` Thomas Gleixner
2019-02-13 20:56       ` Thomas Gleixner
2019-02-13 21:31       ` Keith Busch
2019-02-13 21:31         ` Keith Busch
2019-02-13 21:41         ` Thomas Gleixner
2019-02-13 21:41           ` Thomas Gleixner
2019-02-13 22:37           ` Keith Busch
2019-02-13 22:37             ` Keith Busch
2019-02-14  8:50             ` Thomas Gleixner
2019-02-14  8:50               ` Thomas Gleixner
2019-02-14 13:04               ` 陈华才
2019-02-14 13:04                 ` 陈华才
2019-02-14 13:31                 ` Thomas Gleixner
2019-02-14 13:31                   ` Thomas Gleixner
2019-02-19  0:42                   ` 陈华才
2019-02-19  0:42                     ` 陈华才
2019-02-19  6:19                     ` Thomas Gleixner
2019-02-19  6:19                       ` Thomas Gleixner
2019-02-19 16:12                     ` Keith Busch
2019-02-19 16:12                       ` Keith Busch
2019-02-13 10:50 ` [PATCH V3 2/5] genirq/affinity: store irq set vectors in 'struct irq_affinity' Ming Lei
2019-02-13 10:50   ` Ming Lei
2019-02-13 15:07   ` Bjorn Helgaas
2019-02-13 15:07     ` Bjorn Helgaas
2019-02-13 10:50 ` [PATCH V3 3/5] genirq/affinity: add new callback for caculating set vectors Ming Lei
2019-02-13 10:50   ` Ming Lei
2019-02-13 15:11   ` Bjorn Helgaas
2019-02-13 15:11     ` Bjorn Helgaas
2019-02-13 20:58     ` Thomas Gleixner [this message]
2019-02-13 20:58       ` Thomas Gleixner
2019-02-13 10:50 ` [PATCH V3 4/5] nvme-pci: avoid irq allocation retrying via .calc_sets Ming Lei
2019-02-13 10:50   ` Ming Lei
2019-02-13 15:13   ` Bjorn Helgaas
2019-02-13 15:13     ` Bjorn Helgaas
2019-02-13 21:26     ` Thomas Gleixner
2019-02-13 21:26       ` Thomas Gleixner
2019-02-13 10:50 ` [PATCH V3 5/5] genirq/affinity: Document .calc_sets as required in case of multiple sets Ming Lei
2019-02-13 10:50   ` Ming Lei
2019-02-13 15:16   ` Bjorn Helgaas
2019-02-13 15:16     ` Bjorn Helgaas
2019-02-13 14:36 ` [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread Jens Axboe
2019-02-13 14:36   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1902132157060.1659@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=helgaas@kernel.org \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.