From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: thierry.reding@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] pwm: atmel: add support for SAM9X60's PWM controller
Date: Fri, 22 Feb 2019 10:27:53 +0100 [thread overview]
Message-ID: <20190222092753.jv5yzuqiijp4lqys@pengutronix.de> (raw)
In-Reply-To: <12a63031-596c-77a3-f10c-be276d75e82c@microchip.com>
Hello,
On Fri, Feb 22, 2019 at 09:07:57AM +0000, Claudiu.Beznea@microchip.com wrote:
> On 21.02.2019 22:45, Uwe Kleine-König wrote:
> > On Tue, Feb 19, 2019 at 10:09:00AM +0000, Claudiu.Beznea@microchip.com wrote:
> > I wonder how the naming of the defines is chosen given that pwm_data_v3
> > is the first that needs PWM_MAXV2_PRD. Looks inconsistent.
>
> I know... I'm aware of that. The thing is controllers may differ with
> regards to in-flight duty update and now there is this new difference w/
> regards to counters size.
>
> Renaming the objects of type atmel_pwm_data in something like
> atmel_pwm_data_<chip-name> as you suggested before would make things clear
> for you?
Yes. Naming stuff after the first SoC that hat the respective
feature/quirk/property should be fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
Ludovic.Desroches@microchip.com, thierry.reding@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] pwm: atmel: add support for SAM9X60's PWM controller
Date: Fri, 22 Feb 2019 10:27:53 +0100 [thread overview]
Message-ID: <20190222092753.jv5yzuqiijp4lqys@pengutronix.de> (raw)
In-Reply-To: <12a63031-596c-77a3-f10c-be276d75e82c@microchip.com>
Hello,
On Fri, Feb 22, 2019 at 09:07:57AM +0000, Claudiu.Beznea@microchip.com wrote:
> On 21.02.2019 22:45, Uwe Kleine-König wrote:
> > On Tue, Feb 19, 2019 at 10:09:00AM +0000, Claudiu.Beznea@microchip.com wrote:
> > I wonder how the naming of the defines is chosen given that pwm_data_v3
> > is the first that needs PWM_MAXV2_PRD. Looks inconsistent.
>
> I know... I'm aware of that. The thing is controllers may differ with
> regards to in-flight duty update and now there is this new difference w/
> regards to counters size.
>
> Renaming the objects of type atmel_pwm_data in something like
> atmel_pwm_data_<chip-name> as you suggested before would make things clear
> for you?
Yes. Naming stuff after the first SoC that hat the respective
feature/quirk/property should be fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
Ludovic.Desroches@microchip.com, thierry.reding@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] pwm: atmel: add support for SAM9X60's PWM controller
Date: Fri, 22 Feb 2019 10:27:53 +0100 [thread overview]
Message-ID: <20190222092753.jv5yzuqiijp4lqys@pengutronix.de> (raw)
In-Reply-To: <12a63031-596c-77a3-f10c-be276d75e82c@microchip.com>
Hello,
On Fri, Feb 22, 2019 at 09:07:57AM +0000, Claudiu.Beznea@microchip.com wrote:
> On 21.02.2019 22:45, Uwe Kleine-König wrote:
> > On Tue, Feb 19, 2019 at 10:09:00AM +0000, Claudiu.Beznea@microchip.com wrote:
> > I wonder how the naming of the defines is chosen given that pwm_data_v3
> > is the first that needs PWM_MAXV2_PRD. Looks inconsistent.
>
> I know... I'm aware of that. The thing is controllers may differ with
> regards to in-flight duty update and now there is this new difference w/
> regards to counters size.
>
> Renaming the objects of type atmel_pwm_data in something like
> atmel_pwm_data_<chip-name> as you suggested before would make things clear
> for you?
Yes. Naming stuff after the first SoC that hat the respective
feature/quirk/property should be fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-22 9:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 10:08 [PATCH v2 0/4] add support for the new SAM9X60's PWM controller Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-19 10:08 ` [PATCH v2 1/4] pwm: atmel: add struct atmel_pwm_data Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-21 20:13 ` Uwe Kleine-König
2019-02-21 20:13 ` Uwe Kleine-König
2019-02-19 10:08 ` [PATCH v2 2/4] pwm: atmel: add support for controllers with 32 bit counters Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-19 10:08 ` Claudiu.Beznea
2019-02-21 20:42 ` Uwe Kleine-König
2019-02-21 20:42 ` Uwe Kleine-König
2019-02-22 9:10 ` Claudiu.Beznea
2019-02-22 9:10 ` Claudiu.Beznea
2019-02-22 9:10 ` Claudiu.Beznea
2019-02-19 10:09 ` [PATCH v2 3/4] pwm: atmel: add support for SAM9X60's PWM controller Claudiu.Beznea
2019-02-19 10:09 ` Claudiu.Beznea
2019-02-19 10:09 ` Claudiu.Beznea
2019-02-21 20:45 ` Uwe Kleine-König
2019-02-21 20:45 ` Uwe Kleine-König
2019-02-22 9:07 ` Claudiu.Beznea
2019-02-22 9:07 ` Claudiu.Beznea
2019-02-22 9:07 ` Claudiu.Beznea
2019-02-22 9:27 ` Uwe Kleine-König [this message]
2019-02-22 9:27 ` Uwe Kleine-König
2019-02-22 9:27 ` Uwe Kleine-König
2019-02-19 10:09 ` [PATCH v2 4/4] pwm: atmel: add PWM binding for SAM9X60 Claudiu.Beznea
2019-02-19 10:09 ` Claudiu.Beznea
2019-02-19 10:09 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222092753.jv5yzuqiijp4lqys@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.