* [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-02-25 11:55 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-02-25 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Do not use it on older gens.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Tony Ye <tony.ye@intel.com>
---
lib/intel_batchbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index b2169a1aa145..6e6bcdeba8a6 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
{
igt_vme_func_t fill = NULL;
- if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
+ if (IS_GEN11(devid))
fill = gen11_media_vme_func;
return fill;
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-02-25 11:55 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-02-25 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: Tony Ye, Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Do not use it on older gens.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Tony Ye <tony.ye@intel.com>
---
lib/intel_batchbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index b2169a1aa145..6e6bcdeba8a6 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
{
igt_vme_func_t fill = NULL;
- if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
+ if (IS_GEN11(devid))
fill = gen11_media_vme_func;
return fill;
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-02-25 11:55 ` [igt-dev] " Tvrtko Ursulin
@ 2019-02-25 11:57 ` Tvrtko Ursulin
-1 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-02-25 11:57 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
On 25/02/2019 11:55, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Do not use it on older gens.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
Regards,
Tvrtko
> Cc: Tony Ye <tony.ye@intel.com>
> ---
> lib/intel_batchbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index b2169a1aa145..6e6bcdeba8a6 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
> {
> igt_vme_func_t fill = NULL;
>
> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
> + if (IS_GEN11(devid))
> fill = gen11_media_vme_func;
>
> return fill;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-02-25 11:57 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-02-25 11:57 UTC (permalink / raw)
To: igt-dev; +Cc: Tony Ye, Intel-gfx, Tvrtko Ursulin
On 25/02/2019 11:55, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Do not use it on older gens.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
Regards,
Tvrtko
> Cc: Tony Ye <tony.ye@intel.com>
> ---
> lib/intel_batchbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index b2169a1aa145..6e6bcdeba8a6 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
> {
> igt_vme_func_t fill = NULL;
>
> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
> + if (IS_GEN11(devid))
> fill = gen11_media_vme_func;
>
> return fill;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-02-25 11:55 ` [igt-dev] " Tvrtko Ursulin
(?)
(?)
@ 2019-02-25 12:59 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-02-25 12:59 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
URL : https://patchwork.freedesktop.org/series/57182/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5658 -> IGTPW_2507
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57182/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2507 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@basic-rte:
- fi-byt-j1900: PASS -> FAIL [fdo#108800]
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: SKIP [fdo#109271] -> PASS +33
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (44 -> 40)
------------------------------
Additional (1): fi-icl-y
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4854 -> IGTPW_2507
CI_DRM_5658: dc6f5e9c1239d7a4b77e31cfaca48873692d579f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2507: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2507/
IGT_4854: 06b0830fb948b9b632342cd26100342aa01cbc79 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2507/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-02-25 11:55 ` [igt-dev] " Tvrtko Ursulin
` (2 preceding siblings ...)
(?)
@ 2019-02-25 16:16 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-02-25 16:16 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
URL : https://patchwork.freedesktop.org/series/57182/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5658_full -> IGTPW_2507_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2507_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2507_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57182/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2507_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-apl: PASS -> DMESG-WARN
Known issues
------------
Here are the changes found in IGTPW_2507_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preemptive-hang-bsd2:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +31
* igt@gem_media_vme:
- shard-glk: PASS -> SKIP [fdo#109271]
- shard-kbl: PASS -> SKIP [fdo#109271]
- shard-apl: PASS -> SKIP [fdo#109271]
* igt@kms_busy@basic-modeset-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_chamelium@hdmi-crc-single:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +3
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: NOTRUN -> FAIL [fdo#103232]
- shard-apl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_legacy@pipe-c-torture-move:
- shard-kbl: PASS -> DMESG-WARN [fdo#107122]
* igt@kms_flip@flip-vs-rmfb-interruptible:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +10
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +1
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +15
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@cursor-fb-leak-pipe-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@perf_pmu@busy-check-all-vecs0:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +35
* igt@prime_vgem@fence-write-hang:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +30
#### Possible fixes ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
- shard-kbl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_cursor_legacy@pipe-c-torture-bo:
- shard-hsw: DMESG-WARN [fdo#107122] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS +1
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4854 -> IGTPW_2507
* Piglit: piglit_4509 -> None
CI_DRM_5658: dc6f5e9c1239d7a4b77e31cfaca48873692d579f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2507: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2507/
IGT_4854: 06b0830fb948b9b632342cd26100342aa01cbc79 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2507/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-02-25 11:57 ` Tvrtko Ursulin
@ 2019-03-24 13:02 ` Ye, Tony
-1 siblings, 0 replies; 12+ messages in thread
From: Ye, Tony @ 2019-03-24 13:02 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
The kernel was design for Gen11 and the author didn't guarantee it could
work on APL. And the binary was built with iga64 with "-p=11" option. If
you try to build it with "-p=9" you will get "error: NoPreempt not
supported on given platform".
As the purpose of this test was to test the asymmetric subslice of
Gen11, I would suggest to remove the support of Gen9 and Gen10. The
patch looks good to me.
Regards,
Tony
On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>
> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Do not use it on older gens.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>
> Regards,
>
> Tvrtko
>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>> lib/intel_batchbuffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index b2169a1aa145..6e6bcdeba8a6 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>> {
>> igt_vme_func_t fill = NULL;
>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>> + if (IS_GEN11(devid))
>> fill = gen11_media_vme_func;
>> return fill;
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-03-24 13:02 ` Ye, Tony
0 siblings, 0 replies; 12+ messages in thread
From: Ye, Tony @ 2019-03-24 13:02 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
The kernel was design for Gen11 and the author didn't guarantee it could
work on APL. And the binary was built with iga64 with "-p=11" option. If
you try to build it with "-p=9" you will get "error: NoPreempt not
supported on given platform".
As the purpose of this test was to test the asymmetric subslice of
Gen11, I would suggest to remove the support of Gen9 and Gen10. The
patch looks good to me.
Regards,
Tony
On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>
> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Do not use it on older gens.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>
> Regards,
>
> Tvrtko
>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>> lib/intel_batchbuffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index b2169a1aa145..6e6bcdeba8a6 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>> {
>> igt_vme_func_t fill = NULL;
>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>> + if (IS_GEN11(devid))
>> fill = gen11_media_vme_func;
>> return fill;
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-03-24 13:02 ` Ye, Tony
@ 2019-03-25 10:22 ` Tvrtko Ursulin
-1 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-03-25 10:22 UTC (permalink / raw)
To: Ye, Tony, igt-dev; +Cc: Intel-gfx
Hi Toni,
On 24/03/2019 13:02, Ye, Tony wrote:
> The kernel was design for Gen11 and the author didn't guarantee it could
> work on APL. And the binary was built with iga64 with "-p=11" option. If
> you try to build it with "-p=9" you will get "error: NoPreempt not
> supported on given platform".
> As the purpose of this test was to test the asymmetric subslice of
> Gen11, I would suggest to remove the support of Gen9 and Gen10. The
> patch looks good to me.
Can I have your formal Reviewed-by: or at least Acked-by: so I can push
the fix in?
Thanks,
Tvrtko
>
> Regards,
>
> Tony
>
> On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>>
>> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Do not use it on older gens.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>>
>> Regards,
>>
>> Tvrtko
>>
>>> Cc: Tony Ye <tony.ye@intel.com>
>>> ---
>>> lib/intel_batchbuffer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>>> index b2169a1aa145..6e6bcdeba8a6 100644
>>> --- a/lib/intel_batchbuffer.c
>>> +++ b/lib/intel_batchbuffer.c
>>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>>> {
>>> igt_vme_func_t fill = NULL;
>>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>>> + if (IS_GEN11(devid))
>>> fill = gen11_media_vme_func;
>>> return fill;
>>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-03-25 10:22 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2019-03-25 10:22 UTC (permalink / raw)
To: Ye, Tony, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Hi Toni,
On 24/03/2019 13:02, Ye, Tony wrote:
> The kernel was design for Gen11 and the author didn't guarantee it could
> work on APL. And the binary was built with iga64 with "-p=11" option. If
> you try to build it with "-p=9" you will get "error: NoPreempt not
> supported on given platform".
> As the purpose of this test was to test the asymmetric subslice of
> Gen11, I would suggest to remove the support of Gen9 and Gen10. The
> patch looks good to me.
Can I have your formal Reviewed-by: or at least Acked-by: so I can push
the fix in?
Thanks,
Tvrtko
>
> Regards,
>
> Tony
>
> On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>>
>> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Do not use it on older gens.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>>
>> Regards,
>>
>> Tvrtko
>>
>>> Cc: Tony Ye <tony.ye@intel.com>
>>> ---
>>> lib/intel_batchbuffer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>>> index b2169a1aa145..6e6bcdeba8a6 100644
>>> --- a/lib/intel_batchbuffer.c
>>> +++ b/lib/intel_batchbuffer.c
>>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>>> {
>>> igt_vme_func_t fill = NULL;
>>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>>> + if (IS_GEN11(devid))
>>> fill = gen11_media_vme_func;
>>> return fill;
>>>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
2019-03-25 10:22 ` Tvrtko Ursulin
@ 2019-03-25 16:58 ` Ye, Tony
-1 siblings, 0 replies; 12+ messages in thread
From: Ye, Tony @ 2019-03-25 16:58 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
On 3/25/2019 6:22 PM, Tvrtko Ursulin wrote:
>
> Hi Toni,
>
> On 24/03/2019 13:02, Ye, Tony wrote:
>> The kernel was designed for Gen11 and the author didn't guarantee it
>> could work on APL. And the binary was built with iga64 with "-p=11"
>> option. If you try to build it with "-p=9" you will get "error:
>> NoPreempt not supported on given platform".
>> As the purpose of this test was to test the asymmetric subslice of
>> Gen11, I would suggest to remove the support of Gen9 and Gen10. The
>> patch looks good to me.
>
> Can I have your formal Reviewed-by: or at least Acked-by: so I can
> push the fix in?
Reviewed-by: Tony Ye <tony.ye@intel.com>
>
> Thanks,
>
> Tvrtko
>
>>
>> Regards,
>>
>> Tony
>>
>> On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>>>
>>> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Do not use it on older gens.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>>>
>>> Regards,
>>>
>>> Tvrtko
>>>
>>>> Cc: Tony Ye <tony.ye@intel.com>
>>>> ---
>>>> lib/intel_batchbuffer.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>>>> index b2169a1aa145..6e6bcdeba8a6 100644
>>>> --- a/lib/intel_batchbuffer.c
>>>> +++ b/lib/intel_batchbuffer.c
>>>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>>>> {
>>>> igt_vme_func_t fill = NULL;
>>>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>>>> + if (IS_GEN11(devid))
>>>> fill = gen11_media_vme_func;
>>>> return fill;
>>>>
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
@ 2019-03-25 16:58 ` Ye, Tony
0 siblings, 0 replies; 12+ messages in thread
From: Ye, Tony @ 2019-03-25 16:58 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
On 3/25/2019 6:22 PM, Tvrtko Ursulin wrote:
>
> Hi Toni,
>
> On 24/03/2019 13:02, Ye, Tony wrote:
>> The kernel was designed for Gen11 and the author didn't guarantee it
>> could work on APL. And the binary was built with iga64 with "-p=11"
>> option. If you try to build it with "-p=9" you will get "error:
>> NoPreempt not supported on given platform".
>> As the purpose of this test was to test the asymmetric subslice of
>> Gen11, I would suggest to remove the support of Gen9 and Gen10. The
>> patch looks good to me.
>
> Can I have your formal Reviewed-by: or at least Acked-by: so I can
> push the fix in?
Reviewed-by: Tony Ye <tony.ye@intel.com>
>
> Thanks,
>
> Tvrtko
>
>>
>> Regards,
>>
>> Tony
>>
>> On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>>>
>>> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Do not use it on older gens.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>>>
>>> Regards,
>>>
>>> Tvrtko
>>>
>>>> Cc: Tony Ye <tony.ye@intel.com>
>>>> ---
>>>> lib/intel_batchbuffer.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>>>> index b2169a1aa145..6e6bcdeba8a6 100644
>>>> --- a/lib/intel_batchbuffer.c
>>>> +++ b/lib/intel_batchbuffer.c
>>>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>>>> {
>>>> igt_vme_func_t fill = NULL;
>>>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>>>> + if (IS_GEN11(devid))
>>>> fill = gen11_media_vme_func;
>>>> return fill;
>>>>
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-25 16:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 11:55 [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11 Tvrtko Ursulin
2019-02-25 11:55 ` [igt-dev] " Tvrtko Ursulin
2019-02-25 11:57 ` Tvrtko Ursulin
2019-02-25 11:57 ` Tvrtko Ursulin
2019-03-24 13:02 ` Ye, Tony
2019-03-24 13:02 ` Ye, Tony
2019-03-25 10:22 ` Tvrtko Ursulin
2019-03-25 10:22 ` Tvrtko Ursulin
2019-03-25 16:58 ` Ye, Tony
2019-03-25 16:58 ` Ye, Tony
2019-02-25 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-25 16:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.