All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org,
	dmitry.torokhov@gmail.com, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org,
	Martin Kepplinger <martin.kepplinger@ginzinger.com>
Subject: Re: [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property
Date: Mon, 25 Feb 2019 08:43:28 -0600	[thread overview]
Message-ID: <20190225144328.GA13518@bogus> (raw)
In-Reply-To: <20190129102347.27754-1-martink@posteo.de>

On Tue, Jan 29, 2019 at 11:23:46AM +0100, Martin Kepplinger wrote:
> From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> 
> The st1232 driver reads this via gpiod.

What a driver does is not relevant to the binding. This breaks 
compatibility so you need to mention that and why this is okay.

Either you need to keep 'gpios' as deprecated or you can drop it if 
there aren't any dts files using it.

> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
>  .../devicetree/bindings/input/touchscreen/sitronix-st1232.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt b/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> index e73e826e0f2a..365b32d30d4b 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> @@ -8,7 +8,7 @@ Required properties:
>  - interrupts: interrupt to which the chip is connected
>  
>  Optional properties:
> -- gpios: a phandle to the reset GPIO
> +- reset-gpios: a phandle to the reset GPIO
>  
>  Example:
>  
> @@ -19,7 +19,7 @@ Example:
>  			compatible = "sitronix,st1232";
>  			reg = <0x55>;
>  			interrupts = <2 0>;
> -			gpios = <&gpio1 166 0>;
> +			reset-gpios = <&gpio1 166 0>;
>  		};
>  
>  		/* ... */
> -- 
> 2.20.1
> 

  parent reply	other threads:[~2019-02-25 14:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 10:23 [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Martin Kepplinger
2019-01-29 10:23 ` [PATCH 2/2] Input: st1232 - switch to gpiod API Martin Kepplinger
2019-02-05 10:20   ` Martin Kepplinger
2019-02-05 10:20     ` Martin Kepplinger
2019-02-08  8:05     ` Dmitry Torokhov
2019-02-25 14:43 ` Rob Herring [this message]
2019-02-26  6:18   ` [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Martin Kepplinger
2019-02-26  6:18     ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225144328.GA13518@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.kepplinger@ginzinger.com \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.