All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
To: Rob Herring <robh@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	<dmitry.torokhov@gmail.com>
Cc: <devicetree@vger.kernel.org>, <linux-input@vger.kernel.org>,
	<mark.rutland@arm.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property
Date: Tue, 26 Feb 2019 07:18:09 +0100	[thread overview]
Message-ID: <c3ad1e2a-4adb-7118-5a3f-36743370f9ce@ginzinger.com> (raw)
In-Reply-To: <20190225144328.GA13518@bogus>

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On 25.02.19 15:43, Rob Herring wrote:
> On Tue, Jan 29, 2019 at 11:23:46AM +0100, Martin Kepplinger wrote:
>> From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>
>> The st1232 driver reads this via gpiod.
> 
> What a driver does is not relevant to the binding. This breaks 
> compatibility so you need to mention that and why this is okay.
> 
> Either you need to keep 'gpios' as deprecated or you can drop it if 
> there aren't any dts files using it.
> 

Hi Rob,

The patch is outdated. Dmity took the driver-changes without breaking
the current DT bindings.

                                   martin

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3616 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
To: Rob Herring <robh@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	dmitry.torokhov@gmail.com
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org,
	mark.rutland@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property
Date: Tue, 26 Feb 2019 07:18:09 +0100	[thread overview]
Message-ID: <c3ad1e2a-4adb-7118-5a3f-36743370f9ce@ginzinger.com> (raw)
In-Reply-To: <20190225144328.GA13518@bogus>

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On 25.02.19 15:43, Rob Herring wrote:
> On Tue, Jan 29, 2019 at 11:23:46AM +0100, Martin Kepplinger wrote:
>> From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>
>> The st1232 driver reads this via gpiod.
> 
> What a driver does is not relevant to the binding. This breaks 
> compatibility so you need to mention that and why this is okay.
> 
> Either you need to keep 'gpios' as deprecated or you can drop it if 
> there aren't any dts files using it.
> 

Hi Rob,

The patch is outdated. Dmity took the driver-changes without breaking
the current DT bindings.

                                   martin

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3616 bytes --]

  reply	other threads:[~2019-02-26  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 10:23 [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Martin Kepplinger
2019-01-29 10:23 ` [PATCH 2/2] Input: st1232 - switch to gpiod API Martin Kepplinger
2019-02-05 10:20   ` Martin Kepplinger
2019-02-05 10:20     ` Martin Kepplinger
2019-02-08  8:05     ` Dmitry Torokhov
2019-02-25 14:43 ` [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Rob Herring
2019-02-26  6:18   ` Martin Kepplinger [this message]
2019-02-26  6:18     ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3ad1e2a-4adb-7118-5a3f-36743370f9ce@ginzinger.com \
    --to=martin.kepplinger@ginzinger.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martink@posteo.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.