* [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link
@ 2019-02-27 23:04 José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: José Roberto de Souza @ 2019-02-27 23:04 UTC (permalink / raw)
To: intel-gfx
Atomic state needs to be put even if the commit was successful.
Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index d918be927fc2..34dd5823398a 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3984,12 +3984,7 @@ static int modeset_pipe(struct drm_crtc *crtc,
goto out;
ret = drm_atomic_commit(state);
- if (ret)
- goto out;
-
- return 0;
-
- out:
+out:
drm_atomic_state_put(state);
return ret;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
@ 2019-02-27 23:04 ` José Roberto de Souza
2019-02-28 11:37 ` Ville Syrjälä
2019-02-28 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: José Roberto de Souza @ 2019-02-27 23:04 UTC (permalink / raw)
To: intel-gfx
drm_atomic_commit() call chain already takes care of adding
connectors and planes, so lets no add then manually if not changing
their states.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 34dd5823398a..c22ddde2dfc1 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc *crtc,
crtc_state->mode_changed = true;
- ret = drm_atomic_add_affected_connectors(state, crtc);
- if (ret)
- goto out;
-
- ret = drm_atomic_add_affected_planes(state, crtc);
- if (ret)
- goto out;
-
ret = drm_atomic_commit(state);
out:
drm_atomic_state_put(state);
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
@ 2019-02-28 0:19 ` Patchwork
2019-02-28 0:40 ` Souza, Jose
2019-02-28 11:35 ` [PATCH 1/2] " Ville Syrjälä
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Patchwork @ 2019-02-28 0:19 UTC (permalink / raw)
To: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link
URL : https://patchwork.freedesktop.org/series/57318/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5668 -> Patchwork_12322
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12322 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12322, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57318/revisions/1/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12322:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_objects:
- fi-apl-guc: NOTRUN -> DMESG-WARN
Known issues
------------
Here are the changes found in Patchwork_12322 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_basic@basic-bsd2:
- fi-kbl-7500u: NOTRUN -> SKIP [fdo#109271] +9
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: PASS -> INCOMPLETE [fdo#108569]
* igt@i915_selftest@live_requests:
- fi-snb-2600: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#103841]
* igt@kms_psr@primary_page_flip:
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +40
* igt@runner@aborted:
- fi-kbl-7500u: NOTRUN -> FAIL [fdo#103841]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: DMESG-WARN -> PASS
- {fi-icl-y}: FAIL [fdo#103375] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- {fi-icl-y}: FAIL -> PASS
* igt@gem_mmap_gtt@basic-small-copy:
- {fi-icl-y}: TIMEOUT -> PASS
* igt@kms_busy@basic-flip-b:
- {fi-icl-y}: FAIL [fdo#103182] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
Participating hosts (42 -> 39)
------------------------------
Additional (1): fi-kbl-7500u
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_5668 -> Patchwork_12322
CI_DRM_5668: f31df5b814fb600861b577e2bc2cdb75c8c3e323 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4861: 017d8461ae509b2d8ef5f585de8ad908081d28a0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12322: 8c1a39496e922ad945fb891f7c5ecb36c2ff238f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8c1a39496e92 drm/i915: Don't manually add connectors and planes state
ae104db6497b drm/i915: Fix atomic state leak when resetting HDMI link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12322/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link
2019-02-28 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
@ 2019-02-28 0:40 ` Souza, Jose
0 siblings, 0 replies; 11+ messages in thread
From: Souza, Jose @ 2019-02-28 0:40 UTC (permalink / raw)
To: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4335 bytes --]
On Thu, 2019-02-28 at 00:19 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/i915: Fix atomic state leak
> when resetting HDMI link
> URL : https://patchwork.freedesktop.org/series/57318/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5668 -> Patchwork_12322
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_12322 absolutely need
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the
> changes
> introduced in Patchwork_12322, please notify your bug team to allow
> them
> to document this new failure mode, which will reduce false
> positives in CI.
>
> External URL:
> https://patchwork.freedesktop.org/api/1.0/series/57318/revisions/1/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in
> Patchwork_12322:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live_objects:
> - fi-apl-guc: NOTRUN -> DMESG-WARN
Not related at all.
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_12322 that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@amdgpu/amd_basic@userptr:
> - fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
>
> * igt@gem_exec_basic@basic-bsd2:
> - fi-kbl-7500u: NOTRUN -> SKIP [fdo#109271] +9
>
> * igt@i915_selftest@live_hangcheck:
> - fi-icl-u3: PASS -> INCOMPLETE [fdo#108569]
>
> * igt@i915_selftest@live_requests:
> - fi-snb-2600: PASS -> INCOMPLETE [fdo#105411]
>
> * igt@kms_chamelium@dp-crc-fast:
> - fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#103841]
>
> * igt@kms_psr@primary_page_flip:
> - fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +40
>
> * igt@runner@aborted:
> - fi-kbl-7500u: NOTRUN -> FAIL [fdo#103841]
>
>
> #### Possible fixes ####
>
> * igt@gem_exec_suspend@basic-s3:
> - fi-apl-guc: DMESG-WARN -> PASS
> - {fi-icl-y}: FAIL [fdo#103375] -> PASS
>
> * igt@gem_exec_suspend@basic-s4-devices:
> - {fi-icl-y}: FAIL -> PASS
>
> * igt@gem_mmap_gtt@basic-small-copy:
> - {fi-icl-y}: TIMEOUT -> PASS
>
> * igt@kms_busy@basic-flip-b:
> - {fi-icl-y}: FAIL [fdo#103182] -> PASS
>
>
> {name}: This element is suppressed. This means it is ignored when
> computing
> the status of the difference (SUCCESS, WARNING, or
> FAILURE).
>
> [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
> [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
> [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
> [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>
>
> Participating hosts (42 -> 39)
> ------------------------------
>
> Additional (1): fi-kbl-7500u
> Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-
> 4200u
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_5668 -> Patchwork_12322
>
> CI_DRM_5668: f31df5b814fb600861b577e2bc2cdb75c8c3e323 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4861: 017d8461ae509b2d8ef5f585de8ad908081d28a0 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_12322: 8c1a39496e922ad945fb891f7c5ecb36c2ff238f @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 8c1a39496e92 drm/i915: Don't manually add connectors and planes state
> ae104db6497b drm/i915: Fix atomic state leak when resetting HDMI link
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12322/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
2019-02-28 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
@ 2019-02-28 11:35 ` Ville Syrjälä
2019-03-02 0:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2) Patchwork
2019-03-02 8:25 ` ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Ville Syrjälä @ 2019-02-28 11:35 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Wed, Feb 27, 2019 at 03:04:07PM -0800, José Roberto de Souza wrote:
> Atomic state needs to be put even if the commit was successful.
>
> Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index d918be927fc2..34dd5823398a 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3984,12 +3984,7 @@ static int modeset_pipe(struct drm_crtc *crtc,
> goto out;
>
> ret = drm_atomic_commit(state);
> - if (ret)
> - goto out;
> -
> - return 0;
> -
> - out:
> +out:
/me curses at that counterproductive codingstyle recommendation
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> drm_atomic_state_put(state);
>
> return ret;
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
@ 2019-02-28 11:37 ` Ville Syrjälä
2019-02-28 21:27 ` Souza, Jose
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2019-02-28 11:37 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza wrote:
> drm_atomic_commit() call chain already takes care of adding
> connectors and planes, so lets no add then manually if not changing
> their states.
The specific callgraph would make review easier.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 34dd5823398a..c22ddde2dfc1 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc *crtc,
>
> crtc_state->mode_changed = true;
>
> - ret = drm_atomic_add_affected_connectors(state, crtc);
> - if (ret)
> - goto out;
> -
> - ret = drm_atomic_add_affected_planes(state, crtc);
> - if (ret)
> - goto out;
> -
> ret = drm_atomic_commit(state);
> out:
> drm_atomic_state_put(state);
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
2019-02-28 11:37 ` Ville Syrjälä
@ 2019-02-28 21:27 ` Souza, Jose
2019-03-01 13:43 ` Ville Syrjälä
0 siblings, 1 reply; 11+ messages in thread
From: Souza, Jose @ 2019-02-28 21:27 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]
On Thu, 2019-02-28 at 13:37 +0200, Ville Syrjälä wrote:
> On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza
> wrote:
> > drm_atomic_commit() call chain already takes care of adding
> > connectors and planes, so lets no add then manually if not changing
> > their states.
>
> The specific callgraph would make review easier.
Appending this to the commit message is enough?
drm_atomic_commit()
drm_atomic_check_only()
config->funcs->atomic_check()/intel_atomic_check()
drm_atomic_helper_check()
drm_atomic_helper_check_modeset()
for_each_oldnew_crtc_in_state()
drm_atomic_add_affected
_connectors()
drm_atomic_add_affected
_planes()
>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 34dd5823398a..c22ddde2dfc1 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc
> > *crtc,
> >
> > crtc_state->mode_changed = true;
> >
> > - ret = drm_atomic_add_affected_connectors(state, crtc);
> > - if (ret)
> > - goto out;
> > -
> > - ret = drm_atomic_add_affected_planes(state, crtc);
> > - if (ret)
> > - goto out;
> > -
> > ret = drm_atomic_commit(state);
> > out:
> > drm_atomic_state_put(state);
> > --
> > 2.21.0
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
2019-02-28 21:27 ` Souza, Jose
@ 2019-03-01 13:43 ` Ville Syrjälä
2019-03-02 0:25 ` Souza, Jose
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2019-03-01 13:43 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
On Thu, Feb 28, 2019 at 09:27:48PM +0000, Souza, Jose wrote:
> On Thu, 2019-02-28 at 13:37 +0200, Ville Syrjälä wrote:
> > On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza
> > wrote:
> > > drm_atomic_commit() call chain already takes care of adding
> > > connectors and planes, so lets no add then manually if not changing
> > > their states.
> >
> > The specific callgraph would make review easier.
>
> Appending this to the commit message is enough?
>
> drm_atomic_commit()
> drm_atomic_check_only()
> config->funcs->atomic_check()/intel_atomic_check()
> drm_atomic_helper_check()
> drm_atomic_helper_check_modeset()
> for_each_oldnew_crtc_in_state()
> drm_atomic_add_affected
> _connectors()
> drm_atomic_add_affected
> _planes()
Yes, that helps. Thanks.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Hmm. I wonder if fastboot has actually broken this code. Maybe we need
to set connectors_changed instead of mode_changed to guarantee the full
modeset...
>
> >
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_ddi.c | 8 --------
> > > 1 file changed, 8 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > > b/drivers/gpu/drm/i915/intel_ddi.c
> > > index 34dd5823398a..c22ddde2dfc1 100644
> > > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > > @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc
> > > *crtc,
> > >
> > > crtc_state->mode_changed = true;
> > >
> > > - ret = drm_atomic_add_affected_connectors(state, crtc);
> > > - if (ret)
> > > - goto out;
> > > -
> > > - ret = drm_atomic_add_affected_planes(state, crtc);
> > > - if (ret)
> > > - goto out;
> > > -
> > > ret = drm_atomic_commit(state);
> > > out:
> > > drm_atomic_state_put(state);
> > > --
> > > 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
2019-03-01 13:43 ` Ville Syrjälä
@ 2019-03-02 0:25 ` Souza, Jose
0 siblings, 0 replies; 11+ messages in thread
From: Souza, Jose @ 2019-03-02 0:25 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2328 bytes --]
On Fri, 2019-03-01 at 15:43 +0200, Ville Syrjälä wrote:
> On Thu, Feb 28, 2019 at 09:27:48PM +0000, Souza, Jose wrote:
> > On Thu, 2019-02-28 at 13:37 +0200, Ville Syrjälä wrote:
> > > On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza
> > > wrote:
> > > > drm_atomic_commit() call chain already takes care of adding
> > > > connectors and planes, so lets no add then manually if not
> > > > changing
> > > > their states.
> > >
> > > The specific callgraph would make review easier.
> >
> > Appending this to the commit message is enough?
> >
> > drm_atomic_commit()
> > drm_atomic_check_only()
> > config->funcs->atomic_check()/intel_atomic_check()
> > drm_atomic_helper_check()
> > drm_atomic_helper_check_modeset()
> > for_each_oldnew_crtc_in_state()
> > drm_atomic_add_affected
> > _connectors()
> > drm_atomic_add_affected
> > _planes()
>
> Yes, that helps. Thanks.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Hmm. I wonder if fastboot has actually broken this code. Maybe we
> need
> to set connectors_changed instead of mode_changed to guarantee the
> full
> modeset...
Just tested and you are right, sending a separated patch to fix this.
>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Lyude Paul <lyude@redhat.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_ddi.c | 8 --------
> > > > 1 file changed, 8 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > > > b/drivers/gpu/drm/i915/intel_ddi.c
> > > > index 34dd5823398a..c22ddde2dfc1 100644
> > > > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > > > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > > > @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc
> > > > *crtc,
> > > >
> > > > crtc_state->mode_changed = true;
> > > >
> > > > - ret = drm_atomic_add_affected_connectors(state, crtc);
> > > > - if (ret)
> > > > - goto out;
> > > > -
> > > > - ret = drm_atomic_add_affected_planes(state, crtc);
> > > > - if (ret)
> > > > - goto out;
> > > > -
> > > > ret = drm_atomic_commit(state);
> > > > out:
> > > > drm_atomic_state_put(state);
> > > > --
> > > > 2.21.0
>
>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2)
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
` (2 preceding siblings ...)
2019-02-28 11:35 ` [PATCH 1/2] " Ville Syrjälä
@ 2019-03-02 0:47 ` Patchwork
2019-03-02 8:25 ` ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-03-02 0:47 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2)
URL : https://patchwork.freedesktop.org/series/57318/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5682 -> Patchwork_12349
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57318/revisions/2/mbox/
Known issues
------------
Here are the changes found in Patchwork_12349 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@memory-alloc:
- fi-ivb-3520m: NOTRUN -> SKIP [fdo#109271] +48
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] +33
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (42 -> 40)
------------------------------
Additional (2): fi-icl-y fi-ivb-3520m
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_5682 -> Patchwork_12349
CI_DRM_5682: e6481defd076c8507c8d5a503b2edd9c7a382ef7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4866: 189956af183c245eb237b3be4fa22953ec93bbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12349: f6a63f57880dcfa00396a42b62b2f465ea56f2a3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f6a63f57880d drm/i915: Don't manually add connectors and planes state
cfc630b1ed47 drm/i915: Fix atomic state leak when resetting HDMI link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12349/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2)
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
` (3 preceding siblings ...)
2019-03-02 0:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2) Patchwork
@ 2019-03-02 8:25 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-03-02 8:25 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2)
URL : https://patchwork.freedesktop.org/series/57318/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5682_full -> Patchwork_12349_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12349_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_cs_tlb@bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +5
* igt@gem_ctx_isolation@bcs0-clean:
- shard-iclb: NOTRUN -> SKIP [fdo#109281] +1
* igt@gem_exec_basic@basic-bsd1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +17
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +39
* igt@gem_mocs_settings@mocs-rc6-vebox:
- shard-iclb: NOTRUN -> SKIP [fdo#109287]
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> SKIP [fdo#109289]
* igt@i915_pm_rpm@gem-mmap-cpu:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724]
* igt@i915_pm_rpm@modeset-lpsp:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
- shard-iclb: PASS -> INCOMPLETE [fdo#108840]
* igt@kms_busy@basic-flip-f:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_chamelium@dp-hpd-storm:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +1
* igt@kms_color@pipe-c-ctm-max:
- shard-skl: NOTRUN -> FAIL [fdo#108147]
* igt@kms_color@pipe-c-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-offscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x170-sliding:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +2
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled:
- shard-skl: NOTRUN -> FAIL [fdo#108472]
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-iclb: PASS -> FAIL [fdo#105363]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-iclb: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-skl: NOTRUN -> FAIL [fdo#105682] +1
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +8
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-blt:
- shard-skl: PASS -> FAIL [fdo#105682]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-msflip-blt:
- shard-glk: NOTRUN -> SKIP [fdo#109271]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- shard-skl: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +3
- shard-iclb: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-iclb: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_scaling@pipe-b-plane-scaling:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@prime_vgem@fence-write-hang:
- shard-iclb: NOTRUN -> SKIP [fdo#109295]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-snb: FAIL [fdo#109661] -> PASS
* igt@gem_eio@suspend:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@i915_pm_rpm@gem-execbuf:
- shard-skl: INCOMPLETE [fdo#107803] / [fdo#107807] -> PASS
* igt@i915_pm_rpm@legacy-planes-dpms:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS
* igt@i915_pm_rpm@universal-planes:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108654] / [fdo#108756] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_psr@no_drrs:
- shard-iclb: FAIL [fdo#108341] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
#### Warnings ####
* igt@i915_pm_backlight@fade_with_suspend:
- shard-iclb: INCOMPLETE [fdo#107713] / [fdo#107820] -> FAIL [fdo#107847]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107803]: https://bugs.freedesktop.org/show_bug.cgi?id=107803
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107820]: https://bugs.freedesktop.org/show_bug.cgi?id=107820
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109281]: https://bugs.freedesktop.org/show_bug.cgi?id=109281
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109287]: https://bugs.freedesktop.org/show_bug.cgi?id=109287
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5682 -> Patchwork_12349
CI_DRM_5682: e6481defd076c8507c8d5a503b2edd9c7a382ef7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4866: 189956af183c245eb237b3be4fa22953ec93bbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12349: f6a63f57880dcfa00396a42b62b2f465ea56f2a3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12349/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-02 8:25 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
2019-02-28 11:37 ` Ville Syrjälä
2019-02-28 21:27 ` Souza, Jose
2019-03-01 13:43 ` Ville Syrjälä
2019-03-02 0:25 ` Souza, Jose
2019-02-28 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
2019-02-28 0:40 ` Souza, Jose
2019-02-28 11:35 ` [PATCH 1/2] " Ville Syrjälä
2019-03-02 0:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2) Patchwork
2019-03-02 8:25 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.