All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: make default autosuspend delay configurable
Date: Fri, 1 Mar 2019 17:23:41 +0100	[thread overview]
Message-ID: <20190301162341.GC19937@kroah.com> (raw)
In-Reply-To: <20190301142646.30831-1-mans@mansr.com>

On Fri, Mar 01, 2019 at 02:26:46PM +0000, Mans Rullgard wrote:
> Make the default autosuspend delay configurable at build time.
> This is useful for systems that require a non-standard value as
> it avoids relying on the command line being properly set.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
>  drivers/usb/core/Kconfig | 8 ++++++++
>  drivers/usb/core/usb.c   | 4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index 4d75d9a80001..38ed837538c4 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
>  	  This driver allows LEDs to be controlled by USB events. Enabling this
>  	  trigger allows specifying list of USB ports that should turn on LED
>  	  when some USB device gets connected.
> +
> +config USB_AUTOSUSPEND_DELAY
> +	int "Default autosuspend delay"
> +	depends on USB
> +	default 2
> +	help
> +	  The default autosuspend delay in seconds.  Can be overridden
> +	  with the usbcore.autosuspend command line or module parameter.

As everyone is suddenly going to be hit with this for a new kernel
upate, you might want to put something in here that says:
	The default value Linux has always had is 2 seconds.  Change
	this value if you want a different delay timeframe and can not
	modify the command line or module parameter option.

to make people a lot more comfortable with this change.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: core: make default autosuspend delay configurable
Date: Fri, 1 Mar 2019 17:23:41 +0100	[thread overview]
Message-ID: <20190301162341.GC19937@kroah.com> (raw)

On Fri, Mar 01, 2019 at 02:26:46PM +0000, Mans Rullgard wrote:
> Make the default autosuspend delay configurable at build time.
> This is useful for systems that require a non-standard value as
> it avoids relying on the command line being properly set.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
>  drivers/usb/core/Kconfig | 8 ++++++++
>  drivers/usb/core/usb.c   | 4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index 4d75d9a80001..38ed837538c4 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
>  	  This driver allows LEDs to be controlled by USB events. Enabling this
>  	  trigger allows specifying list of USB ports that should turn on LED
>  	  when some USB device gets connected.
> +
> +config USB_AUTOSUSPEND_DELAY
> +	int "Default autosuspend delay"
> +	depends on USB
> +	default 2
> +	help
> +	  The default autosuspend delay in seconds.  Can be overridden
> +	  with the usbcore.autosuspend command line or module parameter.

As everyone is suddenly going to be hit with this for a new kernel
upate, you might want to put something in here that says:
	The default value Linux has always had is 2 seconds.  Change
	this value if you want a different delay timeframe and can not
	modify the command line or module parameter option.

to make people a lot more comfortable with this change.

thanks,

greg k-h

  reply	other threads:[~2019-03-01 16:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 14:26 [PATCH] usb: core: make default autosuspend delay configurable Mans Rullgard
2019-03-01 14:26 ` Måns Rullgård
2019-03-01 16:23 ` Greg Kroah-Hartman [this message]
2019-03-01 16:23   ` Greg Kroah-Hartman
2019-03-01 16:43   ` [PATCH v2] " Mans Rullgard
2019-03-01 16:43     ` [v2] " Måns Rullgård
2019-03-01 17:04     ` [PATCH v2] " Greg Kroah-Hartman
2019-03-01 17:04       ` [v2] " Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301162341.GC19937@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mans@mansr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.