[PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Wentao Cai]

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
index 3487510fbd2f..cbbdaaf5c52d 100644
--- a/drivers/staging/most/dim2/errors.h
+++ b/drivers/staging/most/dim2/errors.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * errors.h - Definitions of errors for DIM2 HAL API
  * (MediaLB, Device Interface Macro IP, OS62420)
-- 
2.11.0

[PATCH 2/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Wentao Cai]

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/most/dim2/hal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/dim2/hal.h b/drivers/staging/most/dim2/hal.h
index e04a5350f134..fca6c22de8a6 100644
--- a/drivers/staging/most/dim2/hal.h
+++ b/drivers/staging/most/dim2/hal.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * hal.h - DIM2 HAL interface
  * (MediaLB, Device Interface Macro IP, OS62420)
-- 
2.11.0

[PATCH 3/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Wentao Cai]

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/most/dim2/reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/dim2/reg.h b/drivers/staging/most/dim2/reg.h
index 4343a483017e..b0f36c208a57 100644
--- a/drivers/staging/most/dim2/reg.h
+++ b/drivers/staging/most/dim2/reg.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * reg.h - Definitions for registers of DIM2
  * (MediaLB, Device Interface Macro IP, OS62420)
-- 
2.11.0

[PATCH 4/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Wentao Cai]

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/most/dim2/sysfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/dim2/sysfs.h b/drivers/staging/most/dim2/sysfs.h
index 33756a3bffe2..24277a17cff3 100644
--- a/drivers/staging/most/dim2/sysfs.h
+++ b/drivers/staging/most/dim2/sysfs.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * sysfs.h - MediaLB sysfs information
  *
-- 
2.11.0

Re: [Outreachy kernel] [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Julia Lawall]

On Tue, 5 Mar 2019, Wentao Cai wrote:

> This patch fixes the checkpatch.pl warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Hello,

When you make a series, you should also make a cover letter that gives an
overview of what is done in the series.  You can find information about
how to do this in the tutorial.

Also, previously Greg has asked that patches that add SPDX identifiers be
accompanised by subsequent patches that remove existing boilerplate
license text, if there is any.  So you may want to check on this.

julia


>
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/most/dim2/errors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
> index 3487510fbd2f..cbbdaaf5c52d 100644
> --- a/drivers/staging/most/dim2/errors.h
> +++ b/drivers/staging/most/dim2/errors.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  /*
>   * errors.h - Definitions of errors for DIM2 HAL API
>   * (MediaLB, Device Interface Macro IP, OS62420)
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306043941.6141-1-etsai042%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Greg KH]

On Wed, Mar 06, 2019 at 08:08:59AM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 5 Mar 2019, Wentao Cai wrote:
> 
> > This patch fixes the checkpatch.pl warning:
> > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Hello,
> 
> When you make a series, you should also make a cover letter that gives an
> overview of what is done in the series.  You can find information about
> how to do this in the tutorial.
> 
> Also, previously Greg has asked that patches that add SPDX identifiers be
> accompanised by subsequent patches that remove existing boilerplate
> license text, if there is any.  So you may want to check on this.

These files do not have any license boilerplate, I just used the wrong
comment character when I did the initial conversion to SPDX a year ago
:(

thanks,

greg k-h

Re: [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[Greg KH]

On Tue, Mar 05, 2019 at 08:39:38PM -0800, Wentao Cai wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/most/dim2/errors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All 4 of these patches had the same identical subject line, yet they did
different things :(

Please make them unique by at least adding the filename to the subject
line.  See other patches on this mailing list for examples of how to do
this.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier

[etsai042]

[-- Attachment #1.1: Type: text/plain, Size: 245 bytes --]



>
> >Hello, 
>
> >When you make a series, you should also make a cover letter that gives an 
> >overview of what is done in the series.  You can find information about 
> >how to do this in the tutorial. 
>
 
Sorry, I'll resubmit it!

Wentao 

[-- Attachment #1.2: Type: text/html, Size: 494 bytes --]