[PATCH] Staging: vt6655: Remove an unused function

[PATCH] Staging: vt6655: Remove an unused function

[Madhumitha Prabakaran]

Remove an unused function to improve codebase.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 99de843b4551..59538ac09fc5 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
 			    unsigned char byRetryLimit);
 
 void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
-void MACvGetLongRetryLimit(struct vnt_private *priv,
-			   unsigned char *pbyRetryLimit);
 
 void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function

[Julia Lawall]

On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:

> Remove an unused function to improve codebase.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/vt6655/mac.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index 99de843b4551..59538ac09fc5 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
>  			    unsigned char byRetryLimit);
>
>  void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> -void MACvGetLongRetryLimit(struct vnt_private *priv,
> -			   unsigned char *pbyRetryLimit);

This is the prototype of a function.  Is there a definition somewhere?  If
so, it would be good to remove the definition at the same time.

julia

>
>  void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function

[Madhumthia Prabakaran]

On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> 
> > Remove an unused function to improve codebase.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> >  drivers/staging/vt6655/mac.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index 99de843b4551..59538ac09fc5 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> >  			    unsigned char byRetryLimit);
> >
> >  void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > -			   unsigned char *pbyRetryLimit);
> 
> This is the prototype of a function.  Is there a definition somewhere?  If
> so, it would be good to remove the definition at the same time.
> 
> julia
> 
> >
> >  void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

There is no function definition in the code base. Do you I need to edit the commit log and resend it.

?

Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function

[Madhumthia Prabakaran]

On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> 
> > Remove an unused function to improve codebase.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> >  drivers/staging/vt6655/mac.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index 99de843b4551..59538ac09fc5 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> >  			    unsigned char byRetryLimit);
> >
> >  void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > -			   unsigned char *pbyRetryLimit);
> 
> This is the prototype of a function.  Is there a definition somewhere?  If
> so, it would be good to remove the definition at the same time.
> 
> julia
> 
> >
> >  void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?

thanks,
madhumitha

Re: [PATCH] Staging: vt6655: Remove an unused function

[Greg KH]

On Thu, Mar 07, 2019 at 06:42:36AM -0600, Madhumitha Prabakaran wrote:
> Remove an unused function to improve codebase.

This should probably say something like:
	Remove an unused function prototype as there is no such function
	in the kernel tree.

That's a better description of what this patch is doing, don't you
agree?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function

[Julia Lawall]

On Thu, 7 Mar 2019, Madhumthia Prabakaran wrote:

> On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
> >
> >
> > On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> >
> > > Remove an unused function to improve codebase.
> > >
> > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > ---
> > >  drivers/staging/vt6655/mac.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > > index 99de843b4551..59538ac09fc5 100644
> > > --- a/drivers/staging/vt6655/mac.h
> > > +++ b/drivers/staging/vt6655/mac.h
> > > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> > >  			    unsigned char byRetryLimit);
> > >
> > >  void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > > -			   unsigned char *pbyRetryLimit);
> >
> > This is the prototype of a function.  Is there a definition somewhere?  If
> > so, it would be good to remove the definition at the same time.
> >
> > julia
> >
> > >
> > >  void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> > >
> > > --
> > > 2.17.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?

Same file -> series
Different files -> separate patches are fine.

julia

Re: [PATCH] Staging: vt6655: Remove an unused function

[Madhumthia Prabakaran]

On Thu, Mar 07, 2019 at 08:28:38PM +0100, Greg KH wrote:
> On Thu, Mar 07, 2019 at 06:42:36AM -0600, Madhumitha Prabakaran wrote:
> > Remove an unused function to improve codebase.
> 
> This should probably say something like:
> 	Remove an unused function prototype as there is no such function
> 	in the kernel tree.
> 
> That's a better description of what this patch is doing, don't you
> agree?
> 
> thanks,
> 
> greg k-h

Yes. Will update and resend it.
Thanks.

[PATCH] Staging: vt6655: Remove an unused function

[Madhumitha Prabakaran]

Remove an unused function, as it is never called in kernel tree.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 40a8f1ce837c..2f773fdf8d64 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 59538ac09fc5..c7888c4e96f2 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
-- 
2.17.1