* [PATCH] Staging: vt6655: Remove an unused function
@ 2019-03-07 12:42 Madhumitha Prabakaran
2019-03-07 13:21 ` [Outreachy kernel] " Julia Lawall
2019-03-07 19:28 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-07 12:42 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Remove an unused function to improve codebase.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/mac.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 99de843b4551..59538ac09fc5 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
unsigned char byRetryLimit);
void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
-void MACvGetLongRetryLimit(struct vnt_private *priv,
- unsigned char *pbyRetryLimit);
void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 12:42 [PATCH] Staging: vt6655: Remove an unused function Madhumitha Prabakaran
@ 2019-03-07 13:21 ` Julia Lawall
2019-03-07 15:24 ` Madhumthia Prabakaran
2019-03-07 15:54 ` Madhumthia Prabakaran
2019-03-07 19:28 ` Greg KH
1 sibling, 2 replies; 7+ messages in thread
From: Julia Lawall @ 2019-03-07 13:21 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, gregkh, outreachy-kernel
On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> Remove an unused function to improve codebase.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/vt6655/mac.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index 99de843b4551..59538ac09fc5 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> unsigned char byRetryLimit);
>
> void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> -void MACvGetLongRetryLimit(struct vnt_private *priv,
> - unsigned char *pbyRetryLimit);
This is the prototype of a function. Is there a definition somewhere? If
so, it would be good to remove the definition at the same time.
julia
>
> void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 13:21 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-07 15:24 ` Madhumthia Prabakaran
2019-03-07 15:54 ` Madhumthia Prabakaran
1 sibling, 0 replies; 7+ messages in thread
From: Madhumthia Prabakaran @ 2019-03-07 15:24 UTC (permalink / raw)
To: Julia Lawall, outreachy-kernel
On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
>
>
> On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
>
> > Remove an unused function to improve codebase.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > drivers/staging/vt6655/mac.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index 99de843b4551..59538ac09fc5 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> > unsigned char byRetryLimit);
> >
> > void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > - unsigned char *pbyRetryLimit);
>
> This is the prototype of a function. Is there a definition somewhere? If
> so, it would be good to remove the definition at the same time.
>
> julia
>
> >
> > void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
There is no function definition in the code base. Do you I need to edit the commit log and resend it.
?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 13:21 ` [Outreachy kernel] " Julia Lawall
2019-03-07 15:24 ` Madhumthia Prabakaran
@ 2019-03-07 15:54 ` Madhumthia Prabakaran
2019-03-07 19:34 ` Julia Lawall
1 sibling, 1 reply; 7+ messages in thread
From: Madhumthia Prabakaran @ 2019-03-07 15:54 UTC (permalink / raw)
To: Julia Lawall, outreachy-kernel
On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
>
>
> On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
>
> > Remove an unused function to improve codebase.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > drivers/staging/vt6655/mac.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index 99de843b4551..59538ac09fc5 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> > unsigned char byRetryLimit);
> >
> > void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > - unsigned char *pbyRetryLimit);
>
> This is the prototype of a function. Is there a definition somewhere? If
> so, it would be good to remove the definition at the same time.
>
> julia
>
> >
> > void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?
thanks,
madhumitha
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 12:42 [PATCH] Staging: vt6655: Remove an unused function Madhumitha Prabakaran
2019-03-07 13:21 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-07 19:28 ` Greg KH
2019-03-07 19:46 ` Madhumthia Prabakaran
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2019-03-07 19:28 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Thu, Mar 07, 2019 at 06:42:36AM -0600, Madhumitha Prabakaran wrote:
> Remove an unused function to improve codebase.
This should probably say something like:
Remove an unused function prototype as there is no such function
in the kernel tree.
That's a better description of what this patch is doing, don't you
agree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 15:54 ` Madhumthia Prabakaran
@ 2019-03-07 19:34 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2019-03-07 19:34 UTC (permalink / raw)
To: Madhumthia Prabakaran; +Cc: outreachy-kernel
On Thu, 7 Mar 2019, Madhumthia Prabakaran wrote:
> On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
> >
> >
> > On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> >
> > > Remove an unused function to improve codebase.
> > >
> > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > ---
> > > drivers/staging/vt6655/mac.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > > index 99de843b4551..59538ac09fc5 100644
> > > --- a/drivers/staging/vt6655/mac.h
> > > +++ b/drivers/staging/vt6655/mac.h
> > > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> > > unsigned char byRetryLimit);
> > >
> > > void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > > - unsigned char *pbyRetryLimit);
> >
> > This is the prototype of a function. Is there a definition somewhere? If
> > so, it would be good to remove the definition at the same time.
> >
> > julia
> >
> > >
> > > void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> > >
> > > --
> > > 2.17.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> Also, I found the other function, for which I have to remove function prototype and function definition. So, am i need to submit it as patch series or can i commit in one single patch?
Same file -> series
Different files -> separate patches are fine.
julia
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: vt6655: Remove an unused function
2019-03-07 19:28 ` Greg KH
@ 2019-03-07 19:46 ` Madhumthia Prabakaran
0 siblings, 0 replies; 7+ messages in thread
From: Madhumthia Prabakaran @ 2019-03-07 19:46 UTC (permalink / raw)
To: Greg KH, outreachy-kernel
On Thu, Mar 07, 2019 at 08:28:38PM +0100, Greg KH wrote:
> On Thu, Mar 07, 2019 at 06:42:36AM -0600, Madhumitha Prabakaran wrote:
> > Remove an unused function to improve codebase.
>
> This should probably say something like:
> Remove an unused function prototype as there is no such function
> in the kernel tree.
>
> That's a better description of what this patch is doing, don't you
> agree?
>
> thanks,
>
> greg k-h
Yes. Will update and resend it.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-08 12:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 12:42 [PATCH] Staging: vt6655: Remove an unused function Madhumitha Prabakaran
2019-03-07 13:21 ` [Outreachy kernel] " Julia Lawall
2019-03-07 15:24 ` Madhumthia Prabakaran
2019-03-07 15:54 ` Madhumthia Prabakaran
2019-03-07 19:34 ` Julia Lawall
2019-03-07 19:28 ` Greg KH
2019-03-07 19:46 ` Madhumthia Prabakaran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.