From: Mariusz Bialonczyk <manio@skyboo.net>
To: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <greg@kroah.com>,
Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: Mariusz Bialonczyk <manio@skyboo.net>
Subject: [PATCH 0/2] w1: DS2408 fixes
Date: Mon, 18 Mar 2019 10:27:35 +0100 [thread overview]
Message-ID: <20190318092737.8170-1-manio@skyboo.net> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1235 bytes --]
Hi,
I prepared a two fixes related with 1wire and DS2408.
In short the problem was that a single DS2408 slave was properly setting
the output value to a channel access write but the command was returning
error.
Moreover when there was a write of a 0xff value (all inputs off, there was
also no problem - it's now also understandable for me after looking
at the transmission log) ;)
This problem doesn't occur on a multidrop bus.
Finally I was able to catch the problems recently after analyzing the
oscilloscope waveforms in PulseView.
After those fixes all is now working perfectly fine - no matter if it
is multidrop or single slave bus :)
ps. if you are merging this please also take into account a patch which
I've sent recently but it is still not merged:
https://lore.kernel.org/lkml/20190304112336.21397-1-manio@skyboo.net/
regards,
Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net
https://skyboo.net | https://github.com/manio
Mariusz Bialonczyk (2):
w1: ds2408: add a missing reset when retrying in output_write()
w1: fix the resume command API
drivers/w1/slaves/w1_ds2408.c | 13 ++++++++-----
drivers/w1/w1_io.c | 11 +++++++++--
2 files changed, 17 insertions(+), 7 deletions(-)
--
2.19.0.rc1
next reply other threads:[~2019-03-18 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 9:27 Mariusz Bialonczyk [this message]
2019-03-18 9:27 ` [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write() Mariusz Bialonczyk
2019-03-19 14:21 ` Jean-Francois Dagenais
2019-03-19 14:25 ` Jean-Francois Dagenais
2019-03-21 10:55 ` Mariusz Bialonczyk
2019-03-21 15:18 ` [PATCH v2] w1: ds2408: reset on output_write retry with readback Jean-Francois Dagenais
2019-03-27 16:53 ` Greg Kroah-Hartman
2019-03-28 12:17 ` Jean-Francois Dagenais
2019-04-03 8:33 ` Mariusz Bialonczyk
2019-03-18 9:27 ` [PATCH 2/2] w1: fix the resume command API Mariusz Bialonczyk
2019-03-19 13:21 ` Jean-Francois Dagenais
2019-03-19 14:21 ` Evgeniy Polyakov
2019-03-21 10:11 ` Mariusz Bialonczyk
2019-03-21 10:52 ` [PATCH v2] " Mariusz Bialonczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318092737.8170-1-manio@skyboo.net \
--to=manio@skyboo.net \
--cc=greg@kroah.com \
--cc=jeff.dagenais@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.