All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Bialonczyk <manio@skyboo.net>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write()
Date: Thu, 21 Mar 2019 11:55:11 +0100	[thread overview]
Message-ID: <20190321115511.29f8f6f25a2b9b96c2dd77aa@skyboo.net> (raw)
In-Reply-To: <DF2ABF87-116D-4287-8A18-89C2C59124AF@gmail.com>

On Tue, 19 Mar 2019 10:21:32 -0400
Jean-Francois Dagenais <jeff.dagenais@gmail.com> wrote:

> May I suggest a cleaned up version my original klunky code with your fix in it
> (Note: this is untested, it compiles on arm64, that's all):
Thank you Jean!
I just tested your version - and it is working as expected :)

> I can do a proper patch submission if you guys provide positive response on this
> early RFC. Or better yet, you can take it and own it yourself as your v2
> Mariusz. ;)
No, it's your code, please just submit v2 as yours (I've already sent simplified
version of the patch 1/2 as you suggested).

Just drop the following and all will be fine :)
Reported-by: Mariusz Bialonczyk <manio@skyboo.net>

Thanks!
regards,
-- 
Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net
https://skyboo.net | https://github.com/manio

  parent reply	other threads:[~2019-03-21 10:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18  9:27 [PATCH 0/2] w1: DS2408 fixes Mariusz Bialonczyk
2019-03-18  9:27 ` [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write() Mariusz Bialonczyk
2019-03-19 14:21   ` Jean-Francois Dagenais
2019-03-19 14:25     ` Jean-Francois Dagenais
2019-03-21 10:55     ` Mariusz Bialonczyk [this message]
2019-03-21 15:18   ` [PATCH v2] w1: ds2408: reset on output_write retry with readback Jean-Francois Dagenais
2019-03-27 16:53     ` Greg Kroah-Hartman
2019-03-28 12:17       ` Jean-Francois Dagenais
2019-04-03  8:33         ` Mariusz Bialonczyk
2019-03-18  9:27 ` [PATCH 2/2] w1: fix the resume command API Mariusz Bialonczyk
2019-03-19 13:21   ` Jean-Francois Dagenais
2019-03-19 14:21     ` Evgeniy Polyakov
2019-03-21 10:11       ` Mariusz Bialonczyk
2019-03-21 10:52 ` [PATCH v2] " Mariusz Bialonczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321115511.29f8f6f25a2b9b96c2dd77aa@skyboo.net \
    --to=manio@skyboo.net \
    --cc=greg@kroah.com \
    --cc=jeff.dagenais@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.