All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Bialonczyk <manio@skyboo.net>
To: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <greg@kroah.com>,
	Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: Mariusz Bialonczyk <manio@skyboo.net>
Subject: [PATCH v2] w1: fix the resume command API
Date: Thu, 21 Mar 2019 11:52:55 +0100	[thread overview]
Message-ID: <20190321105255.19126-1-manio@skyboo.net> (raw)
In-Reply-To: <20190318092737.8170-1-manio@skyboo.net>

From the DS2408 datasheet [1]:
"Resume Command function checks the status of the RC flag and, if it is set,
 directly transfers control to the control functions, similar to a Skip ROM
 command. The only way to set the RC flag is through successfully executing
 the Match ROM, Search ROM, Conditional Search ROM, or Overdrive-Match ROM
 command"

The function currently works perfectly fine in a multidrop bus, but when we
have only a single slave connected, then only a Skip ROM is used and Match
ROM is not called at all. This is leading to problems e.g. with single one
DS2408 connected, as the Resume Command is not working properly and the
device is responding with failing results after the Resume Command.

This commit is fixing this by using a Skip ROM instead in those cases.
The bandwidth / performance advantage is exactly the same.

Refs:
[1] https://datasheets.maximintegrated.com/en/ds/DS2408.pdf

Signed-off-by: Mariusz Bialonczyk <manio@skyboo.net>
Reviewed-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
 drivers/w1/w1_io.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c
index 0364d3329c52..3516ce6718d9 100644
--- a/drivers/w1/w1_io.c
+++ b/drivers/w1/w1_io.c
@@ -432,8 +432,7 @@ int w1_reset_resume_command(struct w1_master *dev)
 	if (w1_reset_bus(dev))
 		return -1;
 
-	/* This will make only the last matched slave perform a skip ROM. */
-	w1_write_8(dev, W1_RESUME_CMD);
+	w1_write_8(dev, dev->slave_count > 1 ? W1_RESUME_CMD : W1_SKIP_ROM);
 	return 0;
 }
 EXPORT_SYMBOL_GPL(w1_reset_resume_command);
-- 
2.19.0.rc1


      parent reply	other threads:[~2019-03-21 10:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18  9:27 [PATCH 0/2] w1: DS2408 fixes Mariusz Bialonczyk
2019-03-18  9:27 ` [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write() Mariusz Bialonczyk
2019-03-19 14:21   ` Jean-Francois Dagenais
2019-03-19 14:25     ` Jean-Francois Dagenais
2019-03-21 10:55     ` Mariusz Bialonczyk
2019-03-21 15:18   ` [PATCH v2] w1: ds2408: reset on output_write retry with readback Jean-Francois Dagenais
2019-03-27 16:53     ` Greg Kroah-Hartman
2019-03-28 12:17       ` Jean-Francois Dagenais
2019-04-03  8:33         ` Mariusz Bialonczyk
2019-03-18  9:27 ` [PATCH 2/2] w1: fix the resume command API Mariusz Bialonczyk
2019-03-19 13:21   ` Jean-Francois Dagenais
2019-03-19 14:21     ` Evgeniy Polyakov
2019-03-21 10:11       ` Mariusz Bialonczyk
2019-03-21 10:52 ` Mariusz Bialonczyk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321105255.19126-1-manio@skyboo.net \
    --to=manio@skyboo.net \
    --cc=greg@kroah.com \
    --cc=jeff.dagenais@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.